Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042812
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-01-13 09:042020-01-17 13:22
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision0edea9b024bb
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042812: Apply new HQL Style in AddOrderOrInvoiceFilterExpressionHandler.java

DescriptionAddOrderOrInvoiceFilterExpressionHandler.java has one HQL query with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0116786)
inigo_lerga (reporter)
2020-01-13 10:24

 Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Payment In window and create
      a new record. Press the Add Details
      button.

#In this moment the modified HQL is executed#
(0117017)
hgbot (developer)
2020-01-17 13:21

 Repository: erp/devel/pi
Changeset: 0edea9b024bbd95ddc950762b401b474715ae27c
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Jan 13 10:25:54 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0edea9b024bbd95ddc950762b401b474715ae27c [^]

fixes BUG-42812:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddOrderOrInvoiceFilterExpressionHandler.java
---
(0117018)
hgbot (developer)
2020-01-17 13:21

 Repository: erp/devel/pi
Changeset: 6c27022a0e4006defe0b01f1edaa53d3196505cd
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 17 13:18:07 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6c27022a0e4006defe0b01f1edaa53d3196505cd [^]

Related to ISSUE-42812: Code Review Changes:
* Add final modifier to variables and parameters
* Assign the result of the query to an object to be used
  in the for loop to improve redability

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddOrderOrInvoiceFilterExpressionHandler.java
---
(0117019)
dmiguelez (developer)
2020-01-17 13:22

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-01-13 09:04 inigo_lerga New Issue
2020-01-13 09:04 inigo_lerga Assigned To => inigo_lerga
2020-01-13 09:04 inigo_lerga Modules => Core
2020-01-13 09:04 inigo_lerga Triggers an Emergency Pack => No
2020-01-13 09:04 inigo_lerga Status new => scheduled
2020-01-13 09:05 inigo_lerga Relationship added related to 0041287
2020-01-13 10:24 inigo_lerga Note Added: 0116786
2020-01-13 10:32 inigo_lerga Description Updated View Revisions
2020-01-17 13:21 hgbot Checkin
2020-01-17 13:21 hgbot Note Added: 0117017
2020-01-17 13:21 hgbot Status scheduled => resolved
2020-01-17 13:21 hgbot Resolution open => fixed
2020-01-17 13:21 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0edea9b024bbd95ddc950762b401b474715ae27c [^]
2020-01-17 13:21 hgbot Checkin
2020-01-17 13:21 hgbot Note Added: 0117018
2020-01-17 13:22 dmiguelez Review Assigned To => dmiguelez
2020-01-17 13:22 dmiguelez Note Added: 0117019
2020-01-17 13:22 dmiguelez Status resolved => closed
2020-01-17 13:22 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker