Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042812Openbravo ERPA. Platformpublic2020-01-13 09:042020-01-17 13:22
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042812: Apply new HQL Style in AddOrderOrInvoiceFilterExpressionHandler.java
DescriptionAddOrderOrInvoiceFilterExpressionHandler.java has one HQL query with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-13 09:04inigo_lergaNew Issue
2020-01-13 09:04inigo_lergaAssigned To => inigo_lerga
2020-01-13 09:04inigo_lergaOBNetwork customer => No
2020-01-13 09:04inigo_lergaModules => Core
2020-01-13 09:04inigo_lergaTriggers an Emergency Pack => No
2020-01-13 09:04inigo_lergaStatusnew => scheduled
2020-01-13 09:05inigo_lergaRelationship addedrelated to 0041287
2020-01-13 10:24inigo_lergaNote Added: 0116786
2020-01-13 10:32inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20085#r20085
2020-01-17 13:21hgbotCheckin
2020-01-17 13:21hgbotNote Added: 0117017
2020-01-17 13:21hgbotStatusscheduled => resolved
2020-01-17 13:21hgbotResolutionopen => fixed
2020-01-17 13:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0edea9b024bbd95ddc950762b401b474715ae27c [^]
2020-01-17 13:21hgbotCheckin
2020-01-17 13:21hgbotNote Added: 0117018
2020-01-17 13:22dmiguelezReview Assigned To => dmiguelez
2020-01-17 13:22dmiguelezNote Added: 0117019
2020-01-17 13:22dmiguelezStatusresolved => closed
2020-01-17 13:22dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116786)
inigo_lerga   
2020-01-13 10:24   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Payment In window and create
      a new record. Press the Add Details
      button.

#In this moment the modified HQL is executed#
(0117017)
hgbot   
2020-01-17 13:21   
Repository: erp/devel/pi
Changeset: 0edea9b024bbd95ddc950762b401b474715ae27c
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Jan 13 10:25:54 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0edea9b024bbd95ddc950762b401b474715ae27c [^]

fixes BUG-42812:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddOrderOrInvoiceFilterExpressionHandler.java
---
(0117018)
hgbot   
2020-01-17 13:21   
Repository: erp/devel/pi
Changeset: 6c27022a0e4006defe0b01f1edaa53d3196505cd
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 17 13:18:07 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6c27022a0e4006defe0b01f1edaa53d3196505cd [^]

Related to ISSUE-42812: Code Review Changes:
* Add final modifier to variables and parameters
* Assign the result of the query to an object to be used
  in the for loop to improve redability

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddOrderOrInvoiceFilterExpressionHandler.java
---
(0117019)
dmiguelez   
2020-01-17 13:22   
Code Review + Testing Ok