0042811: [20Q1] [NewSkin] [UX] Receipt lines pin button has irregular behaviour on touch devices

Description

The pushpin shaped button at the top right side of the receipt presents the following two irregular behaviours:

- It shows as active, in spite of touching on it again to uncheck it. The intended functionality of the button isn't compromised, as the checklist shaped "Select all"
button is hidden, and the lines can then be selected individually as usual
- The button can sometimes be hard to press, and depending on where it's pressed, the event that makes the button become grey is triggered

Check the following attached video that depicts these behaviours in detail:
https://drive.google.com/open?id=0B7v8HlaHNHiEbFE2Z3VHa0piazhUaVVfamF5US1zQnhrV1BN [^]

This issue is reproducible on 20Q1 on the Galaxy Tab A6 tablet but not in 19Q4, thus meaning that this is a usability regression introduced by the new skin.

Steps To Reproduce

0. Log in the Web POS
1. Add some lines to the ticket
2. Click on one of the lines of the ticket. The pin button will appear
3. Check the button to test its functionality, and uncheck and check it again to test the behaviours described in the description

Proposed Solution

The solution applied for this issue that used to be reproducible too with the previous skin, was to switch places with the "Select all" button once the pin
button was checked. This reduced the risk of the pin button being mis-clicked. I've been unable to find the original issue that I reported, but do recall
having reported it verbally or via email with Retail team, and having applied the mentioned solution after having arised this issue sometime in the second
half of 2018 and first half of 2019.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0042751

closed

prakashmurugesan88

[20Q1] [NewSkin] [UX] Receipt lines pin button has irregular behaviour on touch devices

Notes
(0117005) hgbot (developer) 2020-01-17 11:53	Repository: retail/backports/3.0RR20Q1/org.openbravo.retail.posterminal Changeset: 6b94ce2da7a24c2656bb44a116ff93038c45b3d1 Author: Prakash M <prakash <at> qualiantech.com> Date: Fri Jan 17 12:44:09 2020 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR20Q1/org.openbravo.retail.posterminal/rev/6b94ce2da7a24c2656bb44a116ff93038c45b3d1 [^] Fixed issue 42811 : Fixed receipt lines pin icon irregular behaviour on touch devices * Also added media query for hover which is not required in touch devices --- M web/org.openbravo.retail.posterminal/css/obpos-main.css ---

Issue History
Date Modified	Username	Field	Change
2020-01-13 06:48	prakashmurugesan88	Type	defect => backport
2020-01-13 06:48	prakashmurugesan88	Target Version	=> RR20Q1
2020-01-17 11:53	hgbot	Checkin
2020-01-17 11:53	hgbot	Note Added: 0117005
2020-01-17 11:53	hgbot	Status	scheduled => resolved
2020-01-17 11:53	hgbot	Resolution	open => fixed
2020-01-17 11:53	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1d8345a6dcd01c884d72362a9b7a5da6e5694dd9 [^] => http://code.openbravo.com/retail/backports/3.0RR20Q1/org.openbravo.retail.posterminal/rev/6b94ce2da7a24c2656bb44a116ff93038c45b3d1 [^]
2020-01-21 12:59	gorka_gil	Review Assigned To	=> gorka_gil
2020-01-21 12:59	gorka_gil	Status	resolved => closed
2020-01-21 12:59	gorka_gil	Fixed in Version	=> RR20Q1