0042679: The partial prepayment button doesn't work in some cases

Description

When using prepayments, there are some cases in which the 'Pay Partial' button doesn't work correctly. When clicking the button, instead of paying only the partial amount for the delivery (the prepayment amount), it is fully paid.

Steps To Reproduce

- Log in in the Web POS with a terminal with prepayments configured (OMNI-1).
- Add the customer 'Arturo Montoro' to the ticket.
- Add an 'Avalanche transceiver' line and an 'Insect repellent' line.
- Set price 5€ to the 'Avalanche transceiver' line and 10€ to the 'Insect repellent' line.
- Set the 'Avalanche transceiver' as not deliverable.
- Click on the total amount button. Check that the remaining for the delivery is 10€, and the remaining for total is 10€.
- Add a payment with quantity 8€ of type 'Cash'.
- Select the payment method 'Card'.
- Click on the 'Pay Partial' button --> The full ticket is paid, instead the prepayment.

Proposed Solution

In the 'payDeliveryOrExact' function, this check is done to update the amount to add to the ticket:

if (
  payPrepayment &&
  pendingPrepayment > 0 &&
  pendingPrepayment < amount
) {
  ...
}

The 'pendingPrepayment' is the prepayment amount, instead of the remaining amount to pay the prepayment. It should be adapted to calculate that amount minus the paid amount (check the 'paymentWithSign' property for that).

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0116777) hgbot (developer) 2020-01-12 15:55	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e367de27a57ea6cae58c8aa0ff522b93b5610efd Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Wed Jan 08 17:10:33 2020 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e367de27a57ea6cae58c8aa0ff522b93b5610efd [^] Fixed issue 42679: The partial prepayment button doesn't work in some cases - Taked into account the paid amount to check the remaining prepayment --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js ---

Issue History
Date Modified	Username	Field	Change
2020-01-02 14:11	asiermartirena	New Issue
2020-01-02 14:11	asiermartirena	Assigned To	=> Retail
2020-01-02 14:11	asiermartirena	OBNetwork customer	=> Gold
2020-01-02 14:11	asiermartirena	Resolution time	=> 1579129200
2020-01-02 14:11	asiermartirena	Triggers an Emergency Pack	=> No
2020-01-06 01:24	rqueralta	Assigned To	Retail => rqueralta
2020-01-06 01:25	rqueralta	Status	new => scheduled
2020-01-12 15:55	hgbot	Checkin
2020-01-12 15:55	hgbot	Note Added: 0116777
2020-01-12 15:55	hgbot	Status	scheduled => resolved
2020-01-12 15:55	hgbot	Resolution	open => fixed
2020-01-12 15:55	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e367de27a57ea6cae58c8aa0ff522b93b5610efd [^]
2020-01-17 14:48	marvintm	Review Assigned To	=> marvintm
2020-01-17 14:48	marvintm	Status	resolved => closed
2020-01-17 14:48	marvintm	Fixed in Version	=> RR20Q2