Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0042506
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Remittancemajoralways2019-12-10 14:062019-12-31 13:32
ReporterfranciscoView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisione9c92bab4e11
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date2019-01-11
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/5aff6a4a578c5ce62109e8f0a04f5a17773ba182 [^]
Regression levelProduction - Confirmed Stable
Review Assigned Toaferraz
Regression introduced in release
Summary

0042506: Error when processing a remittance if a G/L journal was previously processed

DescriptionThere is an error when you try to process a remittance that previously was completed the G/L journal.

We get the error:
ERROR: To reactivate the payment, Unpost and unprocess G/L Journal of the G/L Journal Line in which payment is linked.

We believe can be related to the fix:
https://code.openbravo.com/erp/devel/pi/annotate/tip/modules/org.openbravo.advpaymentmngt/src-db/database/model/triggers/APRM_FIN_PMT_CHECK_TRG.xml [^]
related top the bug:
https://issues.openbravo.com/view.php?id=39895 [^]
Steps To ReproduceTested in 19Q3 with Remittance module:
Previous configuration:
Make sure the Financial Account you use, it has Remittance as payment method
Remittance Type has the Posting Allowed flag checked

Go to G/L Journal window
Create a header
Organization: White Valley Spain S.A
General Ledger: The White Valley Group
Create a line
Organization: White Valley Spain S.A
Account: 64000 - Sueldos y salarios
Credit: 105
Open Items flag checked
Financial Account: Bank Account 1 - White Valley Spain - EUR
Payment Method: Remittance
G/LItem: G/L Item Cash Differences

Click the button Complete

Go to Remittance window
Create a header
Financial Account: Bank Account 1 - White Valley Spain - EUR

Click Select Payment button
Choose the payment created form the G/L journal with amount 105

Click on process button
We get:
Error:
ERROR: To reactivate the payment, Unpost and unprocess G/L Journal of the G/L Journal Line in which payment is linked.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
caused by defect 0039895 closedAtulOpenbravo Openbravo ERP Simple G/L Journal line can be removed although it has related payment. Payment can be deleted although the journal is processed 

-  Notes
(0116564)
AtulOpenbravo (developer)
2019-12-30 02:45

Test Plan
- Login as F&B International Group Admin role
- Using Enterprise Module Management, create reference data in F&B US Inc Organization.
- Make sure the Financial Account Bank Account 1 has Remittance as payment method
- Remittance Type has the Posting Allowed flag checked
- Go to G/L Journal window
Create a header
Organization: F&B US Inc
General Ledger: F&B International Group US/A/US Dollar
- Create a line
Organization: F&B US Inc
Account: 6290 - Salaries
Credit: 105
Open Items flag checked
Financial Account: Bank Account 1
Payment Method: Remittance
G/LItem: Salaries
- Create a line
- Debit 105
- Account- 1110 - Checking Account
- Click the button Complete
- Realize that GL Journal is processed successfully with Payment Created message.
- Go to Remittance window
- Create a header with Financial Account: Bank Account 1
- Click Select Payment button
- Choose the payment created form the G/L journal with amount 105
- Click on process button
- Realize that Remittance is processed successfully.
(0116565)
AtulOpenbravo (developer)
2019-12-30 02:56

- Login as International Group admin role
- Create a Simple G/L Journal:
      Organization: F&B US East Coast
      General Ledger: F&B International Group US/A/US Dollar
- Add a line to it:
      Account: 1110 - Checking Account
      Debit: 100
      Open Items: Y
      Select Financial Account, Payment Method, G/L Item and Payment Date
- Add another line to it:
      Account: 1120 - Funds In-Transfer
      Credit: 100
      Open Items: N
- Complete it
- If payment created is registered in financial account transaction then unpost/unprocess/delete it from Financial account Transaction tab, Navigate to the payment created in previous step.
- Check you cannot use any of the action: reactivate / reactivate and delete it for the payment.
- Error message is shown as
  "APRM_ReactivatePaymentInGLJournalLine"
- Navigate to G/L Journal, - Reactivate it
- Check a warning is shown. This is correct
- Try to delete the G/L Journal Line that has previous payment linked to it.
- Error is shown as "If you want to delete G/L Journal Line, you must first reactivate and delete its related payment."
- Navigate to the payment created in previous step
- Check you can use any of the action: reactivate / reactivate and delete it for the payment and delete the payment.
- Now again navigating to G/L Journal Line, try to delete it, line could be deleted now.


Note:Error message with search key APRM_ReactivatePaymentInGLJournalLine is not shown. Expected error message is "To reactivate the payment, Unpost and unprocess G/L Journal of the G/L Journal Line in which payment is linked."
(0116587)
AtulOpenbravo (developer)
2019-12-31 12:46
edited on: 2019-12-31 12:48

Test Plan
- Install Remittance module and apply Remittance module data set in F&B US inc Organization using Enterprise Module Management.
- Create a Payment Method "Simple Check PM" with automatic execution process : Print Check simple process
- Associate Payment Method created in Financial Account : Bank Account 1
- Realize that Financial Account has 4 payment methods: Check, Wire Transfer, Remittance and Simple Check PM
- Similarly apply payment methods for Financial Account: Bank Account 2
- Create a Simple G/L Journal:
      Organization: F&B US Inc
      General Ledger: F&B International Group US/A/US Dollar

- Add a line to it:
      Account: 1110 - Checking Account
      Credit: 100
      Open Items: Y
      Select Financial Account: Bank Account 1, Payment Method: Check, G/L Item : Funds Transfer and Payment Date: Today's Date

- Add a line to it:
      Account: 1110 - Checking Account
      Credit: 100
      Open Items: Y
      Select Financial Account: Bank Account 1, Payment Method: Wire Transfer, G/L Item : Funds Transfer and Payment Date: Today's Date

- Add a line to it:
      Account: 1110 - Checking Account
      Credit: 100
      Open Items: Y
      Select Financial Account: Bank Account 1, Payment Method: Remittance, G/L Item : Funds Transfer and Payment Date: Today's Date

- Add a line to it:
      Account: 1110 - Checking Account
      Credit: 100
      Open Items: Y
      Select Financial Account: Bank Account 1, Payment Method: Simple Check PM, G/L Item : Funds Transfer and Payment Date: Today's Date

- Add another line to it:
      Account: 1120 - Funds In-Transfer
      Debit: 400
      Open Items: N

- Complete it

- Realize that process is completed successfully with message Payment Created 4

- Navigate to Payment Out and realized that 4 payment out are created with
Payment Method: Check, Status: Payment Made
Payment Method: Wire Transfer, Status: Withdrawn Not Cleared
Payment Method: Remittance / Simple Check PM, Status: Awaiting Execution

- Try to reactivate any of the payment with status Payment Made or Awaiting Execution, error message is shown as "APRM_ReactivatePaymentInGLJournalLine"

- To reactivate payment with Status: Withdrawn Not Cleared, delete the reference of the payment from Financial Account Transaction tab and then try to reactivate, same error msg is shown as above.

- Go to Remittance window
- Create a header with Financial Account: Bank Account 2
- Click Select Payment button
- Choose the payment created from the G/L journal with amount 100 each (only payment out with payment method: Remittance & Simple Check PM and status Awaiting Execution appears in the P&E window)
- Click on process button
- Realize that Remittance is processed successfully.

Note:

-Payment's with Bank Account 1 in the header are now changed to Bank Account 2 in the Payment Out Header and Payment Method to Remittance. This is correct as Remittance is processed for this Financial Account and Remittance Payment Method.
- Similar test plan tested successfully for Payment In flow

(0116589)
hgbot (developer)
2019-12-31 13:21

Repository: erp/mods/org.openbravo.module.remittance
Changeset: 81ffe149ae92cab1a35f7c6380c38403975a1ea7
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Dec 31 16:10:25 2019 +0530
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/81ffe149ae92cab1a35f7c6380c38403975a1ea7 [^]

Related to BUG-42506: Apply java formatting

---
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0116590)
hgbot (developer)
2019-12-31 13:21

Repository: erp/mods/org.openbravo.module.remittance
Changeset: e9c92bab4e1165839abfb333db5823d28d82e249
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Dec 31 17:23:53 2019 +0530
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/e9c92bab4e1165839abfb333db5823d28d82e249 [^]

Fixes BUG-42506: Error when processing a remittance if a G/L journal
was previously processed

** Setting FIN_Payment processed flag = No before updating
payment method and financial account triggers APRM_FIN_PMT_CHECK_TRG
check condition when processing remittance.
Setting processed flag = No is not needed in case of payment
with Remittance Payment Method as they have status RPAE and
payments with this status are allowed to change Financial Account
and Payment method in the same trigger.
** Method associatePaymentWithRemittancePaymentMethod added as
setting payment method and Financial account is done at two places
in the Remittance process.

---
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0116591)
hgbot (developer)
2019-12-31 13:27

Repository: erp/mods/org.openbravo.module.remittance
Changeset: 0aa23ecd49b1cd557c61741844cf1212458af67f
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Dec 31 13:25:35 2019 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/0aa23ecd49b1cd557c61741844cf1212458af67f [^]

Related to BUG 42506: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0116592)
aferraz (manager)
2019-12-31 13:32

Code review OK

- Issue History
Date Modified Username Field Change
2019-12-10 14:06 francisco New Issue
2019-12-10 14:06 francisco Assigned To => Triage Finance
2019-12-10 14:30 Practics Issue Monitored: Practics
2019-12-13 08:31 ngarcia Type backport => defect
2019-12-13 08:31 ngarcia Resolution time => 1577746800
2019-12-13 09:35 dmiguelez Assigned To Triage Finance => AtulOpenbravo
2019-12-30 02:45 AtulOpenbravo Status new => scheduled
2019-12-30 02:45 AtulOpenbravo Note Added: 0116564
2019-12-30 02:56 AtulOpenbravo Note Added: 0116565
2019-12-30 17:20 AtulOpenbravo Regression date => 2019-01-11
2019-12-30 17:20 AtulOpenbravo Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/5aff6a4a578c5ce62109e8f0a04f5a17773ba182 [^]
2019-12-30 17:20 AtulOpenbravo Regression level => Production - QA Approved
2019-12-30 17:20 AtulOpenbravo Review Assigned To => aferraz
2019-12-30 17:33 AtulOpenbravo Relationship added caused by 0038895
2019-12-30 17:33 AtulOpenbravo Relationship deleted caused by 0038895
2019-12-30 17:34 AtulOpenbravo Relationship added depends on 0039895
2019-12-30 17:34 AtulOpenbravo Relationship replaced caused by 0039895
2019-12-30 18:11 AtulOpenbravo Status scheduled => acknowledged
2019-12-30 18:23 AtulOpenbravo Relationship added depends on 0042660
2019-12-30 18:27 AtulOpenbravo Relationship added depends on 0042661
2019-12-30 18:27 AtulOpenbravo Status acknowledged => scheduled
2019-12-31 08:22 AtulOpenbravo Regression level Production - QA Approved => Production - Confirmed Stable
2019-12-31 09:26 aferraz Status scheduled => acknowledged
2019-12-31 09:26 aferraz Status acknowledged => scheduled
2019-12-31 09:27 aferraz Project Modules => Openbravo ERP
2019-12-31 09:28 aferraz Modules => Core
2019-12-31 09:28 aferraz Triggers an Emergency Pack => No
2019-12-31 09:28 aferraz Category Remittance => 09. Financial management
2019-12-31 09:28 aferraz Target Version => 3.0PR20Q2
2019-12-31 09:28 aferraz Status scheduled => acknowledged
2019-12-31 09:29 aferraz Status acknowledged => scheduled
2019-12-31 11:45 aferraz Project Openbravo ERP => Modules
2019-12-31 11:46 aferraz Category 09. Financial management => Remittance
2019-12-31 11:46 aferraz Target Version 3.0PR20Q2 =>
2019-12-31 12:46 AtulOpenbravo Note Added: 0116587
2019-12-31 12:47 AtulOpenbravo Note Edited: 0116587 View Revisions
2019-12-31 12:48 AtulOpenbravo Note Edited: 0116587 View Revisions
2019-12-31 13:21 hgbot Checkin
2019-12-31 13:21 hgbot Note Added: 0116589
2019-12-31 13:21 hgbot Checkin
2019-12-31 13:21 hgbot Note Added: 0116590
2019-12-31 13:21 hgbot Status scheduled => resolved
2019-12-31 13:21 hgbot Resolution open => fixed
2019-12-31 13:21 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/e9c92bab4e1165839abfb333db5823d28d82e249 [^]
2019-12-31 13:27 hgbot Checkin
2019-12-31 13:27 hgbot Note Added: 0116591
2019-12-31 13:32 aferraz Note Added: 0116592
2019-12-31 13:32 aferraz Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker