0042234: StockCriteria module queries are very inefficient when not using OBPOS_remote.product at the same time

Description

Contect:
Customer does not use the remote data for product preference but has the StockCriteria module installed.

StockCriteria module is doing remote queries to product (to get uptodate stock information) but inside the code assuming remoteData=false leading to wrong and very inefficient queries.

Technically org.openbravo.retail.posterminal.master.ProductProperties file:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/master/ProductProperties.java#l110 [^]

and

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/master/ProductProperties.java#l131 [^]

Enter branch with isRemote false leading to query being built searching remotely using m_product_trl table and having upper(upper(upc)) in their where clauses.

Steps To Reproduce

Check query being executed for above Module and notice it filtering (with user search string) in

upper(upper(upc))

and
value of m_product_trl.name

Proposed Solution

Fix logic so that remote queries if they happen (i.e. stockcriteria) are correctly treated as 'remote queries' independent of the base configuration of that query (i.e. OBPOS_remote.product preference).

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0115613) hgbot (developer) 2019-11-14 22:09	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: c93c6d284752bb13654889f5d605e5906905f670 Author: Alejandro <alekosmp86 <at> gmail.com> Date: Wed Nov 13 11:34:33 2019 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c93c6d284752bb13654889f5d605e5906905f670 [^] Fixed issue 42234: When filtering by StockCriteria, always execute remote query. --- M src/org/openbravo/retail/posterminal/master/Product.java M src/org/openbravo/retail/posterminal/master/ProductProperties.java ---

Issue History
Date Modified	Username	Field	Change
2019-11-08 12:11	shuehner	New Issue
2019-11-08 12:11	shuehner	Assigned To	=> Retail
2019-11-08 12:11	shuehner	OBNetwork customer	=> Gold
2019-11-08 12:11	shuehner	Triggers an Emergency Pack	=> No
2019-11-08 12:12	shuehner	Resolution time	=> 1574982000
2019-11-08 15:31	shuehner	Resolution time	1574982000 => 1573772400
2019-11-13 21:53	alekosmp86	Assigned To	Retail => alekosmp86
2019-11-14 22:09	hgbot	Checkin
2019-11-14 22:09	hgbot	Note Added: 0115613
2019-11-14 22:09	hgbot	Status	new => resolved
2019-11-14 22:09	hgbot	Resolution	open => fixed
2019-11-14 22:09	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c93c6d284752bb13654889f5d605e5906905f670 [^]
2019-11-15 08:55	marvintm	Review Assigned To	=> marvintm
2019-11-15 08:55	marvintm	Status	resolved => closed
2019-11-15 08:55	marvintm	Fixed in Version	=> RR20Q1