Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0042079

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2019-10-22 09:34

2019-10-31 13:38

Reporter

guillermogil

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

normal

Resolution

fixed

Fixed in Version

RR20Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0042079: If there is a line with EPCCode and RFID is not enabled an error is raised

Description

If there is a line with EPCCode and RFID is not enabled an error is raised.
It should check if RFID is enabled to do everything related with RFID

Steps To Reproduce

Add following hook

OB.UTIL.HookManager.registerHook('OBPOS_BarcodeScan', function(
    args,
    callbacks
) {

        args.attrs = args.attrs || {};
        args.attrs.obposEpccode = "test";

    OB.UTIL.HookManager.callbackExecutor(args, callbacks);
});

An error raises on execution if a product is not found

Proposed Solution

See diff attached

Tags

No tags attached.

42079.diff [^] (1,606 bytes) 2019-10-22 09:34 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/model/order.js b/web/org.openbravo.retail.posterminal/js/model/order.js
--- a/web/org.openbravo.retail.posterminal/js/model/order.js
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js
@@ -3647,7 +3647,7 @@
                     OB.error(
                       'After execute OBPOS_GroupedProductPreCreateLine hook, system has detected that line is being added when calculate receipt is closed. Ignore line creation'
                     );
-                    if (args && args.attrs && args.attrs.obposEpccode) {
+                    if (OB.UTIL.RfidController.isRfidConfigured() && args && args.attrs && args.attrs.obposEpccode) {
                       OB.UTIL.RfidController.removeEpc(args.attrs.obposEpccode);
                     }
                     return null;
diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
@@ -709,7 +709,7 @@
           args.callback(args.dataProducts.at(0), args.attrs);
         } else {
           // If rfid has been used remove code from buffer
-          if (args.attrs && args.attrs.obposEpccode) {
+          if (OB.UTIL.RfidController.isRfidConfigured() && args.attrs && args.attrs.obposEpccode) {
             OB.UTIL.RfidController.removeEpc(args.attrs.obposEpccode);
           }
           OB.UTIL.HookManager.executeHooks(

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0115316) hgbot (developer) 2019-10-29 07:13	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 0f067c9e41caa9cadc2ad6a31b3b073cc9b12487 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Oct 29 11:42:56 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0f067c9e41caa9cadc2ad6a31b3b073cc9b12487 [^] Fixed issue 42079 : RFID Config is validated when removing removeEpc from buffer --- M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js ---

Issue History
Date Modified	Username	Field	Change
2019-10-22 09:34	guillermogil	New Issue
2019-10-22 09:34	guillermogil	Assigned To	=> Retail
2019-10-22 09:34	guillermogil	OBNetwork customer	=> Gold
2019-10-22 09:34	guillermogil	Resolution time	=> 1572822000
2019-10-22 09:34	guillermogil	Triggers an Emergency Pack	=> No
2019-10-22 09:34	guillermogil	File Added: 42079.diff
2019-10-22 09:50	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2019-10-24 08:10	ranjith_qualiantech_com	Status	new => scheduled
2019-10-29 07:13	hgbot	Checkin
2019-10-29 07:13	hgbot	Note Added: 0115316
2019-10-29 07:13	hgbot	Status	scheduled => resolved
2019-10-29 07:13	hgbot	Resolution	open => fixed
2019-10-29 07:13	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0f067c9e41caa9cadc2ad6a31b3b073cc9b12487 [^]
2019-10-31 13:38	marvintm	Review Assigned To	=> marvintm
2019-10-31 13:38	marvintm	Status	resolved => closed
2019-10-31 13:38	marvintm	Fixed in Version	=> RR20Q1

Copyright © 2000 - 2009 MantisBT Group