0041877: ServiceWorkers fetch should filter by cacheName

Description

Currently the fetch for sources in the ServiceWorker functionality is not filtering by cache name. This means that if two caches exist, the fetch will not guarantee that the right resource will be loaded.

Steps To Reproduce

Tags

No tags attached.

Attached Files

issue41877.diff [^] (598 bytes) 2019-09-24 14:11 [Show Content] [Hide Content]

diff -r f92fc1605a8a web/org.openbravo.mobile.core/source/offline/ob-sources-sw.js
--- a/web/org.openbravo.mobile.core/source/offline/ob-sources-sw.js	Mon Sep 23 19:43:52 2019 +0530
+++ b/web/org.openbravo.mobile.core/source/offline/ob-sources-sw.js	Tue Sep 24 14:10:36 2019 +0200
@@ -182,7 +182,7 @@
 //              with a fail response.
 self.addEventListener('fetch', function(e) {
   e.respondWith(
-    caches.match(e.request).then(function(response) {
+    caches.match(e.request, { cacheName: cacheName }).then(function(response) {
       if (response) {
         return response;
       }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0114776) hgbot (developer) 2019-09-25 10:20	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 037d119de78f40005a18af9763206673b844beb9 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Sep 24 14:14:00 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/037d119de78f40005a18af9763206673b844beb9 [^] Fixed issue 41877. Match function should filter by cacheName, to ensure that the right cache is used when fetching resources. --- M web/org.openbravo.mobile.core/source/offline/ob-sources-sw.js ---

(0114808) jorge-garcia (reporter) 2019-09-26 14:54	Code reviewed and tested

Issue History
Date Modified	Username	Field	Change
2019-09-24 14:07	marvintm	New Issue
2019-09-24 14:07	marvintm	Assigned To	=> Retail
2019-09-24 14:07	marvintm	Triggers an Emergency Pack	=> No
2019-09-24 14:11	marvintm	File Added: issue41877.diff
2019-09-25 10:20	hgbot	Checkin
2019-09-25 10:20	hgbot	Note Added: 0114776
2019-09-25 10:20	hgbot	Status	new => resolved
2019-09-25 10:20	hgbot	Resolution	open => fixed
2019-09-25 10:20	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/037d119de78f40005a18af9763206673b844beb9 [^]
2019-09-25 10:20	marvintm	Assigned To	Retail => marvintm
2019-09-26 14:54	jorge-garcia	Review Assigned To	=> jorge-garcia
2019-09-26 14:54	jorge-garcia	Note Added: 0114808
2019-09-26 14:54	jorge-garcia	Status	resolved => closed
2019-09-26 14:54	jorge-garcia	Fixed in Version	=> RR19Q4