0041833: Reprocessed OpenSessionPOS errors generate import entries with a wrong type.

Description

When an OpenSessionPOS process ends up in the errors while importing POS data window, its data type is stored as Open Till(POSS_Terminal_Sessions) which is the entity qualifier of the process.
The associated import entry is created with its data type = Open Session POS (POSS_OpenSessionPOS) which is the import qualifier of the process.

When the error is reprocessed, a new import entry is generated to process the data. This new import entry is generated with a data type = POSS Terminal Sessions(POSS_Terminal_Sessions) which is the entity qualifier of the process, and not the import qualifier.

When the import entry archiver process tries to move the second import entry to the archive, it fails because Weld is unable to find a process with an import qualifier equal to the type of data of the import entry.

Steps To Reproduce

Force an error in the processing of an Open Till (i.e. set a breakpoint in the java code before calling the process and break the json objToSend.bdSessions[0].code = undefined).
Verify that a new record has been created in the Errors While Importing POS Data window with type = Open Till. Verify also that there is an import entry with data type = Open Session POS.
Fix the json by adding the code again.
Reprocess the error.
Once the error is processed, verify that a new import entry has been created, with data type = POSS Terminal Sessions

Proposed Solution

When an import entry is created while reprocessing an Error while Importing, the import entry created should have its typeofdata correctly set based on the import qualifier of the process, and not based on the typeofdata of the error itself.
This issue has been reproduced with the Open Sessions POS model, but there are other import processes which have different entity and import qualifiers.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0114792) hgbot (developer) 2019-09-26 08:08	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d38c4f8bae677cce6019ec2604085ad432c336a1 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu Sep 26 11:37:59 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d38c4f8bae677cce6019ec2604085ad432c336a1 [^] Fixed issue 41833 : ImportEntry should be created with ImportQualifier in SaveAction Handler * ImportEntry jsoninfo should be created same as like data requested from POS --- M src/org/openbravo/retail/posterminal/POSDataSynchronizationProcess.java M src/org/openbravo/retail/posterminal/SaveDataActionHandler.java ---

(0114815) jorge-garcia (reporter) 2019-09-26 17:14	Code reviewed and tested

Issue History
Date Modified	Username	Field	Change
2019-09-18 12:17	aaroncalero	New Issue
2019-09-18 12:17	aaroncalero	Assigned To	=> Retail
2019-09-18 12:17	aaroncalero	Triggers an Emergency Pack	=> No
2019-09-18 12:17	aaroncalero	Resolution time	=> 1569967200
2019-09-19 12:43	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2019-09-20 07:51	ranjith_qualiantech_com	Status	new => scheduled
2019-09-26 08:08	hgbot	Checkin
2019-09-26 08:08	hgbot	Note Added: 0114792
2019-09-26 08:08	hgbot	Status	scheduled => resolved
2019-09-26 08:08	hgbot	Resolution	open => fixed
2019-09-26 08:08	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d38c4f8bae677cce6019ec2604085ad432c336a1 [^]
2019-09-26 17:05	jorge-garcia	Review Assigned To	=> jorge-garcia
2019-09-26 17:14	jorge-garcia	Note Added: 0114815
2019-09-26 17:14	jorge-garcia	Status	resolved => closed
2019-09-26 17:14	jorge-garcia	Fixed in Version	=> RR19Q4