0041771: Duplicated Product Category in Master data loading with cross store

Description

When a product category is included in more than one assortment from brother organizations (but not in the one you try to log in), product category data load fails.
Console log:
OB.Dal.insertData: model insert 'ProductCategory'; SQLError: code: 6, message: could not execute statement due to a constraint failure (19 UNIQUE constraint failed: m_product_category.m_product_category_id);

This is due to the cross store condition in Category.java:

    if (isCrossStore) {
      query.append(" and not exists (");
      query.append(" select 1");
      query.append(" from OBRETCO_Productcategory aCat2");
      query.append(" where aCat2.productCategory.id = pCat.id");
      query.append(" and aCat2.obretcoProductlist.id = :productListId");
      query.append(" )");
    }

This loads categories not present in current organization's assortment, but it doesn't check if those categories are duplicated in the rest of the brother cross store organizations' assortments

Steps To Reproduce

1. Log into live builds pi retail backend
2. Go to Organization window and change Vall Blanca Store "Cross store organization" to White Valley Spain S.A, so now there are 3 stores with this configuration
3. Change also Vall Blanca Store assortment to 'VBS POS Terminal Type Product List', so all 3 of the stores have different assortments
4. Check that Vall Blanca store new assigned assortment has only "Backpacks & Travel' and 'Ski' in subtab 'Filter Product Categories', but the other two (Posets Products List and White Valley Group Product list) have categories not included there (for instance, Lighting & Electronics).
5. Log into VBS-1 with full refresh and reproduce the problem.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0041734

closed

aferraz

Duplicated Product Category in Master data loading with cross store

Notes
(0114432) hgbot (developer) 2019-09-06 09:39	Repository: retail/backports/3.0RR19Q3.1/org.openbravo.retail.posterminal Changeset: aeafcbb7f740ca44d35af770ffa30f979b6a969f Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Wed Sep 04 09:40:41 2019 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR19Q3.1/org.openbravo.retail.posterminal/rev/aeafcbb7f740ca44d35af770ffa30f979b6a969f [^] Fixes issue 41771: Avoid duplicated records in Category.getRegularProductCategoryHqlString() query --- M src/org/openbravo/retail/posterminal/master/Category.java ---

Issue History
Date Modified	Username	Field	Change
2019-09-06 08:08	marvintm	Type	defect => backport
2019-09-06 08:08	marvintm	Target Version	=> RR19Q3.2
2019-09-06 09:39	hgbot	Checkin
2019-09-06 09:39	hgbot	Note Added: 0114432
2019-09-06 09:39	hgbot	Status	scheduled => resolved
2019-09-06 09:39	hgbot	Resolution	open => fixed
2019-09-06 09:39	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/94da0c7209b0608cc97e76349e3f52b3d67cb11b [^] => http://code.openbravo.com/retail/backports/3.0RR19Q3.1/org.openbravo.retail.posterminal/rev/aeafcbb7f740ca44d35af770ffa30f979b6a969f [^]
2019-09-06 09:42	marvintm	Status	resolved => closed
2019-09-06 09:42	marvintm	Fixed in Version	=> RR19Q3.1