Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041684
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformcriticalhave not tried2019-08-23 13:162019-11-12 16:13
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q4
StatusclosedFix in branchFixed in SCM revisionf8c27555c37c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041684: Extra widget instances are created if permission to widget class is removed

DescriptionIf access is removed from a widget, when there are already existing widget instances for that widget, each time widgets are refreshed new widget instances will be created
Steps To ReproduceCount the number of widget instances in you development environment:
  select count(*) from obkmo_widget_instance

As System Admin:
- Open the Widget window, select the Welcome to Openbravo 3 widget
- Uncheck its Enable for All Users flag, set its module in development if needed

As F&B Admin:
- Open the Role window, select the F&B International Group Admin
- In the Widget Class Access subtab, remove the entry for the Welcome to Openbravo 3 widget

Restart the server (list of available widget classes is cached)

Log in with the F&B Admin role

Check that each time the Refresh button in the Manage Workspace is clicked, the number of widget instances increases.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00422603.0PR19Q3.3 closedAugustoMauch Extra widget instances are created if permission to widget class is removed 

-  Notes
(0114249)
hgbot (developer)
2019-08-23 14:20

 Repository: erp/devel/pi
Changeset: e257d8e482d8931c581b379ff95c56ca050b8c9b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Aug 23 14:18:44 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e257d8e482d8931c581b379ff95c56ca050b8c9b [^]

Fixes issue 41684: Extra widget instances are no longer created

The process that automatically creates widget instances for default widgets was not taking into
account if the user had access to the copied widget class.

---
M modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoComponent.java
---
(0114261)
hudsonbot (developer)
2019-08-25 06:50

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2915449dde15 [^]
Maturity status: Test
(0114334)
caristu (developer)
2019-08-29 14:57

 Reopened due to minor code clean-up improvement:

This if clause[1] does not longer apply, because the fix for the issue is already checking the same.

[1] https://code.openbravo.com/erp/devel/pi/file/e257d8e482d8/modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoComponent.java#l319 [^]
(0114354)
hgbot (developer)
2019-09-02 11:05

 Repository: erp/devel/pi
Changeset: f8c27555c37ca9951d4a7227b20d5daed06ddfc7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Sep 02 11:04:38 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f8c27555c37ca9951d4a7227b20d5daed06ddfc7 [^]

Related with issue 41684: Removes unneeded if clause

An if clause has been removed, it was not needed because an equivalent conditions is already
being checked.

Removed if clause:

 if (accessibleWidgetClasses.contains(copy.getWidgetClass().getId())) {

Break statement:

      if (!accessibleWidgetClasses.contains(defaultWidget.getWidgetClass().getId())) {
        // do not copy a widget if its widget class is not accessible
        continue;
      }

---
M modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoComponent.java
---
(0114365)
hudsonbot (developer)
2019-09-02 16:01

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc549ccd3ceb [^]
Maturity status: Test
(0114366)
caristu (developer)
2019-09-02 19:02

 Reviewed

- Issue History
Date Modified Username Field Change
2019-08-23 13:16 AugustoMauch New Issue
2019-08-23 13:16 AugustoMauch Assigned To => AugustoMauch
2019-08-23 13:16 AugustoMauch Modules => Core
2019-08-23 13:16 AugustoMauch Triggers an Emergency Pack => No
2019-08-23 13:40 AugustoMauch Steps to Reproduce Updated View Revisions
2019-08-23 13:40 AugustoMauch Description Updated View Revisions
2019-08-23 14:20 hgbot Checkin
2019-08-23 14:20 hgbot Note Added: 0114249
2019-08-23 14:20 hgbot Status new => resolved
2019-08-23 14:20 hgbot Resolution open => fixed
2019-08-23 14:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e257d8e482d8931c581b379ff95c56ca050b8c9b [^]
2019-08-23 14:21 AugustoMauch Review Assigned To => caristu
2019-08-25 06:50 hudsonbot Checkin
2019-08-25 06:50 hudsonbot Note Added: 0114261
2019-08-29 14:57 caristu Note Added: 0114334
2019-08-29 14:57 caristu Status resolved => new
2019-08-29 14:57 caristu Resolution fixed => open
2019-09-02 11:05 hgbot Checkin
2019-09-02 11:05 hgbot Note Added: 0114354
2019-09-02 11:13 AugustoMauch Status new => scheduled
2019-09-02 11:13 AugustoMauch Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/e257d8e482d8931c581b379ff95c56ca050b8c9b [^] => https://code.openbravo.com/erp/devel/pi/rev/f8c27555c37ca9951d4a7227b20d5daed06ddfc7 [^]
2019-09-02 11:13 AugustoMauch Status scheduled => resolved
2019-09-02 11:13 AugustoMauch Resolution open => fixed
2019-09-02 16:01 hudsonbot Checkin
2019-09-02 16:02 hudsonbot Note Added: 0114365
2019-09-02 19:02 caristu Note Added: 0114366
2019-09-02 19:02 caristu Status resolved => closed
2019-09-02 19:02 caristu Fixed in Version => 3.0PR19Q4
2019-11-12 16:12 alostale Status closed => new
2019-11-12 16:12 alostale Resolution fixed => open
2019-11-12 16:12 alostale Fixed in Version 3.0PR19Q4 =>
2019-11-12 16:12 alostale Severity minor => critical
2019-11-12 16:12 alostale Status new => scheduled
2019-11-12 16:13 alostale Status scheduled => resolved
2019-11-12 16:13 alostale Fixed in Version => 3.0PR19Q4
2019-11-12 16:13 alostale Resolution open => fixed
2019-11-12 16:13 alostale Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker