Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0041451

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2019-07-24 18:02

2023-10-06 09:21

Reporter

aaroncalero

View Status

public

Assigned To

rqueralta

Priority

normal

Resolution

fixed

Fixed in Version

RR19Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0041451: Preference Web POS action Print invoices automatically is not taken into account in Pay Open Tickets

Description

The preference Web POS action Print invoices automatically is not taken into account in Pay Open Tickets. When a ticket generates an invoice during pay open tickets, the invoice is always printed regardless of the preference value.

Steps To Reproduce

Log in backend, navigate to the Vall Blanca Store organization and configure the invoice template.
Go to the preference window and verify that Web POS action Print invoices automatically is not configured or configured with a value of N

Log in Web POS
Create a new ticket and add a product.
Go to the menu > Invoice this receipt.
Go to the menu > Pay Open Tickets.
Select the current ticket and pay it.
Verify that 2 documents are printed: the ticket, and the invoice for the receipt.

Proposed Solution

Attached a patch (prepared on a 19Q1 instance) with a possible solution

Tags

No tags attached.

Issue41451.diff [^] (994 bytes) 2019-07-24 18:26 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js
--- a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js
@@ -529,9 +529,11 @@
                     _.each(invoice.get('lines').models, function (invoiceLine) {
                       invoiceLine.unset('product');
                     });
-                    me.context.get('multiOrders').trigger('print', invoiceToPrint, {
-                      offline: true
-                    });
+                    if (OB.MobileApp.model.hasPermission('OBPOS_print.invoicesautomatically', true)) {
+                      me.context.get('multiOrders').trigger('print', invoiceToPrint, {
+                        offline: true
+                      });
+                    }
                   }
 
                   me.context.get('multiOrders').trigger('integrityOk', theReceipt);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0113801) hgbot (developer) 2019-08-04 05:14	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: b437b91039b02070dbfad2c4d7cd82a82a5a5954 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Thu Aug 01 16:46:47 2019 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b437b91039b02070dbfad2c4d7cd82a82a5a5954 [^] Fixed issue 41451: Preference Web POS action Print invoices automatically is not taken into account in Pay Open Tickets - Checked Preference Web POS action Print before print invoice ticket --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js ---

Issue History
Date Modified	Username	Field	Change
2019-07-24 18:02	aaroncalero	New Issue
2019-07-24 18:02	aaroncalero	Assigned To	=> Retail
2019-07-24 18:02	aaroncalero	Resolution time	=> 1565128800
2019-07-24 18:02	aaroncalero	Triggers an Emergency Pack	=> No
2019-07-24 18:26	aaroncalero	File Added: Issue41451.diff
2019-07-24 18:26	aaroncalero	Proposed Solution updated
2019-08-01 21:07	rqueralta	Assigned To	Retail => rqueralta
2019-08-01 21:08	rqueralta	Status	new => scheduled
2019-08-04 05:14	hgbot	Checkin
2019-08-04 05:14	hgbot	Note Added: 0113801
2019-08-04 05:14	hgbot	Status	scheduled => resolved
2019-08-04 05:14	hgbot	Resolution	open => fixed
2019-08-04 05:14	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b437b91039b02070dbfad2c4d7cd82a82a5a5954 [^]
2019-08-07 08:11	marvintm	Review Assigned To	=> marvintm
2019-08-07 08:11	marvintm	Status	resolved => closed
2019-08-07 08:11	marvintm	Fixed in Version	=> RR19Q4
2023-10-06 09:21	jigsawsow	Note Added: 0155604
2023-10-06 09:57	aaroncalero	Note Deleted: 0155604

Copyright © 2000 - 2009 MantisBT Group