Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041366
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Y. DBSourceManagermajorhave not tried2019-07-16 13:292019-08-22 14:45
ReporteradrianromeroView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q4
StatusclosedFix in branchFixed in SCM revision58004f8efa54
ProjectionnoneETAnoneTarget Version
OSAnyDatabasePostgreSQLJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041366: Check constraints values when exported values are transformed to upper case

DescriptionWhen exporting check constraints with values that contains lower case values. These values are transformed to upper case. These is wrong, values must not be modified.
Steps To ReproduceCreate the following check constraint in PostgreSQL:

ALTER TABLE public.obpos_paymentgroup
  ADD CONSTRAINT em_ady_configuration_chk CHECK (provider::text <> 'ADY_AdyenProvider'::text OR em_ady_apikey IS NOT NULL AND em_ady_network IS NOT NULL);

Export using the build command ant export.database
Observe the SQL exported is

PROVIDER <> 'ADY_ADYENPROVIDER' OR EM_ADY_APIKEY IS NOT NULL AND EM_ADY_NETWORK IS NOT NULL

TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0041367 closedadrianromero Retail Modules Sumup payment provider name must be upper case 

-  Notes
(0113735)
hgbot (developer)
2019-07-31 13:20

 Repository: erp/devel/pi
Changeset: 58004f8efa540f17758f4148ea71120eb5e62573
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 31 13:20:31 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/58004f8efa540f17758f4148ea71120eb5e62573 [^]

fixed bug 41460 fixed bug 41366: allow multi col checks, don't upper case check

fixed issue 41460: multi colum FKs are not supported in PG

  The query to obtain columns participating in FKs was incorrect in PG as it
  assumed FKs have a single column.

  As PG catalog stores FK column information as a couple of arrays (one for local
  and another one for external column) each of them corresponding each other by
  array's position, it is not possible to retrieve all information using a single
  query. This has been changed so now column information is retrieved by an additional
  query based on array's position.


fixed issue 41366: string literals in check contrains are upper cased

  When exporting check constraints in PostgreSQL, they are converted to upper case
  in order to keep ORA - PG stability. This conversion was to aggressive as string
  literals were also modified.

  Now strings are kept while the rest is still transformed.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0113738)
hgbot (developer)
2019-07-31 13:21

 Repository: erp/devel/dbsm-main
Changeset: ea1fbde18d1a250ad6919c46edf189ea89625827
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 30 15:46:31 2019 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/ea1fbde18d1a250ad6919c46edf189ea89625827 [^]

related to issue 41366: added test case

---
M src-test/src/org/openbravo/dbsm/test/model/ModelSuite.java
A src-test/model/constraints/CHK_LOWER_CASE.xml
A src-test/src/org/openbravo/dbsm/test/model/CheckConstraintLowerCase.java
---
(0113739)
hgbot (developer)
2019-07-31 13:21

 Repository: erp/devel/dbsm-main
Changeset: 3517bb63edf9d6b4cbecf841c7c889d6225ee1ad
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 30 15:52:12 2019 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/3517bb63edf9d6b4cbecf841c7c889d6225ee1ad [^]

fixed issue 41366: string literals in check contrains are upper cased

  When exporting check constraints in PostgreSQL, they are converted to upper case
  in order to keep ORA - PG stability. This conversion was to aggressive as string
  literals were also modified.

  Now strings are kept while the rest is still transformed.

---
M src/org/apache/ddlutils/model/Check.java
M src/org/apache/ddlutils/platform/postgresql/PostgreSqlCheckTranslation.java
---
(0113772)
hgbot (developer)
2019-08-02 08:59

 Repository: erp/devel/dbsm-main
Changeset: fa6eab212c328619e565e2b155585df14693ef64
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Aug 02 08:59:11 2019 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/fa6eab212c328619e565e2b155585df14693ef64 [^]

related to issue 41366: update copyright year

---
M src/org/apache/ddlutils/platform/postgresql/PostgreSqlCheckTranslation.java
---
(0113773)
caristu (viewer)
2019-08-02 08:59

 Reviewed + tested OK
(0114189)
hudsonbot (viewer)
2019-08-22 14:45

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114191)
hudsonbot (viewer)
2019-08-22 14:45

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2019-07-16 13:29 adrianromero New Issue
2019-07-16 13:29 adrianromero Assigned To => platform
2019-07-16 13:29 adrianromero OBNetwork customer => No
2019-07-16 13:29 adrianromero Modules => Core
2019-07-16 13:29 adrianromero Triggers an Emergency Pack => No
2019-07-16 13:48 adrianromero Relationship added related to 0041367
2019-07-30 15:49 alostale Assigned To platform => alostale
2019-07-31 13:20 hgbot Checkin
2019-07-31 13:20 hgbot Note Added: 0113735
2019-07-31 13:20 hgbot Status new => resolved
2019-07-31 13:20 hgbot Resolution open => fixed
2019-07-31 13:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/58004f8efa540f17758f4148ea71120eb5e62573 [^]
2019-07-31 13:21 hgbot Checkin
2019-07-31 13:21 hgbot Note Added: 0113738
2019-07-31 13:21 hgbot Checkin
2019-07-31 13:21 hgbot Note Added: 0113739
2019-07-31 13:21 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/58004f8efa540f17758f4148ea71120eb5e62573 [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/3517bb63edf9d6b4cbecf841c7c889d6225ee1ad [^]
2019-07-31 13:21 alostale Review Assigned To => caristu
2019-07-31 13:21 alostale Fixed in SCM revision http://code.openbravo.com/erp/devel/dbsm-main/rev/3517bb63edf9d6b4cbecf841c7c889d6225ee1ad [^] => http://code.openbravo.com/erp/devel/pi/rev/58004f8efa540f17758f4148ea71120eb5e62573 [^]
2019-08-02 08:59 hgbot Checkin
2019-08-02 08:59 hgbot Note Added: 0113772
2019-08-02 08:59 caristu Note Added: 0113773
2019-08-02 08:59 caristu Status resolved => closed
2019-08-02 08:59 caristu Fixed in Version => 3.0PR19Q4
2019-08-22 14:45 hudsonbot Checkin
2019-08-22 14:45 hudsonbot Note Added: 0114189
2019-08-22 14:45 hudsonbot Checkin
2019-08-22 14:45 hudsonbot Note Added: 0114191

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker