Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0041348
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSmajoralways2019-07-15 07:242019-12-07 08:15
ReporterguillermogilView Statuspublic 
Assigned ToRetail 
PriorityurgentResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revision6b1fe93a1bbc
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041348: PostmportEntryProcessorHook is not executed in Sync Mode

DescriptionPostmportEntryProcessorHook is not executed in Sync Mode

If you are using Sync Mode Import Entry hooks are not called.
It happened the same with Save Again button .
Steps To Reproduce- Create Sync Mode preference with value Y
- Create a Dummy PostmportEntryProcessorHook just to put a breakpoint on it
- Login on WebPOS
- Complete a ticket

You will see that it does not stop on the hook
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0113954)
hgbot (developer)
2019-08-13 04:24

Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: a7431e3d814dadd3e796bd0fa23279f683aa48df
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Aug 13 07:54:11 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/a7431e3d814dadd3e796bd0fa23279f683aa48df [^]

Related to issue 41348 : Added getImportEntryDataType method to CloseStore class

* WebPOSCloseStore class must override the getImportEntryDataType method, because
  ImportEntry has been created when closing WebPOS

---
M src/org/openbravo/retail/sessions/WebPOSCloseStore.java
---
(0113956)
hgbot (developer)
2019-08-13 08:20

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: cc07e8529eae9f154a7bb06de90f48e0bfaf5758
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Aug 13 11:50:27 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/cc07e8529eae9f154a7bb06de90f48e0bfaf5758 [^]

Fixed issue 41348 : Added ImportEntryPostProcessor hook in Synchronize Mode

---
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0114003)
hgbot (developer)
2019-08-14 09:07

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0f05c1fefd79d464e32aeba67c0683f53f0fe675
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Aug 14 12:36:46 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0f05c1fefd79d464e32aeba67c0683f53f0fe675 [^]

Related to issue 41348 : Added ImportEntryProcessorSelector for ImportEntryPostProcessor Hook

* In Sync Mode, ImportEntryPostProcessor implementation hook should be called based on entity qualifier

---
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0114020)
hgbot (developer)
2019-08-14 15:36

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 58cce5b7c6f6ef87c6ed42e2a49c27c100ac5852
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Aug 14 19:06:17 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/58cce5b7c6f6ef87c6ed42e2a49c27c100ac5852 [^]

Related to issue 41348 : Backed out changeset: 0f05c1fefd79

---
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0114021)
ranjith_qualiantech_com (developer)
2019-08-14 15:37

Tests were failing in suite
(0114098)
hgbot (developer)
2019-08-20 11:45

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2a5860a7698ef1128de8b4f6c5967c7e190e85f7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Aug 20 15:15:26 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2a5860a7698ef1128de8b4f6c5967c7e190e85f7 [^]

Fixed issue 41348 : Added ImportEntryProcessorSelector for ImportEntryPostProcessor Hook

* In Sync Mode, ImportEntryPostProcessor implementation hook should be called based on entity qualifier
  If ImportEntry typeOfData is null, then all implementations of ImportEntryPostProcessor will be called

---
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0114368)
hgbot (developer)
2019-09-03 07:36

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 8734f3fe6fa77f550118ad0cce23310e8b257846
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Sep 03 11:06:19 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8734f3fe6fa77f550118ad0cce23310e8b257846 [^]

Related to issue 41348 : Added AdminMode for ImportEntryPostProcessor hook implementations

---
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0114499)
aaroncalero (manager)
2019-09-10 16:05

After talking to Antonio, there are several things that should be changed/fixed:
1. The 'dummy' import entry needs to be sent to the hook in 'Processed' status (currently it is being sent as Initial)
2. The code to call the PostmportEntryProcessorHooks should be moved to the SynchronizedServerProcessCaller, the class that is in charge of executing the required DataSyncProcesses in Synchronized Mode.
3. The hooks need to be called 'by model' and not only once on each call to SynchronizedServerProcessCaller. For example, if there are two orders and two invoices in a single call to SynchronizedServerProcessCaller, then there should be a call to the hook for the orders and another call for the invoices.
4. Make sure that after relocating the hook calls, the hooks are still called based on their entity qualifier
5. The json added to the dummy import entry should be json passed as parameter to the corresponding processor
(0114610)
hgbot (developer)
2019-09-18 08:09

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6b1fe93a1bbc62c2009cc6b09ae90fba2c62e182
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Sep 18 11:39:38 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6b1fe93a1bbc62c2009cc6b09ae90fba2c62e182 [^]

Fixed issue 41348 : Added ImportEntryPostProcessor hook in DataSynchronizationProcess

* ImportEntryPostProcessor hook should be called for each object in the model.
* ImportEntry for hook should be created with Processed status
  and typeofdata value with ImportQualifier

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0114731)
ranjith_qualiantech_com (developer)
2019-09-23 15:58

Fix is not complete
(0114732)
hgbot (developer)
2019-09-23 16:14

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f92fc1605a8a296552c5be81d81aaad3dc4488d0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Sep 23 19:43:52 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f92fc1605a8a296552c5be81d81aaad3dc4488d0 [^]

Related to issue 41348 : Backed out all changeset due to design defect

Backed out changeset: 6b1fe93a1bbc

Backed out changeset: 8734f3fe6fa7

Backed out changeset: 2a5860a7698e

Backed out changeset: cc07e8529eae

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0114855)
hgbot (developer)
2019-09-30 11:12

Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: ec8e42b3c8766081f5e60edbe89beb7f9308ae01
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Sep 30 14:42:19 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/ec8e42b3c8766081f5e60edbe89beb7f9308ae01 [^]

Related to issue 41348 : Backed out changeset: a7431e3d814d

---
M src/org/openbravo/retail/sessions/WebPOSCloseStore.java
---

- Issue History
Date Modified Username Field Change
2019-07-15 07:24 guillermogil New Issue
2019-07-15 07:24 guillermogil Assigned To => Retail
2019-07-15 07:24 guillermogil Resolution time => 1564437600
2019-07-15 07:24 guillermogil Triggers an Emergency Pack => No
2019-07-30 20:34 rqueralta Assigned To Retail => rqueralta
2019-07-30 20:34 rqueralta Status new => scheduled
2019-08-05 09:44 guillermogil Steps to Reproduce Updated View Revisions
2019-08-08 15:02 ranjith_qualiantech_com Assigned To rqueralta => ranjith_qualiantech_com
2019-08-13 04:24 hgbot Checkin
2019-08-13 04:24 hgbot Note Added: 0113954
2019-08-13 08:20 hgbot Checkin
2019-08-13 08:20 hgbot Note Added: 0113956
2019-08-13 08:20 hgbot Status scheduled => resolved
2019-08-13 08:20 hgbot Resolution open => fixed
2019-08-13 08:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/cc07e8529eae9f154a7bb06de90f48e0bfaf5758 [^]
2019-08-14 09:07 hgbot Checkin
2019-08-14 09:07 hgbot Note Added: 0114003
2019-08-14 09:09 marvintm Review Assigned To => marvintm
2019-08-14 09:09 marvintm Status resolved => closed
2019-08-14 09:09 marvintm Fixed in Version => RR19Q4
2019-08-14 15:36 hgbot Checkin
2019-08-14 15:36 hgbot Note Added: 0114020
2019-08-14 15:37 ranjith_qualiantech_com Note Added: 0114021
2019-08-14 15:37 ranjith_qualiantech_com Status closed => new
2019-08-14 15:37 ranjith_qualiantech_com Resolution fixed => open
2019-08-14 15:37 ranjith_qualiantech_com Fixed in Version RR19Q4 =>
2019-08-19 15:36 ranjith_qualiantech_com Status new => scheduled
2019-08-20 11:45 hgbot Checkin
2019-08-20 11:45 hgbot Note Added: 0114098
2019-08-20 11:45 hgbot Status scheduled => resolved
2019-08-20 11:45 hgbot Resolution open => fixed
2019-08-20 11:45 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/cc07e8529eae9f154a7bb06de90f48e0bfaf5758 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2a5860a7698ef1128de8b4f6c5967c7e190e85f7 [^]
2019-08-22 18:31 marvintm Status resolved => closed
2019-08-22 18:31 marvintm Fixed in Version => RR19Q4
2019-09-03 07:36 hgbot Checkin
2019-09-03 07:36 hgbot Note Added: 0114368
2019-09-10 16:05 aaroncalero Note Added: 0114499
2019-09-10 16:05 aaroncalero Status closed => new
2019-09-10 16:05 aaroncalero Resolution fixed => open
2019-09-10 16:05 aaroncalero Fixed in Version RR19Q4 =>
2019-09-12 09:21 ranjith_qualiantech_com Status new => scheduled
2019-09-18 08:09 hgbot Checkin
2019-09-18 08:09 hgbot Note Added: 0114610
2019-09-18 08:09 hgbot Status scheduled => resolved
2019-09-18 08:09 hgbot Resolution open => fixed
2019-09-18 08:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2a5860a7698ef1128de8b4f6c5967c7e190e85f7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6b1fe93a1bbc62c2009cc6b09ae90fba2c62e182 [^]
2019-09-20 08:49 marvintm Status resolved => closed
2019-09-20 08:49 marvintm Fixed in Version => RR19Q4
2019-09-23 15:58 ranjith_qualiantech_com Note Added: 0114731
2019-09-23 15:58 ranjith_qualiantech_com Status closed => new
2019-09-23 15:58 ranjith_qualiantech_com Resolution fixed => open
2019-09-23 15:58 ranjith_qualiantech_com Fixed in Version RR19Q4 =>
2019-09-23 16:14 hgbot Checkin
2019-09-23 16:14 hgbot Note Added: 0114732
2019-09-25 15:15 marvintm Resolution time 1564437600 =>
2019-09-25 15:15 marvintm Type defect => design defect
2019-09-30 11:12 hgbot Checkin
2019-09-30 11:12 hgbot Note Added: 0114855
2019-12-07 08:15 ranjith_qualiantech_com Assigned To ranjith_qualiantech_com => Retail


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker