Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0041341

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2019-07-12 09:53

2019-07-17 19:11

Reporter

aaroncalero

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

RR19Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0041341: Customer Filter in Open Receipts selector assigns the customer to the receipt under specific circumstances

Description

After a specific flow, the customer filter in the Open Receipts selector stops working and, instead of setting the customer in the filter, it assigns the customer directly to the ticket.

Steps To Reproduce

Login in webpos
*Working case:
Go to the menu > Open Receipt
Click on the filter selector and select Customer.
Click on Select filter; the customer selector will open.
Search for Arturo Montoro and select it. WebPOS will return to the Open Receipts selector and Arturo Montoro will be shown on the filter.
Close the Open Receipt selector.

*Broken case:
Refresh the WebPOS.
Click on the Customer button of the receipt.
Search for Carl Studson.
Click on the context menu, then View Details.
Click on Assign Customer.
Go to the menu > Open Receipt
Click on the filter selector and select Customer.
Click on Select filter; the customer selector will open.
Notice that the Carl Studson filter is preset. Search for Arturo Montoro and select it.
Instead of showing the Open Receipt selector with the customer filtered, Arturo Montoro will be assigned to the ticket.

Proposed Solution

The problem seems to be on setting the "target" component of the selector. During the "broken" case, the target is not correctly set to the order selector, and instead it is still pointing to the order.
Attached a patch with a possible solution that sets the the target of the selector regardless of how it is opened.

Tags

No tags attached.

Issue41341.diff [^] (801 bytes) 2019-07-15 09:19 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js b/web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js
--- a/web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js
+++ b/web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js
@@ -879,6 +879,12 @@
         this.$.body.$.listBpsSelector.loadPresetCustomer(this.args.presetCustomerId);
       }
     } else {
+      this.bubble('onSetBusinessPartnerTarget', {
+        target: this.args.target
+      });
+      this.waterfall('onSetBusinessPartnerTarget', {
+        target: this.args.target
+      });
       if (this.keepFiltersOnClose) {
         this.doSetSelectorAdvancedSearch({
           isAdvanced: this.advancedFilterShowing

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0113405) hgbot (developer) 2019-07-16 13:42	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6a3173bcc5bd749adef7d4d0397e75e7db0c81b7 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Jul 16 17:12:04 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6a3173bcc5bd749adef7d4d0397e75e7db0c81b7 [^] Fixed issue 41341 : Business partner Selector popup should be opened with owner target --- M web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js ---

Issue History
Date Modified	Username	Field	Change
2019-07-12 09:53	aaroncalero	New Issue
2019-07-12 09:53	aaroncalero	Assigned To	=> Retail
2019-07-12 09:53	aaroncalero	OBNetwork customer	=> Gold
2019-07-12 09:53	aaroncalero	Resolution time	=> 1564092000
2019-07-12 09:53	aaroncalero	Triggers an Emergency Pack	=> No
2019-07-15 09:19	aaroncalero	File Added: Issue41341.diff
2019-07-15 09:22	aaroncalero	Proposed Solution updated
2019-07-15 10:10	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2019-07-15 10:10	ranjith_qualiantech_com	Status	new => scheduled
2019-07-16 13:42	hgbot	Checkin
2019-07-16 13:42	hgbot	Note Added: 0113405
2019-07-16 13:42	hgbot	Status	scheduled => resolved
2019-07-16 13:42	hgbot	Resolution	open => fixed
2019-07-16 13:42	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6a3173bcc5bd749adef7d4d0397e75e7db0c81b7 [^]
2019-07-17 19:11	guilleaer	Review Assigned To	=> guilleaer
2019-07-17 19:11	guilleaer	Status	resolved => closed
2019-07-17 19:11	guilleaer	Fixed in Version	=> RR19Q4

Copyright © 2000 - 2009 MantisBT Group