Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041267
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2019-07-01 09:582019-08-06 16:12
ReporteraaroncaleroView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR19Q3
StatusclosedFix in branchFixed in SCM revisionc3f4351df806
ProjectionnoneETAnoneTarget VersionRR19Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041267: OB.UTIL.clone always copies arrays by reference

DescriptionOB.UTIL.clone always copies arrays by reference, instead of generating a new array and cloning the values.
Steps To ReproduceCheck the code that copies array properties:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/web/org.openbravo.mobile.core/source/utils/ob-utilities.js#l1057 [^]

Instead of checking if the property is an array, the code is checking if the whole object is an array, which is wrong
Proposed SolutionIn the linked code, change from
} else if (_.isArray(source)) {
to
} else if (_.isArray(source.get(key))) {
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0041207 closedranjith_qualiantech_com OB.UTIL.clone always copies arrays by reference 

-  Notes
(0113506)
hgbot (developer)
2019-07-18 11:11

 Repository: retail/backports/3.0RR19Q3/org.openbravo.retail.posterminal
Changeset: cf8a6258cf114e96e6dea5d58dac67c6a455ba5d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jul 18 14:36:48 2019 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR19Q3/org.openbravo.retail.posterminal/rev/cf8a6258cf114e96e6dea5d58dac67c6a455ba5d [^]

Related to issue 41267 : Shipping Address should be same as invoice address when loading paid receipt

* When splitting lines with promotions, line lineQtyOffer should be updated instead of creating new lines to apply promotions

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0113507)
hgbot (developer)
2019-07-18 11:11

 Repository: retail/backports/3.0RR19Q3/org.openbravo.mobile.core
Changeset: c3f4351df806aab962230ff302aa0e6386712d75
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jul 18 14:36:40 2019 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR19Q3/org.openbravo.mobile.core/rev/c3f4351df806aab962230ff302aa0e6386712d75 [^]

Fixed issue 41267 : Update OB.UTIL.clone to check the property is an Array

* When cloning object from array, if object is backbone the it should cloned recursively
if object is not backbone, then copy of object should be pushed to target object

---
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---

- Issue History
Date Modified Username Field Change
2019-07-03 19:04 marvintm Type defect => backport
2019-07-03 19:04 marvintm Target Version => RR19Q3
2019-07-18 11:11 hgbot Checkin
2019-07-18 11:11 hgbot Note Added: 0113506
2019-07-18 11:11 hgbot Checkin
2019-07-18 11:11 hgbot Note Added: 0113507
2019-07-18 11:11 hgbot Status scheduled => resolved
2019-07-18 11:11 hgbot Resolution open => fixed
2019-07-18 11:11 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b963e8c9401e7a87f8758f6a08b89677a435a2cf [^] => http://code.openbravo.com/retail/backports/3.0RR19Q3/org.openbravo.mobile.core/rev/c3f4351df806aab962230ff302aa0e6386712d75 [^]
2019-08-06 16:12 marvintm Review Assigned To => marvintm
2019-08-06 16:12 marvintm Status resolved => closed
2019-08-06 16:12 marvintm Fixed in Version => RR19Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker