Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0041155

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

always

2019-06-24 13:02

2022-02-01 07:24

Reporter

aaroncalero

View Status

public

Assigned To

Triage Platform Base

Priority

normal

Resolution

open

Fixed in Version

Status

new

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Web browser

Google Chrome

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0041155: Mouse scrolling generates errors in the browser console in chrome 73+

Description

When using Openbravo backend in a Chrome browser (version 73 or up), scrolling anywhere in the application (quick launch, windows in grid/form view) shows the following error in the browser console:
ISC_Combined.js:1402 [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/6662647093133312 [^]

Steps To Reproduce

Log in in openbravo backend: https://livebuilds.openbravo.com/erp_pi_pgsql/ [^]
Open the browser console.
In the application, click on the Quick Launch button on the top left corner of the screen.
Display the Quick Lauch combo list.
Scroll up/down the list using the mouse wheel or laptop touchpad.
Verify that the error appears multiple times on the browser console.

Tags

No tags attached.

issue41155.diff [^] (1,161 bytes) 2019-06-24 15:49 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.userinterface.smartclient/isomorphic/client/event/EventHandler.js b/web/org.openbravo.userinterface.smartclient/isomorphic/client/event/EventHandler.js
--- a/web/org.openbravo.userinterface.smartclient/isomorphic/client/event/EventHandler.js
+++ b/web/org.openbravo.userinterface.smartclient/isomorphic/client/event/EventHandler.js
@@ -6305,7 +6305,7 @@
             nativeEventType = this._nativeEventName_TypeMap[nativeEventName] || 
                                   nativeEventName.substring(2);
                                   
-            object.addEventListener(nativeEventType, indirect, false);
+            object.addEventListener(nativeEventType, indirect, {passive: false});
     
         
         } else {
@@ -6332,7 +6332,8 @@
     var EH = this;
 	
     // Convert the public flag to use event listeners rather than directly specifying
-    // handlers at the docment level to an internal flag
+    // handlers at the docment level to an internal flag
+    window.isc_useEventListeners = true;
     if (window.isc_useEventListeners != null) EH._useEventListeners = window.isc_useEventListeners;

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

pi

closed

Smartclient behaves wrongly when creating a record with a filled filter

Notes
(0112976) AugustoMauch (manager) 2019-06-24 13:17 edited on: 2019-06-24 13:18	mouseWheel (Canvas.js:15578) invokeSuper (Class.js:1550) Super (Class.js:1368) mouseWheel (ListGrid.js:990) bubbleEvent (EventHandler.js:4751) handleMouseWheel (EventHandler.js:5742) dispatch (EventHandler.js:6152) (anonymous) (VM95:3) mouseWheel : function () { if ((this.overflow == isc.Canvas.AUTO \|\| this.overflow == isc.Canvas.SCROLL) && this.showCustomScrollbars && this.vscrollOn) { var wheelDeltaY = this.ns.EH.lastEvent.wheelDeltaY, wheelDeltaX = this.ns.EH.lastEvent.wheelDeltaX; // For each increment the user scrolled the mouse wheel, we want to move about 50px // This seems to approximately match native scrolling speed. var scrollTop = this.scrollTop + Math.round(wheelDeltaY * isc.Canvas.scrollWheelDelta); var scrollLeft = this.scrollLeft + Math.round(wheelDeltaX * isc.Canvas.scrollWheelDelta); // Note that scrollTo already catches scrolling past beginning or end this.scrollTo(scrollLeft, scrollTop, "mouseWheel"); // return false to cancel further / native processing return false; } // Not a scrollable region, return true return true; },

(0112978) AugustoMauch (manager) 2019-06-24 15:49	A patch has been attached. It fixes the problem that its secondary effects need to be thoroughly resesarched.

Issue History
Date Modified	Username	Field	Change
2019-06-24 13:02	aaroncalero	New Issue
2019-06-24 13:02	aaroncalero	Assigned To	=> platform
2019-06-24 13:02	aaroncalero	Web browser	=> Google Chrome
2019-06-24 13:02	aaroncalero	Modules	=> Core
2019-06-24 13:02	aaroncalero	Triggers an Emergency Pack	=> No
2019-06-24 13:17	AugustoMauch	Note Added: 0112976
2019-06-24 13:18	AugustoMauch	Note Edited: 0112976	View Revisions
2019-06-24 15:49	AugustoMauch	Note Added: 0112978
2019-06-24 15:49	AugustoMauch	File Added: issue41155.diff
2019-06-24 16:05	guillermogil	Web browser	Google Chrome => Google Chrome
2019-08-23 18:25	caristu	Relationship added	related to 0041664
2019-10-18 15:33	rafaroda	Issue Monitored: rafaroda
2022-02-01 07:24	alostale	Assigned To	platform => Triage Platform Base

Copyright © 2000 - 2009 MantisBT Group