|View Issue Details|
|Type||Category||Severity||Reproducibility||Date Submitted||Last Update|
|defect||[Openbravo ERP] A. Platform||major||always||2019-08-19 12:06||2019-08-25 06:50|
|Priority||urgent||Resolution||fixed||Fixed in Version||3.0PR19Q4|
|Status||closed||Fix in branch||Fixed in SCM revision||4e85e97f7efa|
|OS Version||Database version||Ant version|
|Product Version||pi||SCM revision|
|Review Assigned To||caristu|
|Regression introduced in release|
|Regression introduced by commit|
|Triggers an Emergency Pack||No|
0041664: Smartclient behaves wrongly when creating a record with a filled filter
|Description||If you fill a filter in grid view in a window, then create a new record in form view and switch tabs with a subtab or scroll up/down, many error logs appear. Also if you try to delete the created record, it asks for confirmation to delete 0 records.|
|Steps To Reproduce||1. Go to Sales Order window: https://livebuilds.openbravo.com/erp_pi_pgsql/ [^]|
2. Filter in Document No. by: "test" -> 0 results
3. Without clearing the filter, create new record in form view.
4. Assign a business partner and save the record.
5. Click on lines tab.
6. Click on header tab -> Error appears in console log:
Uncaught TypeError: Cannot read property 'id' of undefined (...)
7. Open some sections in the header so you can scroll (Dimensions, Audit, More Information...)
8. Scroll up and down -> New errors appear:
[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See <URL>
9. Delete record -> Are you sure that you want to delete the 0 selected records? This will also delete all their child records.
10. When deleting, the page is already broken and the process doesn't end.
|Tags||No tags attached.|
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Aug 22 10:40:55 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4e85e97f7efac09c149f386abb5e534985d994ed [^]
Fixes issue 41664: Record added in filtered empty grid is not filtered out
This code  was already in charge of manually adding to the grid records that have been created
in the form but that do not comply with the grid filter.
But that code was not working properly if the grid was empty when just before adding the new
record, because in that case view.viewGrid.body.getVisibleRows() (which is used to determine where
the new row should be placed) returns [-1, -1] (meaning that at that moment there are no visible
records), so the visibleRows !== -1 was not met.
An extra else clause has been added to handle the case where the grid total rows is 0. In that case
the new record is added in the position 0.
 https://code.openbravo.com/erp/devel/pi/file/a3916b3d436d/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js#l2013 [^]
Code reviewed + tested OK
Note that the error: "[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See <URL>" is still appearing but is not caused by this issue. See 0041155.
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.
Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2915449dde15 [^]
Maturity status: Test
|2019-08-19 12:06||joniturralde93||New Issue|
|2019-08-19 12:06||joniturralde93||Assigned To||=> platform|
|2019-08-19 12:06||joniturralde93||Modules||=> Core|
|2019-08-19 12:06||joniturralde93||Triggers an Emergency Pack||=> No|
|2019-08-19 12:16||malsasua||Issue Monitored: malsasua|
|2019-08-19 15:35||rafaroda||Issue Monitored: rafaroda|
|2019-08-22 10:30||AugustoMauch||Assigned To||platform => AugustoMauch|
|2019-08-22 10:31||AugustoMauch||Status||new => scheduled|
|2019-08-22 10:31||AugustoMauch||Review Assigned To||=> caristu|
|2019-08-22 10:45||hgbot||Note Added: 0114115|
|2019-08-22 10:45||hgbot||Status||scheduled => resolved|
|2019-08-22 10:45||hgbot||Resolution||open => fixed|
|2019-08-22 10:45||hgbot||Fixed in SCM revision||=> http://code.openbravo.com/erp/devel/pi/rev/4e85e97f7efac09c149f386abb5e534985d994ed [^]|
|2019-08-23 18:25||caristu||Note Added: 0114254|
|2019-08-23 18:25||caristu||Status||resolved => closed|
|2019-08-23 18:25||caristu||Fixed in Version||=> 3.0PR19Q4|
|2019-08-23 18:25||caristu||Relationship added||related to 0041155|
|2019-08-25 06:50||hudsonbot||Note Added: 0114256|
|Copyright © 2000 - 2009 MantisBT Group|