Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0041148 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2019-06-21 10:58 | 2019-08-09 14:56 | |||
| Reporter | xabiermerino | View Status | public | |||||
| Assigned To | rqueralta | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | RR19Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 954c72f4256a | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | Gold | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0041148: Wrong ticket if we apply two similiar "Free product per total amount" promotions | |||||||
| Description | Promotion 1 "Free product per total amount" > Total amount:5 > Free product: Avanalncher Promotion 2 "Free product per total amount" > Total amount:5 > Free product: Avanalncher | |||||||
| Steps To Reproduce | 1.- Create a ticket with amount > 5 2.- Click Amount button 3.- Introduce one of the promotion 4.- Click again the amount button 5.- Select the other promotion 6.- Pay it 7.- Go to backend and realize that "The sum of the gross of each line does not equal the gross of the order" | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Screenshot from 2019-07-11 12-59-49.png [^] (140,942 bytes) 2019-07-11 13:02
Screenshot from 2019-07-11 12-48-55.png [^] (164,167 bytes) 2019-07-11 13:03
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0113080) hgbot (developer) 2019-06-27 23:26 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: e2a0f4d8072718197e53687bc218acfc9f618d3b Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Thu Jun 27 17:21:42 2019 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/e2a0f4d8072718197e53687bc218acfc9f618d3b [^] Fixed issue 41148: Wrong ticket if we apply two similiar "Free product per total amount" promotions - After apply the free product discount sometimes the receipt is not recalculated, now to be sure a calculate gross is forced --- M web/org.openbravo.retail.discounts.bytotal/js/promotion-freeitemstotal.js --- |
|
(0113117) hgbot (developer) 2019-07-01 14:10 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 954c72f4256abfb5ec05c0f10078e93d7af0938f Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Wed Jun 26 19:24:43 2019 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/954c72f4256abfb5ec05c0f10078e93d7af0938f [^] Fixed issue 41148: Wrong ticket if we apply two similiar "Free product per total amount" promotions - After apply the free product discount sometimes the receipt is not recalculated, now to be sure a calculate gross is forced --- M web/org.openbravo.retail.posterminal/js/model/discounts.js --- |
|
(0113118) hgbot (developer) 2019-07-01 14:11 |
Repository: tools/automation/pi-mobile Changeset: 88f1a64ac5743ae2ba8b096205f1e8536d1690ce Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Sun Jun 30 09:09:32 2019 -0400 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/88f1a64ac5743ae2ba8b096205f1e8536d1690ce [^] Related to issue 41148: Wrong ticket if we apply two similiar "Free product per total amount" promotions - Required changes in three test case: SplitLineWithAutomaticPromoFreeProdPerTotalAmt SplitLineWithPromoComboFamilyComboFreeProd I41092_VerifyFreeProductPerTotalAmount --- M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41092_VerifyFreeProductPerTotalAmount.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithAutomaticPromoFreeProdPerTotalAmt.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithPromoComboFamilyComboFreeProd.java --- |
|
(0113271) hgbot (developer) 2019-07-11 12:49 |
Repository: retail/backports/3.0RR19Q3/pi-mobile Changeset: 2311618d625d63a9a90ccee2729cdafc34f6216e Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Thu Jul 11 10:34:21 2019 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR19Q3/pi-mobile/rev/2311618d625d63a9a90ccee2729cdafc34f6216e [^] Related to issue 41148: Wrong ticket if we apply two similiar "Free product per total amount" promotions - Required changes in three test case: SplitLineWithAutomaticPromoFreeProdPerTotalAmt SplitLineWithPromoComboFamilyComboFreeProd I41092_VerifyFreeProductPerTotalAmount --- M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41092_VerifyFreeProductPerTotalAmount.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithAutomaticPromoFreeProdPerTotalAmt.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithPromoComboFamilyComboFreeProd.java --- |
|
(0113273) adrianromero (viewer) 2019-07-11 13:02 |
It looks like now it is calculated the total of the receipt but some weird things still happens related for this test. For example in the test line https://code.openbravo.com/tools/automation/pi-mobile/file/tip/src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithAutomaticPromoFreeProdPerTotalAmt.java#l112 [^] Observe After increasing in one unit the "Camera Bag" line it has now two units, the total of the line is 21.00, ant the discount it is still -10.50. This is OK because it has been defined the discount with just 1 free unit of Camera Bag in the discount -> https://code.openbravo.com/tools/automation/pi-mobile/file/tip/src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithAutomaticPromoFreeProdPerTotalAmt.java#l166 [^] But the total is not incremented. Other possible issue is testing locally with the same discount applied is that defining the same discount as defined in the test: Free Products per Total Amount with a total greater than 500 with 3 free units of Adhesive body warmers and 1 free unit of Camera bag. If I create one ticket with 4 Avalanche transceiver and 4 "Camera bag", The POS adds a discount for the 4 camera bags. This is wrong, only one has to be free. And the label says "-- (2x) Free" when actually the application is discounting the 4 units. See screenshots attached. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-06-21 10:58 | xabiermerino | New Issue | |
| 2019-06-21 10:58 | xabiermerino | Assigned To | => Retail |
| 2019-06-21 10:58 | xabiermerino | OBNetwork customer | => Gold |
| 2019-06-21 10:58 | xabiermerino | Resolution time | => 1561672800 |
| 2019-06-21 10:58 | xabiermerino | Triggers an Emergency Pack | => No |
| 2019-06-24 05:15 | rqueralta | Assigned To | Retail => rqueralta |
| 2019-06-24 05:15 | rqueralta | Status | new => scheduled |
| 2019-06-27 10:49 | Asantos9 | Issue Monitored: Asantos9 | |
| 2019-06-27 23:26 | hgbot | Checkin | |
| 2019-06-27 23:26 | hgbot | Note Added: 0113080 | |
| 2019-06-27 23:26 | hgbot | Status | scheduled => resolved |
| 2019-06-27 23:26 | hgbot | Resolution | open => fixed |
| 2019-06-27 23:26 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/e2a0f4d8072718197e53687bc218acfc9f618d3b [^] |
| 2019-06-28 13:42 | rqueralta | Status | resolved => new |
| 2019-06-28 13:42 | rqueralta | Resolution | fixed => open |
| 2019-07-01 14:10 | hgbot | Checkin | |
| 2019-07-01 14:10 | hgbot | Note Added: 0113117 | |
| 2019-07-01 14:10 | hgbot | Status | new => resolved |
| 2019-07-01 14:10 | hgbot | Resolution | open => fixed |
| 2019-07-01 14:10 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/e2a0f4d8072718197e53687bc218acfc9f618d3b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/954c72f4256abfb5ec05c0f10078e93d7af0938f [^] |
| 2019-07-01 14:11 | hgbot | Checkin | |
| 2019-07-01 14:11 | hgbot | Note Added: 0113118 | |
| 2019-07-03 17:50 | rqueralta | Status | resolved => new |
| 2019-07-03 17:50 | rqueralta | Resolution | fixed => open |
| 2019-07-03 17:51 | rqueralta | Status | new => scheduled |
| 2019-07-03 17:51 | rqueralta | Status | scheduled => resolved |
| 2019-07-03 17:51 | rqueralta | Resolution | open => fixed |
| 2019-07-11 12:49 | hgbot | Checkin | |
| 2019-07-11 12:49 | hgbot | Note Added: 0113271 | |
| 2019-07-11 13:02 | adrianromero | Note Added: 0113273 | |
| 2019-07-11 13:02 | adrianromero | Status | resolved => new |
| 2019-07-11 13:02 | adrianromero | Resolution | fixed => open |
| 2019-07-11 13:02 | adrianromero | File Added: Screenshot from 2019-07-11 12-59-49.png | |
| 2019-07-11 13:03 | adrianromero | File Added: Screenshot from 2019-07-11 12-48-55.png | |
| 2019-08-09 14:56 | marvintm | Status | new => scheduled |
| 2019-08-09 14:56 | marvintm | Status | scheduled => resolved |
| 2019-08-09 14:56 | marvintm | Fixed in Version | => RR19Q3 |
| 2019-08-09 14:56 | marvintm | Resolution | open => fixed |
| 2019-08-09 14:56 | marvintm | Review Assigned To | => marvintm |
| 2019-08-09 14:56 | marvintm | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |