Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0041098
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2019-06-17 11:342019-06-26 04:55
ReporterjarmendarizView Statuspublic 
Assigned Tojarmendariz 
PriorityhighResolutionfixedFixed in Version3.0PR19Q3
StatusclosedFix in branchFixed in SCM revisionffea2c296b65
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041098: Javascript formatting scripts does not ignore files when processing individual files

DescriptionUsing the scripts (jslint/jsformatter) without parameters, it scans all .js files excepting those that matches the expressions in their respective .ignorefiles.

However, when one/various file paths are passed as parameters, those files are processed even if those files should be ignored.
Steps To Reproduce- Configure mercurial to use the provided mercurial hooks
- Modify an ignored file (for example scopeleaks.js)
- Note that this file appears as modified when you run 'hg status'
- Commit the changes
- Commit will fail because scopeleaks.js does have linting and formatting errors. In this case this file should be ignored and no formatting/lint check should be performed.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
caused by feature request 0039983 closedjarmendariz Upgrade javascript linter and formatter 

-  Notes
(0112810)
hgbot (developer)
2019-06-17 11:37

Repository: erp/devel/pi
Changeset: ffea2c296b65bfd9340c3cbd750b04d96832845a
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jun 14 09:37:34 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ffea2c296b65bfd9340c3cbd750b04d96832845a [^]

Fixed issue 41098: Ignore files not considered when processing individual files.

Improved jslint/jsformatter scripts to make then take into account .ignore files
when called passing a list of files. This avoids executing analysis on ignored
files via hook when making changes on them.

---
M modules/org.openbravo.client.kernel/jsformatter/jsformatter
M modules/org.openbravo.client.kernel/jslint/jslint
M modules/org.openbravo.client.kernel/jslint/jslint-hg
M modules/org.openbravo.client.kernel/jsutils/check-npm-deps
A modules/org.openbravo.client.kernel/jslint/filter-eslint-ignored-files.js
---
(0112840)
hudsonbot (developer)
2019-06-17 19:39

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2ad95dac1570 [^]
Maturity status: Test
(0112990)
hgbot (developer)
2019-06-24 18:30

Repository: erp/devel/pi
Changeset: cc283e42fc24a43a9768a78a72b2cddef43847c4
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Mon Jun 24 18:29:27 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cc283e42fc24a43a9768a78a72b2cddef43847c4 [^]

Related to issue 41098: Added documentation to code

In this case it makes more sense to document the purpose of the slice operation rather
than creating a constant for the 'magic number'.

---
M modules/org.openbravo.client.kernel/jslint/filter-eslint-ignored-files.js
---
(0112991)
caristu (developer)
2019-06-24 18:32

Reviewed + tested OK
(0113019)
hudsonbot (developer)
2019-06-26 04:55

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0c724fa9726e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2019-06-17 11:34 jarmendariz New Issue
2019-06-17 11:34 jarmendariz Assigned To => platform
2019-06-17 11:34 jarmendariz Modules => Core
2019-06-17 11:34 jarmendariz Triggers an Emergency Pack => No
2019-06-17 11:34 jarmendariz Relationship added caused by 0039983
2019-06-17 11:37 hgbot Checkin
2019-06-17 11:37 hgbot Note Added: 0112810
2019-06-17 11:37 hgbot Status new => resolved
2019-06-17 11:37 hgbot Resolution open => fixed
2019-06-17 11:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ffea2c296b65bfd9340c3cbd750b04d96832845a [^]
2019-06-17 11:42 jarmendariz Review Assigned To => caristu
2019-06-17 19:39 hudsonbot Checkin
2019-06-17 19:39 hudsonbot Note Added: 0112840
2019-06-24 16:07 shuehner Assigned To platform => jarmendariz
2019-06-24 18:30 hgbot Checkin
2019-06-24 18:30 hgbot Note Added: 0112990
2019-06-24 18:32 caristu Note Added: 0112991
2019-06-24 18:32 caristu Status resolved => closed
2019-06-24 18:32 caristu Fixed in Version => 3.0PR19Q3
2019-06-26 04:55 hudsonbot Checkin
2019-06-26 04:55 hudsonbot Note Added: 0113019


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker