Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0041097 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Discounts by Total | major | always | 2019-06-17 11:16 | 2019-08-08 10:18 | |||
Reporter | jorgewederago | View Status | public | |||||
Assigned To | ranjith_qualiantech_com | |||||||
Priority | high | Resolution | fixed | Fixed in Version | RR19Q4 | |||
Status | closed | Fix in branch | Fixed in SCM revision | f1324d50d9e5 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | pi | SCM revision | ||||||
Merge Request Status | ||||||||
Review Assigned To | jorge-garcia | |||||||
OBNetwork customer | Gold | |||||||
Support ticket | 9911 | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0041097: When adding multiple discounts the override functionality is not working as expected under certain conditions | |||||||
Description | When adding multiple discounts the override functionality is not working as expected under certain conditions | |||||||
Steps To Reproduce | In PI with modules environment Backend: Deactivate the 10% discount on GPS WebPOS: Add Avalanche Transceiver (must be done in this order) Add GPS Handheld Add the following discount disc_5_var_eur to the GPS Add the following discount Variable Percentage Discount by Total 50% Add the discount disc_5_var_eur with a value of 10 to the GPS This case will not working since is part of the previous fix Add the previous discount again but with override checked The variable discount of 5 will disappear In the Avalanche Transceiver the % discount by total will be duplicated | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
|||||||||||||||
|
![]() |
|
(0113323) hgbot (developer) 2019-07-12 11:14 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6feb61e3aced9b0d972f16ca4978bd220d46011b Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Jul 12 14:44:21 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6feb61e3aced9b0d972f16ca4978bd220d46011b [^] Fixed issue 41097 : Manual discounts should not be removed when removing discounts with qtyOffer * After calculating discounts, Manual discounts should not be removed from auxReceipt because manual discounts doesn't consume units of the lines --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
(0113393) ranjith_qualiantech_com (viewer) 2019-07-16 09:25 |
Test failing in modules suite |
(0113396) hgbot (developer) 2019-07-16 09:39 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d2d967a08405061dba48f4ed478a0375e99f9774 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Jul 16 13:08:22 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d2d967a08405061dba48f4ed478a0375e99f9774 [^] Related to issue 41097 : Backed out changeset: 6feb61e3aced --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
(0113783) hgbot (developer) 2019-08-02 14:02 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: 3f8891c8351b58b1ac0cd7c6bebd28824094fbf1 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Aug 02 17:31:41 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/3f8891c8351b58b1ac0cd7c6bebd28824094fbf1 [^] Related to issue 41097 : Total discounts should be recalculated for Nongrouped Products * If receipt contains both grouped and nonprouped products, then line orderManualPromotionsAlreadyApplied will be updated as false for nonprouped product line * While calculating discounts for nonprouped product line, other receipt lines total discounts promotions should be prevented --- M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js --- |
(0113804) hgbot (developer) 2019-08-05 08:23 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: f1324d50d9e54bac4a88f05673333ac56a7b278f Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Aug 05 11:52:45 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f1324d50d9e54bac4a88f05673333ac56a7b278f [^] Fixed issue 41097 : Discounts should be replaced in fillpromotions * While applying manual discount, discount property will be always true, since manual discounts doesn't consume units of the lines * While overriding manual discount, discount property forceReplace will be set as true, So it will remove the replace the existing discount with new applied discount * In fillPromotiionStandard, if the line has Same Promotion for mutiple times, all the promotions will be removed and one promotions will be added wit chunks. Instead of adding promotion at last of the array, promotion should be added at the first index of the respective promotion. So Promotion order will not be changed --- M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js --- |
(0113805) hgbot (developer) 2019-08-05 08:23 |
Repository: tools/automation/pi-mobile Changeset: dbb9cf6241b34d7bf79dab4d3ac519a2ad6eb14f Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Aug 05 11:53:21 2019 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/dbb9cf6241b34d7bf79dab4d3ac519a2ad6eb14f [^] Verifies issue 41097 : Added automated test 'I41097_VerifyManualAndTotalDiscounts' * Modified Test 'I33201_VerifyPackCombinedWithManualPromotions' --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I33201_VerifyPackCombinedWithManualPromotions.java A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41097_VerifyManualAndTotalDiscounts.java --- |
(0113898) jorge-garcia (viewer) 2019-08-08 10:18 |
Code reviewed and tested |
![]() |
|||
Date Modified | Username | Field | Change |
2019-06-17 11:16 | jorgewederago | New Issue | |
2019-06-17 11:16 | jorgewederago | Assigned To | => Retail |
2019-06-17 11:16 | jorgewederago | OBNetwork customer | => Gold |
2019-06-17 11:16 | jorgewederago | Support ticket | => 9911 |
2019-06-17 11:16 | jorgewederago | Resolution time | => 1562536800 |
2019-06-17 11:16 | jorgewederago | Triggers an Emergency Pack | => No |
2019-06-21 12:47 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
2019-06-21 12:49 | ranjith_qualiantech_com | Status | new => scheduled |
2019-06-24 11:15 | ranjith_qualiantech_com | Relationship added | caused by 0040666 |
2019-07-03 17:13 | ngarcia | Issue Monitored: ngarcia | |
2019-07-03 18:32 | ngarcia | Relationship added | related to 0041266 |
2019-07-12 11:14 | hgbot | Checkin | |
2019-07-12 11:14 | hgbot | Note Added: 0113323 | |
2019-07-12 11:14 | hgbot | Status | scheduled => resolved |
2019-07-12 11:14 | hgbot | Resolution | open => fixed |
2019-07-12 11:14 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6feb61e3aced9b0d972f16ca4978bd220d46011b [^] |
2019-07-16 09:25 | ranjith_qualiantech_com | Note Added: 0113393 | |
2019-07-16 09:25 | ranjith_qualiantech_com | Status | resolved => new |
2019-07-16 09:25 | ranjith_qualiantech_com | Resolution | fixed => open |
2019-07-16 09:25 | ranjith_qualiantech_com | Status | new => scheduled |
2019-07-16 09:39 | hgbot | Checkin | |
2019-07-16 09:39 | hgbot | Note Added: 0113396 | |
2019-07-23 11:34 | ranjith_qualiantech_com | File Added: issue 41097 source test.patch | |
2019-08-02 14:02 | hgbot | Checkin | |
2019-08-02 14:02 | hgbot | Note Added: 0113783 | |
2019-08-05 08:23 | hgbot | Checkin | |
2019-08-05 08:23 | hgbot | Note Added: 0113804 | |
2019-08-05 08:23 | hgbot | Status | scheduled => resolved |
2019-08-05 08:23 | hgbot | Resolution | open => fixed |
2019-08-05 08:23 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6feb61e3aced9b0d972f16ca4978bd220d46011b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f1324d50d9e54bac4a88f05673333ac56a7b278f [^] |
2019-08-05 08:23 | hgbot | Checkin | |
2019-08-05 08:23 | hgbot | Note Added: 0113805 | |
2019-08-08 10:18 | jorge-garcia | Review Assigned To | => jorge-garcia |
2019-08-08 10:18 | jorge-garcia | Note Added: 0113898 | |
2019-08-08 10:18 | jorge-garcia | Status | resolved => closed |
2019-08-08 10:18 | jorge-garcia | Fixed in Version | => RR19Q4 |
Copyright © 2000 - 2009 MantisBT Group |