Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0041073
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2019-06-12 08:352019-08-22 14:45
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q4
StatusclosedFix in branchFixed in SCM revisionce9737beff16
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041073: BigDecimal.js uses deprecated Function.arguments

DescriptionBigDecimal JavaScript library, used in backoffice (org.openbravo.client.kernel) and in mobile applications (org.openbravo.mobile.core) makes use of Function.arguments which is a deprecated JavaScript feature that might be removed in future [1].

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/arguments [^]
Steps To Reproduce-
Proposed SolutionPossible alternatives:

1. Update this library to a version not using it. Note there are no updates for years now [1].
2. Fix current version not to make use of it. Repo forked here [2]
3. Look for a replacement library

[1] https://github.com/latentflip/BigDecimal.js [^]
[2] https://github.com/alostale/BigDecimal.js [^]
TagsNo tags attached.
Attached Filesdiff file icon 41073_core.diff [^] (60,324 bytes) 2019-07-05 11:00 [Show Content]
diff file icon 41073_mobilecore.diff [^] (290,350 bytes) 2019-07-05 11:10

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0113616)
hgbot (developer)
2019-07-24 13:40

Repository: erp/devel/pi
Changeset: 749257ab2004156a6670b6f82e1eddd35873cb6b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Jul 08 14:09:33 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/749257ab2004156a6670b6f82e1eddd35873cb6b [^]

fixed issue 41073: BigDecimal.js uses deprecated Function.arguments

  Updated BidDecimal.js library from version 1.0.2 to 1.0.3 which is a fork of
  original one that can be found at https://github.com/alostale/BigDecimal.js. [^]

---
M legal/Licensing.txt
M modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/ui-test-suite/index.html
M src/index.jsp
A modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/js/BigDecimal-all-1.0.3.js
A modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/js/BigDecimal-all-1.0.3.min.js
R modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/js/BigDecimal-all-1.0.1.min.js
---
(0113617)
hgbot (developer)
2019-07-24 13:41

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ce9737beff16ea550c51270c86ef15d974b4b1d3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Jul 08 14:11:34 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ce9737beff16ea550c51270c86ef15d974b4b1d3 [^]

fixed bug 41073: BigDecimal.js uses deprecated Function.arguments

  Removed copy of that library in mobile.core to use the one in client.kernel
  which has been updated to fix the problem.

---
M legal/Licensing.txt
M src/org/openbravo/mobile/core/LibraryResource.java
R legal/icu4j_license.txt
R web/org.openbravo.mobile.core/lib/vendor/bigdecimal-1.0.1.js
R web/org.openbravo.mobile.core/lib/vendor/bigdecimal-1.0.1.min.js
---
(0113653)
caristu (developer)
2019-07-26 08:15

Reviewed + tested OK.
(0114174)
hudsonbot (developer)
2019-08-22 14:45

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2019-06-12 08:35 alostale New Issue
2019-06-12 08:35 alostale Assigned To => platform
2019-06-12 08:35 alostale Modules => Core
2019-06-12 08:35 alostale Triggers an Emergency Pack => No
2019-06-12 08:36 alostale Status new => acknowledged
2019-06-12 08:39 alostale Proposed Solution updated
2019-06-12 16:36 alostale Proposed Solution updated
2019-07-05 11:00 caristu File Added: 41073_core.diff
2019-07-05 11:10 caristu File Added: 41073_mobilecore.diff
2019-07-24 13:40 hgbot Checkin
2019-07-24 13:40 hgbot Note Added: 0113616
2019-07-24 13:40 hgbot Status acknowledged => resolved
2019-07-24 13:40 hgbot Resolution open => fixed
2019-07-24 13:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/749257ab2004156a6670b6f82e1eddd35873cb6b [^]
2019-07-24 13:41 alostale Review Assigned To => caristu
2019-07-24 13:41 hgbot Checkin
2019-07-24 13:41 hgbot Note Added: 0113617
2019-07-24 13:41 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/749257ab2004156a6670b6f82e1eddd35873cb6b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ce9737beff16ea550c51270c86ef15d974b4b1d3 [^]
2019-07-26 08:15 caristu Assigned To platform => alostale
2019-07-26 08:15 caristu Note Added: 0113653
2019-07-26 08:15 caristu Status resolved => closed
2019-07-26 08:16 caristu Fixed in Version => 3.0PR19Q4
2019-08-22 14:45 hudsonbot Checkin
2019-08-22 14:45 hudsonbot Note Added: 0114174


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker