0040914: functional: review FK columns to set which ones shouldn't generate one-to-many property in parent entity

Description

After 0040290 implemented the capacity of defining which foreign key database column should generate a one-to-many property in their referenced parent entity, all existing columns were set to continue generating them in order to preserve backward compatibility.

All these columns should be now reviewed to decide, case by case, if those parent properties should be generated.

Steps To Reproduce

Proposed Solution

The following spreadsheet [1], lists all these columns for pi + retail pack. Splitting each of them by the owner team.

Column H (Keep) flags whether it should be kept (Y) or can be removed (N). When a column is marked to be removed, SQL column (K) generates the query to be run; grep column (J) contains a grep expression (check comment in header on how to use it) to look for HQL occurrences of the removed property in case there are occurrences (check for false positives), either the column cannot be removed or code needs to be fixed.

After executing the SQL, run ant.generate entities and rebuild the system to check for users of the deleted methods.

---
[1] https://docs.google.com/spreadsheets/d/1hdwjGM4_3TJ-9Bcylh_w_MM54_1T_cUlicaPfEyH1MQ/edit#gid=0 [^]

Tags

Performance

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of	feature request	0041228	3.0PR19Q4	closed	vmromanos	One-to-many clean up of existing columns (Functional)
related to	design defect	0040906		closed	alostale	platform: review FK columns to set which ones shouldn't generate one-to-many property in parent entity
depends on	feature request	0040290		closed	alostale	do not generate one-to-many property in parent entity for all FK properties

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2019-05-20 12:57	alostale	New Issue
2019-05-20 12:57	alostale	Assigned To	=> Triage Finance
2019-05-20 12:57	alostale	Modules	=> Core
2019-05-20 12:57	alostale	Triggers an Emergency Pack	=> No
2019-05-20 12:57	alostale	Issue generated from	0040906
2019-05-20 12:57	alostale	Relationship added	related to 0040906
2019-05-20 12:57	alostale	Relationship added	depends on 0040290
2019-05-20 13:03	alostale	Tag Attached: Performance
2019-07-23 15:43	vmromanos	Review Assigned To	=> vmromanos
2019-07-23 15:43	vmromanos	Relationship added	duplicate of 0041228
2019-07-23 15:43	vmromanos	Status	new => closed
2019-07-23 15:43	vmromanos	Resolution	open => duplicate
2019-07-23 15:43	vmromanos	Fixed in Version	=> 3.0PR19Q4