Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0040724

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2019-04-30 13:52

2019-05-08 18:05

Reporter

guillermogil

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

immediate

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

Regression level

Production - Confirmed Stable

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0040724: Scrim is hidden on Close Drawer Popup

Description

Scrim is hidden on Close Drawer Popup allowing to click everywhere.

It does not happen in PI but it happens in 18Q4 and 19Q1.

Steps To Reproduce

Configure Web POS Close Drawer Before Continue preference
Set up hardware URL http://localhost:8090/printer [^]
Open HWM
Configure Cash Payment Method with Open Drawer Before Closing Ticket

Login on WebPOS
Add a Product
Pay
Click Open

Tags

No tags attached.

issue 40724 19Q1 source posterminal.patch [^] (1,624 bytes) 2019-05-08 11:05 [Show Content] [Hide Content]

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1557299328 -19800
#      Wed May 08 12:38:48 2019 +0530
# Node ID c97c2ec6450e57650f83130668595a6cacaa6ac6
# Parent  9e8e7da1b0592c2379eddeb2d39e0c5ac0493017
Related to issue 40724 : Scrim should not be hidden when close drawer popup is opened

diff -r 9e8e7da1b059 -r c97c2ec6450e web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js	Thu May 02 11:54:03 2019 +0530
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js	Wed May 08 12:38:48 2019 +0530
@@ -1721,7 +1721,9 @@
                 }, OB.MobileApp.model.get('permissions').OBPOS_timeAllowedDrawerSales);
                 me.drawerOpened = true;
                 me.setContent(OB.I18N.getLabel('OBPOS_LblDone'));
-                enyo.$.scrim.hide();
+                if (OB.MobileApp.view.openedPopup === null) {
+                  enyo.$.scrim.hide();
+                }
               }
             } else {
               if (me.owner.receipt.get('orderType') === 3) {
@@ -1748,7 +1750,9 @@
                 }, OB.MobileApp.model.get('permissions').OBPOS_timeAllowedDrawerSales);
                 me.drawerOpened = true;
                 me.setContent(OB.I18N.getLabel('OBPOS_LblDone'));
-                enyo.$.scrim.hide();
+                if (OB.MobileApp.view.openedPopup === null) {
+                  enyo.$.scrim.hide();
+                }
               }
             } else {
               me.owner.model.get('multiOrders').trigger('paymentDone', me.allowOpenDrawer);

issue 40724 18Q4 source posterminal.patch [^] (1,602 bytes) 2019-05-08 11:05 [Show Content] [Hide Content]

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1557299342 -19800
#      Wed May 08 12:39:02 2019 +0530
# Node ID 8af1b03eed48c3b2545cd4403be74e20eb846db4
# Parent  55966c78ef586d1c6a990f182468185f1209f151
Related to issue 40724 : Scrim should not be hidden when close drawer popup is opened

diff -r 55966c78ef58 -r 8af1b03eed48 web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js	Tue Apr 16 07:37:22 2019 +0000
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js	Wed May 08 12:39:02 2019 +0530
@@ -1321,7 +1321,9 @@
             }, OB.MobileApp.model.get('permissions').OBPOS_timeAllowedDrawerSales);
             this.drawerOpened = true;
             this.setContent(OB.I18N.getLabel('OBPOS_LblDone'));
-            enyo.$.scrim.hide();
+            if (OB.MobileApp.view.openedPopup === null) {
+              enyo.$.scrim.hide();
+            }
           }
         } else {
           if (this.owner.receipt.get('orderType') === 3 && !this.owner.receipt.get('cancelLayaway')) {
@@ -1351,7 +1353,9 @@
             }, OB.MobileApp.model.get('permissions').OBPOS_timeAllowedDrawerSales);
             this.drawerOpened = true;
             this.setContent(OB.I18N.getLabel('OBPOS_LblDone'));
-            enyo.$.scrim.hide();
+            if (OB.MobileApp.view.openedPopup === null) {
+              enyo.$.scrim.hide();
+            }
           }
         } else {
           this.owner.model.get('multiOrders').trigger('paymentDone', this.allowOpenDrawer);

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

RR19Q1.2

closed

ranjith_qualiantech_com

Scrim is hidden on Close Drawer Popup

Notes
(0111581) marvintm (viewer) 2019-05-08 18:05	No change required in pi, problem only happened in 19Q1

Issue History
Date Modified	Username	Field	Change
2019-04-30 13:52	guillermogil	New Issue
2019-04-30 13:52	guillermogil	Assigned To	=> Retail
2019-04-30 13:52	guillermogil	OBNetwork customer	=> Gold
2019-04-30 13:52	guillermogil	Resolution time	=> 1558389600
2019-04-30 13:52	guillermogil	Regression level	=> Production - Confirmed Stable
2019-04-30 13:52	guillermogil	Triggers an Emergency Pack	=> No
2019-05-07 08:42	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2019-05-07 08:42	ranjith_qualiantech_com	Status	new => scheduled
2019-05-08 11:05	ranjith_qualiantech_com	File Added: issue 40724 19Q1 source posterminal.patch
2019-05-08 11:05	ranjith_qualiantech_com	File Added: issue 40724 18Q4 source posterminal.patch
2019-05-08 15:22	marvintm	Status	scheduled => acknowledged
2019-05-08 15:23	marvintm	Status	acknowledged => scheduled
2019-05-08 18:05	marvintm	Note Added: 0111581
2019-05-08 18:05	marvintm	Status	scheduled => resolved
2019-05-08 18:05	marvintm	Resolution	open => fixed
2019-05-08 18:05	marvintm	Review Assigned To	=> marvintm
2019-05-08 18:05	marvintm	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group