0040715: POSUtils.getPriceListVersionForPriceList is not using bind-parameters

Description

This code is not using bind-params:

      Query<PriceListVersion> priceListVersionQuery = OBDal.getInstance()
          .getSession()
          .createQuery("from PricingPriceListVersion AS plv " + "where plv.priceList.id ='"
              + priceListId
              + "' and plv.active=true and plv.validFromDate = (select max(pplv.validFromDate) "
              + "from PricingPriceListVersion as pplv where pplv.active=true and pplv.priceList.id = '"
              + priceListId + "' and to_char(pplv.validFromDate,'yyyy-mm-dd') <= '"
              + format.format(terminalDate) + "' )", PriceListVersion.class);
      for (PriceListVersion plv : priceListVersionQuery.list()) {
        return plv;
      }

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0040583

closed

ranjith_qualiantech_com

POSUtils.getPriceListVersionForPriceList is not using bind-parameters

Notes
(0111415) hgbot (developer) 2019-05-02 08:22	Repository: retail/backports/3.0RR19Q1.1/org.openbravo.retail.posterminal Changeset: 65923c70002a2a6b09b23c19758e6cd73640fa84 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu May 02 11:52:06 2019 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR19Q1.1/org.openbravo.retail.posterminal/rev/65923c70002a2a6b09b23c19758e6cd73640fa84 [^] Fixed issue 40715 : Update POSUtils query to use query parameter --- M src/org/openbravo/retail/posterminal/POSUtils.java ---

Issue History
Date Modified	Username	Field	Change
2019-04-30 11:53	shuehner	Type	defect => backport
2019-04-30 11:53	shuehner	Target Version	=> RR19Q1.1
2019-05-02 08:22	hgbot	Checkin
2019-05-02 08:22	hgbot	Note Added: 0111415
2019-05-02 08:22	hgbot	Status	scheduled => resolved
2019-05-02 08:22	hgbot	Resolution	open => fixed
2019-05-02 08:22	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c82334b59fdf53cb9b49284e8ff3a939c5c46d03 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1.1/org.openbravo.retail.posterminal/rev/65923c70002a2a6b09b23c19758e6cd73640fa84 [^]
2019-05-02 08:31	marvintm	Review Assigned To	adrianromero => marvintm
2019-05-02 08:31	marvintm	Status	resolved => closed
2019-05-02 08:31	marvintm	Fixed in Version	=> RR19Q1.1