Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0040688
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementtrivialhave not tried2019-04-25 19:502019-05-17 08:06
ReporterAtulOpenbravoView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q3
StatusclosedFix in branchFixed in SCM revision08b774b8d4c9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040688: API Change:Remove obsolete and disabled old APRM code

DescriptionRemove process AddOrderOrInvoice, AddPaymentFromTransaction, AddPaymentFromInvoice, AddTransaction, SelectExpectedPayments, Model Object & its Mapping, Messages, Text Interfaces.

The processes are inactive and not used any more. Removing related *.html, *.java, *.xml, *.srpt, *Grid.xml and related to processes has low risk as sample data references in AD_Process_Access could be managed in Sample Data for F&B International Group, QA Testing in Core, The White Valley Group in Retail Sample Data module, AWO QA in AWO Sample Data Module, v3 Dataset module.

Removing below methods that are only used in removed java classes has low risk as they are not used in the any other classes in core as well as external modules.
* AdvPaymentMngtDao - getAlternativePaymentsNotDeposited
* AdvPaymentMngtDao - getFilteredScheduledPaymentDetails
* AdvPaymentMngtDao - getNewFinancialTransaction
* AdvPaymentMngtDao - getPaymentProposalDetailAmount
* AdvPaymentMngtDao - getPaymentsNotDeposited
* FIN_AddPayment - getGLItemScheduleDetails
* FIN_AddPayment - getSelectedPaymentDetailsAndAmount
* FIN_AddPayment - getSelectedPendingPaymentsFromProposal
* FIN_AddPayment - getShownScheduledPaymentDetails
* FIN_AddPayment - isForcedFinancialAccountTransaction
* DimensionDisplayUtility - displayAcctDimensions
Steps To Reproduce-
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks feature request 00405573.0PR19Q3 closedAtulOpenbravo Remove more obsolete & disabled old aprm code (AddOrderOrInvoice, AddPaymentFrom*, AddTransactions & SelectExpectedPayments) 

-  Notes
(0111737)
hgbot (developer)
2019-05-16 20:41

 Repository: erp/devel/api-checks
Changeset: 08b774b8d4c948f7448a9c9c5a711c556e1f1494
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 03 15:03:58 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/08b774b8d4c948f7448a9c9c5a711c556e1f1494 [^]

Fixes Issue 40561, Issue 40563, Issue 40688:Api Change

** Remove form AccountTransaction
** Remove Transaction Old tab and its field in financial
account window.
** Remove process Match Statement & Match Statement Force
** Remove process AddOrderOrInvoice, AddPaymentFromTransaction,
AddPaymentFromInvoice, AddTransaction, SelectExpectedPayments
** Remove model object & its mapping for above form/process
** Remove EM_APRM_ADDTRANSACTION column from Financial Account,
related field, element.
** Remove related ad_message in above form/process.
** Remove related ad_textinterfaces in above form/process.
** Remove fin_recline_temp table, its ad elements, ad_message,
ad_references, selector, selector field, validation rule

---
M model/modules/org.openbravo.advpaymentmngt/src-db/database/model/modifiedTables/FIN_FINANCIAL_ACCOUNT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FORM.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_PROCESS.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REFERENCE.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REF_LIST.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_VAL_RULE.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
M model/modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_DATASET_TABLE.xml
M model/src-db/database/sourcedata/AD_ELEMENT.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
M model/src-db/database/sourcedata/AD_MESSAGE.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M model/src-db/database/sourcedata/AD_PROCESS.xml
M model/src-db/database/sourcedata/AD_TABLE.xml
M model/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
R model/src-db/database/model/tables/FIN_RECLINE_TEMP.xml
---
(0111741)
hgbot (developer)
2019-05-16 20:41

 Repository: erp/devel/api-checks
Changeset: 0c161656288bbd6bf12b48f13327bf4126c8e376
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 17 00:08:58 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/0c161656288bbd6bf12b48f13327bf4126c8e376 [^]

Related To Issue 40561, Issue 40563, Issue 40688:Api Change

** Remove unused classes AddOrderOrInvoice, AddPaymentFromInvoice,
AddPaymentFromTransaction, AddTransaction, MatchTransaction,
SelectExpectedPayments, Transactions, CreateFile,
FIN_ReconciliationLineTemp
** Remove unused methods getTrxGridRows, getTrxGridRowCount,
getPaymentsNotDeposited, getPaymentProposalDetailAmount,
getNewFinancialTransaction, getFilteredScheduledPaymentDetails,
getCustomerPaymentsWithCredit, getAlternativePaymentsNotDeposited,
getCustomerCredit from class AdvPaymentMngtDao.
** Remove unused methods getReconciliationEndingBalance,
getMatchedBankStatementLines, addNewReconciliation from class
MatchTransactionDao.
** Remove unused methods process, getPendingToMatchCount from class
TransactionsDao.
** Remove unused methods isForcedFinancialAccountTransaction,
getShownScheduledPaymentDetails, getSelectedPendingPaymentsFromProposal,
getSelectedPaymentDetailsAndAmount, getGLItemScheduleDetails
from class FIN_AddPayment.
** Remove unused method prepareRelationTemplateNoSearch
from class ToolBar
** Remove unused methods displayAcctDimensions from
class DimensionDisplayUtility

---
M java/reference/java.japi.gz
---
(0111753)
vmromanos (manager)
2019-05-17 08:06

 CI passed successfully

- Issue History
Date Modified Username Field Change
2019-04-25 19:50 AtulOpenbravo New Issue
2019-04-25 19:50 AtulOpenbravo Assigned To => dmitry_mezentsev
2019-04-25 19:50 AtulOpenbravo Modules => Core
2019-04-25 19:50 AtulOpenbravo Triggers an Emergency Pack => No
2019-04-25 19:50 AtulOpenbravo Issue generated from 0040563
2019-04-25 19:51 AtulOpenbravo Description Updated View Revisions
2019-04-25 19:51 AtulOpenbravo Relationship added blocks 0040557
2019-04-29 13:57 dmitry_mezentsev Tag Attached: Approved
2019-04-29 13:58 dmitry_mezentsev Assigned To dmitry_mezentsev => AtulOpenbravo
2019-05-16 20:41 hgbot Checkin
2019-05-16 20:41 hgbot Note Added: 0111737
2019-05-16 20:41 hgbot Checkin
2019-05-16 20:41 hgbot Note Added: 0111741
2019-05-17 08:04 vmromanos Status new => scheduled
2019-05-17 08:06 vmromanos Note Added: 0111753
2019-05-17 08:06 vmromanos Status scheduled => resolved
2019-05-17 08:06 vmromanos Fixed in Version => 3.0PR19Q3
2019-05-17 08:06 vmromanos Fixed in SCM revision => https://code.openbravo.com/erp/devel/api-checks/rev/08b774b8d4c948f7448a9c9c5a711c556e1f1494 [^]
2019-05-17 08:06 vmromanos Resolution open => fixed
2019-05-17 08:06 vmromanos Review Assigned To => vmromanos
2019-05-17 08:06 vmromanos Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker