Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040581
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServerminorhave not tried2019-04-10 12:422019-06-24 12:06
ReportershuehnerView Statuspublic 
Assigned Tojarmendariz 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision254b693f17e3
ProjectionnoneETAnoneTarget VersionRR19Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040581: SynchronizedServerProcessCaller.thereIsDataInImportQueue is not using bind-parameters

DescriptionThis code is not using bind-params:

      final String whereClause = ImportEntry.PROPERTY_IMPORTSTATUS + "='" + importStatus + "' and "
          + ImportEntry.PROPERTY_TYPEOFDATA + "='OBMOBC_SynchronizedData' and "
          + ImportEntry.PROPERTY_CREATIONDATE + "<:creationDate and "
          + ImportEntry.PROPERTY_ORGANIZATION + "=:org and id!=:id";
      final Query<Number> qry = OBDal.getInstance()
          .getSession()
          .createQuery("select count(*) from " + ImportEntry.ENTITY_NAME + " where " + whereClause,
              Number.class);
Steps To Reproduce-
TagsNo tags attached.
Attached Filespatch file icon issue 40581 source mobilecore.patch [^] (2,038 bytes) 2019-05-16 09:05 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
blocks design defect 0038136 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 

-  Notes
(0112940)
hgbot (developer)
2019-06-21 13:18

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f1e3435ad7eb15c41ab268328d1991b2467327eb
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jun 21 13:06:32 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f1e3435ad7eb15c41ab268328d1991b2467327eb [^]

Fixed issue 40581:Query in SynchronizedServerProcessCaller not using bind-params

Refactored SynchronizedServerProcessCaller query to use bind parameters instead
of appending them to the query string directly.

---
M src/org/openbravo/mobile/core/servercontroller/SynchronizedServerProcessCaller.java
---
(0112971)
AugustoMauch (manager)
2019-06-24 12:06

Code reviewed and verified

- Issue History
Date Modified Username Field Change
2019-04-10 12:42 shuehner New Issue
2019-04-10 12:42 shuehner Assigned To => StoreServer
2019-04-10 12:42 shuehner Triggers an Emergency Pack => No
2019-04-10 12:42 shuehner Relationship added blocks 0038136
2019-05-13 12:45 shuehner Target Version => RR19Q3
2019-05-13 15:02 ranjith_qualiantech_com Assigned To StoreServer => ranjith_qualiantech_com
2019-05-14 11:06 ranjith_qualiantech_com Status new => scheduled
2019-05-16 08:56 ranjith_qualiantech_com Assigned To ranjith_qualiantech_com => AugustoMauch
2019-05-16 09:05 ranjith_qualiantech_com File Added: issue 40581 source mobilecore.patch
2019-06-21 11:34 jarmendariz Assigned To AugustoMauch => jarmendariz
2019-06-21 13:18 hgbot Checkin
2019-06-21 13:18 hgbot Note Added: 0112940
2019-06-21 13:18 hgbot Status scheduled => resolved
2019-06-21 13:18 hgbot Resolution open => fixed
2019-06-21 13:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f1e3435ad7eb15c41ab268328d1991b2467327eb [^]
2019-06-21 13:18 hgbot Checkin
2019-06-21 13:18 hgbot Note Added: 0112941
2019-06-21 13:18 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f1e3435ad7eb15c41ab268328d1991b2467327eb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/254b693f17e39f4c9be29a2af989bff0f7c5304f [^]
2019-06-21 13:22 jarmendariz Note Deleted: 0112941
2019-06-21 13:23 jarmendariz Review Assigned To => AugustoMauch
2019-06-24 12:06 AugustoMauch Note Added: 0112971
2019-06-24 12:06 AugustoMauch Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker