0040572: LoginUtilsServlet.preLogin is not using bind-parameters

Description

This code is not using bind-params:

OBQuery<TerminalAccess> accessCrit = OBDal.getInstance()
.createQuery(TerminalAccess.class, "where userContact.id='" + userId + "'");

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

design defect

0038136

acknowledged

Triage Platform Base

Openbravo ERP

Tracking issue: Find & Fix queries not using bind-params but embedding values into query string

Notes
(0111706) hgbot (developer) 2019-05-16 10:02	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: dda39b7861e1848be185af443bd02c61df521bcb Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu May 16 13:32:16 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dda39b7861e1848be185af443bd02c61df521bcb [^] Fixed issue 40572 : LoginUtilsServlet.preLogin is not using bind-parameters --- M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java ---

Issue History
Date Modified	Username	Field	Change
2019-04-10 11:28	shuehner	New Issue
2019-04-10 11:28	shuehner	Assigned To	=> Retail
2019-04-10 11:28	shuehner	Triggers an Emergency Pack	=> No
2019-04-10 11:28	shuehner	Relationship added	blocks 0038136
2019-05-13 12:44	shuehner	Target Version	=> RR19Q3
2019-05-13 13:56	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2019-05-14 11:06	ranjith_qualiantech_com	Status	new => scheduled
2019-05-16 10:02	hgbot	Checkin
2019-05-16 10:02	hgbot	Note Added: 0111706
2019-05-16 10:02	hgbot	Status	scheduled => resolved
2019-05-16 10:02	hgbot	Resolution	open => fixed
2019-05-16 10:02	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dda39b7861e1848be185af443bd02c61df521bcb [^]
2019-05-24 12:51	marvintm	Review Assigned To	=> marvintm
2019-05-24 12:51	marvintm	Status	resolved => closed
2019-05-24 12:51	marvintm	Fixed in Version	=> RR19Q3