Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040509
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discount Matrix Managementmajoralways2019-04-02 17:422019-04-15 13:35
ReporterngarciaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR19Q3
StatusclosedFix in branchFixed in SCM revision30be70babd07
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toadrianromero
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040509: Deleted orders go to Errors While Importing POS Data if they have a range discount approval

DescriptionDeleted orders go to Errors While Importing POS Data if they have a range discount approval.

The WRONG approval section includes the following:

"approvals": [{
    "approvalType": {
        "approval": "...",
        "message": "...",
        "params": ["..."]
    },
    "userContact": "...",
    "created": ...
}]

The RIGHT one is:

"approvals": [{
    "approvalType": "...",
    "userContact": "...",
    "created": ...,
    "approvalMessage": "..."
}]
Steps To ReproduceIn the backoffice:
   Set the 'Web POS Discount Matrix - Discount Approval' preference to Y for Openbravo user
   Set the 'Web POS Save Removed Tickets' preference to Y
   Set a Range Discount to VallBlancaUser:
      Discount from: 0
      Discount to: 100
      Approval required: Y

In the POS:
   Create a new ticket
   Add a product to it
   Reduce it's price
   Approve it with Openbravo user
   Delete the ticket

In the backoffice:
   Check the order is stuck in Errors While Importing POS Data with the following error message:
      org.openbravo.base.exception.OBException: Error in OrderLoader: approvalType: Property OBPOS_Order_Approval.approvalType only allows instances of java.lang.String but the value is an instanceof org.codehaus.jettison.json.JSONObject
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:443)
...
Caused by: org.openbravo.base.validation.ValidationException: approvalType: Property OBPOS_Order_Approval.approvalType only allows instances of java.lang.String but the value is an instanceof org.codehaus.jettison.json.JSONObject
    at org.openbravo.base.model.domaintype.BasePrimitiveDomainType.checkIsValidValue(BasePrimitiveDomainType.java:58)
...
TagsNo tags attached.
Attached Filespatch file icon issue 40509 source posterminal.patch [^] (1,227 bytes) 2019-04-03 14:54 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0039570 newRetail ERROR org.openbravo.mobile.core.process.DataSynchronizationProcess - approvalType 

-  Notes
(0111014)
hgbot (developer)
2019-04-08 11:38

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 30be70babd074d256f13ef5730ee94a42202137d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 08 15:08:29 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/30be70babd074d256f13ef5730ee94a42202137d [^]

Fixed issue 40509 : Update approval while deleting the receipt

* For custom approval message, approvalType will be json object instead of string.
  approvalType should be updated when deleting the receipt

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0111134)
adrianromero (manager)
2019-04-15 13:35

Verified

- Issue History
Date Modified Username Field Change
2019-04-02 17:42 ngarcia New Issue
2019-04-02 17:42 ngarcia Assigned To => Retail
2019-04-02 17:42 ngarcia Resolution time => 1555970400
2019-04-02 17:42 ngarcia Triggers an Emergency Pack => No
2019-04-02 17:43 ngarcia Relationship added related to 0039570
2019-04-02 18:11 ngarcia Issue Monitored: networkb
2019-04-03 12:58 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2019-04-03 12:59 ranjith_qualiantech_com Status new => scheduled
2019-04-03 14:54 ranjith_qualiantech_com File Added: issue 40509 source posterminal.patch
2019-04-08 11:38 hgbot Checkin
2019-04-08 11:38 hgbot Note Added: 0111014
2019-04-08 11:38 hgbot Status scheduled => resolved
2019-04-08 11:38 hgbot Resolution open => fixed
2019-04-08 11:38 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/30be70babd074d256f13ef5730ee94a42202137d [^]
2019-04-15 13:35 adrianromero Review Assigned To => adrianromero
2019-04-15 13:35 adrianromero Note Added: 0111134
2019-04-15 13:35 adrianromero Status resolved => closed
2019-04-15 13:35 adrianromero Fixed in Version => RR19Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker