Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0040509

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Discount Matrix Management

major

always

2019-04-02 17:42

2019-04-15 13:35

Reporter

ngarcia

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

urgent

Resolution

fixed

Fixed in Version

RR19Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

adrianromero

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0040509: Deleted orders go to Errors While Importing POS Data if they have a range discount approval

Description

Deleted orders go to Errors While Importing POS Data if they have a range discount approval.

The WRONG approval section includes the following:

"approvals": [{
    "approvalType": {
        "approval": "...",
        "message": "...",
        "params": ["..."]
    },
    "userContact": "...",
    "created": ...
}]

The RIGHT one is:

"approvals": [{
    "approvalType": "...",
    "userContact": "...",
    "created": ...,
    "approvalMessage": "..."
}]

Steps To Reproduce

In the backoffice:
   Set the 'Web POS Discount Matrix - Discount Approval' preference to Y for Openbravo user
   Set the 'Web POS Save Removed Tickets' preference to Y
   Set a Range Discount to VallBlancaUser:
      Discount from: 0
      Discount to: 100
      Approval required: Y

In the POS:
   Create a new ticket
   Add a product to it
   Reduce it's price
   Approve it with Openbravo user
   Delete the ticket

In the backoffice:
   Check the order is stuck in Errors While Importing POS Data with the following error message:
      org.openbravo.base.exception.OBException: Error in OrderLoader: approvalType: Property OBPOS_Order_Approval.approvalType only allows instances of java.lang.String but the value is an instanceof org.codehaus.jettison.json.JSONObject
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:443)
...
Caused by: org.openbravo.base.validation.ValidationException: approvalType: Property OBPOS_Order_Approval.approvalType only allows instances of java.lang.String but the value is an instanceof org.codehaus.jettison.json.JSONObject
    at org.openbravo.base.model.domaintype.BasePrimitiveDomainType.checkIsValidValue(BasePrimitiveDomainType.java:58)
...

Tags

No tags attached.

issue 40509 source posterminal.patch [^] (1,227 bytes) 2019-04-03 14:54 [Show Content] [Hide Content]

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1554296047 -19800
#      Wed Apr 03 18:24:07 2019 +0530
# Node ID efcfcfc7645ff876518dc556386e50c0add7417d
# Parent  90680f1d4d85876bbc87db2bcb2512321cd30414
Related to issue 40509 : Update approval while deleting the receipt

diff -r 90680f1d4d85 -r efcfcfc7645f web/org.openbravo.retail.posterminal/js/model/order.js
--- a/web/org.openbravo.retail.posterminal/js/model/order.js	Mon Apr 01 11:55:34 2019 +0000
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js	Wed Apr 03 18:24:07 2019 +0530
@@ -6171,6 +6171,12 @@
           model.get('lines').at(i).set('grossUnitPrice', 0);
           model.get('lines').at(i).set('lineGrossAmount', 0);
         }
+        model.get('approvals').forEach(function (approval) {
+          if (typeof (approval.approvalType) === 'object') {
+            approval.approvalMessage = OB.I18N.getLabel(approval.approvalType.message, approval.approvalType.params);
+            approval.approvalType = approval.approvalType.approval;
+          }
+        });
         model.set('hasbeenpaid', 'Y');
         OB.Dal.transaction(function (tx) {
           OB.UTIL.HookManager.executeHooks('OBPOS_PreSyncReceipt', {

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

new

ERROR org.openbravo.mobile.core.process.DataSynchronizationProcess - approvalType

Notes
(0111014) hgbot (developer) 2019-04-08 11:38	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 30be70babd074d256f13ef5730ee94a42202137d Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Apr 08 15:08:29 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/30be70babd074d256f13ef5730ee94a42202137d [^] Fixed issue 40509 : Update approval while deleting the receipt * For custom approval message, approvalType will be json object instead of string. approvalType should be updated when deleting the receipt --- M web/org.openbravo.retail.posterminal/js/model/order.js ---

(0111134) adrianromero (manager) 2019-04-15 13:35	Verified

Issue History
Date Modified	Username	Field	Change
2019-04-02 17:42	ngarcia	New Issue
2019-04-02 17:42	ngarcia	Assigned To	=> Retail
2019-04-02 17:42	ngarcia	Resolution time	=> 1555970400
2019-04-02 17:42	ngarcia	Triggers an Emergency Pack	=> No
2019-04-02 17:43	ngarcia	Relationship added	related to 0039570
2019-04-02 18:11	ngarcia	Issue Monitored: networkb
2019-04-03 12:58	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2019-04-03 12:59	ranjith_qualiantech_com	Status	new => scheduled
2019-04-03 14:54	ranjith_qualiantech_com	File Added: issue 40509 source posterminal.patch
2019-04-08 11:38	hgbot	Checkin
2019-04-08 11:38	hgbot	Note Added: 0111014
2019-04-08 11:38	hgbot	Status	scheduled => resolved
2019-04-08 11:38	hgbot	Resolution	open => fixed
2019-04-08 11:38	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/30be70babd074d256f13ef5730ee94a42202137d [^]
2019-04-15 13:35	adrianromero	Review Assigned To	=> adrianromero
2019-04-15 13:35	adrianromero	Note Added: 0111134
2019-04-15 13:35	adrianromero	Status	resolved => closed
2019-04-15 13:35	adrianromero	Fixed in Version	=> RR19Q3

Copyright © 2000 - 2009 MantisBT Group