Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0040502 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] StoreServer | major | always | 2019-04-01 14:44 | 2019-04-01 19:46 | |||
Reporter | aaroncalero | View Status | public | |||||
Assigned To | AugustoMauch | |||||||
Priority | high | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 7f1540d2d6ab | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | mtaal | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0040502: TransitionToOnline thread can leave open connections if the ReadOnly connection pool is used in a MobileServerTransitionToOnline | |||||||
Description | Using the DalConnectionProvider.getReadOnlyConnectionProvider() connection pool from a MobileServerTransitionToOnline can leave open connections after the TransitionToOnline has finished transitioning | |||||||
Steps To Reproduce | In a configured multiserver environment: Apply the attached patch in Mobile Core. Change the status of a server (i.e. the Centra Server) to offline and execute the Server State Background background process to force the transition to online. Once the process has finished and the server is online again, verify that there is still an open connection in the database, with the query shown in the patch. | |||||||
Proposed Solution | When the TransitionToOnline[1] thread finishes, it should close all open connections , just like it is done in the DalThreadHandler | |||||||
Tags | No tags attached. | |||||||
Attached Files | OpenTransaction_TransitionToOnline.diff [^] (960 bytes) 2019-04-01 14:44 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0110950) hgbot (developer) 2019-04-01 18:24 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 7f1540d2d6ab6611d1cfbff173c62338afa15ef3 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Apr 01 18:24:26 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7f1540d2d6ab6611d1cfbff173c62338afa15ef3 [^] Fixes issue 40502: Prevents connection leak during transition to offline/online The code that executes transitions to online/offline in a separate thread was making sure that the OBDal default connection was properly closed when the thread finishes. But it was missing to close the read only transaction. --- M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java --- |
(0110952) mtaal (manager) 2019-04-01 19:46 |
reviewed and tested |
Issue History | |||
Date Modified | Username | Field | Change |
2019-04-01 14:44 | aaroncalero | New Issue | |
2019-04-01 14:44 | aaroncalero | Assigned To | => StoreServer |
2019-04-01 14:44 | aaroncalero | File Added: OpenTransaction_TransitionToOnline.diff | |
2019-04-01 14:44 | aaroncalero | Resolution time | => 1555279200 |
2019-04-01 14:44 | aaroncalero | Triggers an Emergency Pack | => No |
2019-04-01 18:24 | hgbot | Checkin | |
2019-04-01 18:24 | hgbot | Note Added: 0110950 | |
2019-04-01 18:24 | hgbot | Status | new => resolved |
2019-04-01 18:24 | hgbot | Resolution | open => fixed |
2019-04-01 18:24 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7f1540d2d6ab6611d1cfbff173c62338afa15ef3 [^] |
2019-04-01 18:25 | AugustoMauch | Assigned To | StoreServer => AugustoMauch |
2019-04-01 18:25 | AugustoMauch | Review Assigned To | => mtaal |
2019-04-01 19:46 | mtaal | Note Added: 0110952 | |
2019-04-01 19:46 | mtaal | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |