0040461: Prepayment UI is being triggered even if we do not have the configuration active

Description

It is possible to arrive to an inconsistent state with prepayments even if the the POS Terminal type is not configured to use prepayments.

Steps To Reproduce

For this steps it is needed to have retail coupons installed.
-Backend
*Configure a coupon to use in the transaction
-Front End
*Add a product
*Add the coupon
*Press total and go to the payments tab
*Open the console in developers tools
*Remove the coupon from OB.MobileApp.model.receipt.get('coupons')
*Execute a OB.MobileApp.model.receipt.calculateReceipt()
*The UI will be a mix of the standard one and the one from PrePayments

Proposed Solution

Take into account the value of OB.MobileApp.model.get('terminal').terminalType.calculateprepayments in this piece of code:

      if (!receiptHasPrepaymentAmount) {
        this.$.prepaymentsbuttons.hide();
        this.$.exactbutton.show();
      } else {
        this.$.prepaymentsbuttons.show();
        this.$.exactbutton.hide();
      }

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0039925

closed

rqueralta

Prepayment UI is being triggered even if we do not have the configuration active

Notes
(0110956) hgbot (developer) 2019-04-01 22:40	Repository: retail/backports/3.0RR19Q1.1/org.openbravo.retail.posterminal Changeset: 8ca1108b0f513ca58ca25e8638acf6acdd3c0ac0 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Mon Apr 01 16:39:19 2019 -0400 URL: http://code.openbravo.com/retail/backports/3.0RR19Q1.1/org.openbravo.retail.posterminal/rev/8ca1108b0f513ca58ca25e8638acf6acdd3c0ac0 [^] Fixed issue 40461: Prepayment UI is being triggered even if we do not have the configuration active - Taked into account the value of property: OB.MobileApp.model.get('terminal').terminalType.calculateprepayments --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js ---

Issue History
Date Modified	Username	Field	Change
2019-03-26 16:50	marvintm	Type	defect => backport
2019-03-26 16:50	marvintm	Target Version	=> RR19Q1.1
2019-04-01 22:40	hgbot	Checkin
2019-04-01 22:40	hgbot	Note Added: 0110956
2019-04-01 22:40	hgbot	Status	scheduled => resolved
2019-04-01 22:40	hgbot	Resolution	open => fixed
2019-04-01 22:40	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/523fa8902cfacbf67745d96a4bffbbaf3aeaa8f1 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1.1/org.openbravo.retail.posterminal/rev/8ca1108b0f513ca58ca25e8638acf6acdd3c0ac0 [^]
2019-05-02 18:30	marvintm	Status	resolved => closed
2019-05-02 18:30	marvintm	Fixed in Version	=> RR19Q1.1