Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040461Retail ModulesWeb POSpublic2019-01-11 09:372019-05-02 18:30
Reporterjorgewederago 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q1.1Fixed in VersionRR19Q1.1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040461: Prepayment UI is being triggered even if we do not have the configuration active
DescriptionIt is possible to arrive to an inconsistent state with prepayments even if the the POS Terminal type is not configured to use prepayments.
Steps To ReproduceFor this steps it is needed to have retail coupons installed.
-Backend
*Configure a coupon to use in the transaction
-Front End
*Add a product
*Add the coupon
*Press total and go to the payments tab
*Open the console in developers tools
*Remove the coupon from OB.MobileApp.model.receipt.get('coupons')
*Execute a OB.MobileApp.model.receipt.calculateReceipt()
*The UI will be a mix of the standard one and the one from PrePayments
Proposed SolutionTake into account the value of OB.MobileApp.model.get('terminal').terminalType.calculateprepayments in this piece of code:

      if (!receiptHasPrepaymentAmount) {
        this.$.prepaymentsbuttons.hide();
        this.$.exactbutton.show();
      } else {
        this.$.prepaymentsbuttons.show();
        this.$.exactbutton.hide();
      }
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0039925 closed rqueralta Prepayment UI is being triggered even if we do not have the configuration active 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-03-26 16:50marvintmTypedefect => backport
2019-03-26 16:50marvintmTarget Version => RR19Q1.1
2019-04-01 22:40hgbotCheckin
2019-04-01 22:40hgbotNote Added: 0110956
2019-04-01 22:40hgbotStatusscheduled => resolved
2019-04-01 22:40hgbotResolutionopen => fixed
2019-04-01 22:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/523fa8902cfacbf67745d96a4bffbbaf3aeaa8f1 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1.1/org.openbravo.retail.posterminal/rev/8ca1108b0f513ca58ca25e8638acf6acdd3c0ac0 [^]
2019-05-02 18:30marvintmStatusresolved => closed
2019-05-02 18:30marvintmFixed in Version => RR19Q1.1

Notes
(0110956)
hgbot   
2019-04-01 22:40   
Repository: retail/backports/3.0RR19Q1.1/org.openbravo.retail.posterminal
Changeset: 8ca1108b0f513ca58ca25e8638acf6acdd3c0ac0
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Apr 01 16:39:19 2019 -0400
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1.1/org.openbravo.retail.posterminal/rev/8ca1108b0f513ca58ca25e8638acf6acdd3c0ac0 [^]

Fixed issue 40461: Prepayment UI is being triggered even if we do not have the
configuration active

- Taked into account the value of property:
OB.MobileApp.model.get('terminal').terminalType.calculateprepayments

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---