Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040340
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2019-03-08 10:312019-03-26 13:21
Reportersamuel_nicuesaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR19Q2
StatusclosedFix in branchFixed in SCM revision1c533d386e6e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040340: An exception may occur if the ticket contains lines with attributes

DescriptionAn exception may occur if the ticket contains lines with attributes
Steps To ReproduceI changed the function updateLinesWithAttributes adding some comments to force the error.

attr needs to be null in this point.

if (attr.equals("null")) {
        attr = null;
      }

Create a new ticket and pay it.

An exception will be thrown
Proposed SolutionWe need to remove this part of the code

if (attr.equals("null")) {
        attr = null;
      }

att has been initialized doing:

String attr = null;
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0110366)
hgbot (developer)
2019-03-12 06:40

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1c533d386e6e95337e56c84ab40b84d3f69590f5
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 12 11:10:03 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1c533d386e6e95337e56c84ab40b84d3f69590f5 [^]

Fixed issue 40340 : Validate JSON orderLines while completing the receipt

* "null" value should be validated for JSON orderLines

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0110548)
jorge-garcia (reporter)
2019-03-21 13:45

The fix is correct, but it could be improve if we not only check that a json has the property in jsonOrderLine, but we check also id its value is different from "null" (string null"). If we do that, we can avoid reset attr value to null again.
(0110576)
hgbot (developer)
2019-03-22 10:20

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9571ca0bd6b9427895aa4622f3ad7d3caeb29914
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Mar 22 14:50:19 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9571ca0bd6b9427895aa4622f3ad7d3caeb29914 [^]

Related to issue 40340 : Validate JSON orderLines while completing the receipt

* "null" value should be validated for JSON orderLines

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0110658)
jorge-garcia (reporter)
2019-03-26 13:21

Code reviewed and tested

- Issue History
Date Modified Username Field Change
2019-03-08 10:31 samuel_nicuesa New Issue
2019-03-08 10:31 samuel_nicuesa Assigned To => Retail
2019-03-08 10:31 samuel_nicuesa Resolution time => 1553814000
2019-03-08 10:31 samuel_nicuesa Triggers an Emergency Pack => No
2019-03-11 11:36 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2019-03-12 06:38 ranjith_qualiantech_com Status new => scheduled
2019-03-12 06:40 hgbot Checkin
2019-03-12 06:40 hgbot Note Added: 0110366
2019-03-12 06:40 hgbot Status scheduled => resolved
2019-03-12 06:40 hgbot Resolution open => fixed
2019-03-12 06:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1c533d386e6e95337e56c84ab40b84d3f69590f5 [^]
2019-03-21 13:45 jorge-garcia Note Added: 0110548
2019-03-21 13:45 jorge-garcia Status resolved => new
2019-03-21 13:45 jorge-garcia Resolution fixed => open
2019-03-21 13:45 jorge-garcia Review Assigned To => jorge-garcia
2019-03-22 09:57 ranjith_qualiantech_com Status new => scheduled
2019-03-22 10:20 hgbot Checkin
2019-03-22 10:20 hgbot Note Added: 0110576
2019-03-22 12:05 ranjith_qualiantech_com Status scheduled => resolved
2019-03-22 12:05 ranjith_qualiantech_com Resolution open => fixed
2019-03-26 13:21 jorge-garcia Note Added: 0110658
2019-03-26 13:21 jorge-garcia Status resolved => closed
2019-03-26 13:21 jorge-garcia Fixed in Version => RR19Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker