Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0040267

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS Hardware Manager

major

always

2019-02-25 12:34

2019-03-18 15:32

Reporter

malsasua

View Status

public

Assigned To

rqueralta

Priority

normal

Resolution

fixed

Fixed in Version

RR19Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0040267: Product images should not be sent in the json to Secure Gate server

Description

When one ticket is completed and Secure Gate server is enabled, it is included in the json the product images.

If the images are very large, the buffer in Secure Gate server can not be enough to load it.

Steps To Reproduce

[BO]
. configure Secure Gate functionality
. configure products with images

[POS]
. complete a bill
. the images are included in the json

Proposed Solution

Attached a possible solution

Tags

No tags attached.

diffRemoveImages.diff [^] (877 bytes) 2019-02-27 11:21 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/utils/rfidWebsocket.js b/web/org.openbravo.retail.posterminal/js/utils/rfidWebsocket.js
--- a/web/org.openbravo.retail.posterminal/js/utils/rfidWebsocket.js
+++ b/web/org.openbravo.retail.posterminal/js/utils/rfidWebsocket.js
@@ -295,7 +295,7 @@
   //Only if useSecurityGate check is enabled
   if (OB.POS.modelterminal.get('terminal').terminalType.useSecurityGate) {
     OB.UTIL.RfidController.waitForAck(function (uuid) {
-      OB.UTIL.RfidController.get('rfidWebsocket').send('send:' + uuid + ':' + JSON.stringify(order));
+      OB.UTIL.RfidController.get('rfidWebsocket').send('send:' + uuid + ':' + JSON.stringify(order.serializeToJSON()));
       OB.debug('sent processRemaingingCodes sent, UUID: ' + uuid);
     }, function () {
       OB.debug('send processRemainingCodes ended succesfully: ' + order.get('id'));

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0110410) hgbot (developer) 2019-03-13 15:05	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 7e10f0cb7043994b3ad0aa2436d7ba2a1e63b2c5 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Wed Mar 06 11:33:04 2019 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7e10f0cb7043994b3ad0aa2436d7ba2a1e63b2c5 [^] Fixed issue 40267: Product images should not be sent in the json to Secure Gate server - The order was serialized to json, to remove image from json sent to Secure Gate server --- M web/org.openbravo.retail.posterminal/js/utils/rfidWebsocket.js ---

Issue History
Date Modified	Username	Field	Change
2019-02-25 12:34	malsasua	New Issue
2019-02-25 12:34	malsasua	Assigned To	=> Retail
2019-02-25 12:34	malsasua	OBNetwork customer	=> Gold
2019-02-25 12:34	malsasua	Resolution time	=> 1552518000
2019-02-25 12:34	malsasua	Triggers an Emergency Pack	=> No
2019-02-25 17:25	rqueralta	Assigned To	Retail => rqueralta
2019-02-25 17:25	rqueralta	Status	new => scheduled
2019-02-27 11:21	malsasua	Proposed Solution updated
2019-02-27 11:21	malsasua	File Added: diffRemoveImages.diff
2019-03-13 15:05	hgbot	Checkin
2019-03-13 15:05	hgbot	Note Added: 0110410
2019-03-13 15:05	hgbot	Status	scheduled => resolved
2019-03-13 15:05	hgbot	Resolution	open => fixed
2019-03-13 15:05	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7e10f0cb7043994b3ad0aa2436d7ba2a1e63b2c5 [^]
2019-03-18 15:32	guilleaer	Review Assigned To	=> guilleaer
2019-03-18 15:32	guilleaer	Status	resolved => closed
2019-03-18 15:32	guilleaer	Fixed in Version	=> RR19Q2

Copyright © 2000 - 2009 MantisBT Group