Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0040199
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 03. Procurement managementmajoralways2019-02-14 14:242019-03-28 14:56
ReporterngarciaView Statuspublic 
Assigned Tomarkmm82 
PriorityurgentResolutionfixedFixed in Version3.0PR19Q2
StatusclosedFix in branchFixed in SCM revision5501b3c3b7bd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket8061
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040199: Line Net Amount of Invoice lines not rounded to standard precision if it is created from goods receipt and have a related order

DescriptionLine Net Amount of Invoice lines not rounded to standard precision if it is created from goods receipt and have a related order
Steps To ReproduceConfigure the Format.xml to accept 3 decimals in prices

As System admin role:
   Set EUR currency's price precision to 3

As group admin role:
   Create a new purchase order, add a line to it, set one unit of a product with a price of 3 decimals and book it
   Go to Pending Goods Receipt window and create the goods receipt from the order
   Go to Goods Receipt window and launch the 'Generate Invoice From Receipt' process

   Go to the Purchase Invoice and complete it
   Check through database that the linenetamt column has 3 decimals
Proposed SolutionThe problem is in the M_INOUT_CREATEINVOICE database function, in the following query line net amount is not being rounded:

SELECT COALESCE(MAX(PriceList), 0),
                COALESCE(MAX(PriceActual), 0),
                COALESCE(MAX(PriceLimit), 0),
                COALESCE(MAX(CUR_ShipmentLines.movementqty*priceactual),0),
                COALESCE(MAX(gross_unit_price), 0),
                COALESCE(MAX(line_gross_amount), 0),
                COALESCE(MAX(grosspricestd), 0),
                COALESCE(MAX(grosspricelist), 0),
                MAX(c_tax_id)
              INTO v_PriceList,
                v_PriceActual,
                v_PriceLimit,
                v_LineNetAmt,
                v_gross_unit_price,
                v_line_gross_amount,
                v_grosspricestd,
                v_grosspricelist,
                v_c_Tax_ID
              FROM C_ORDERLINE
              WHERE C_OrderLine_ID=CUR_ShipmentLines.C_OrderLine_ID;
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0109886)
markmm82 (viewer)
2019-02-18 05:04

 Test plan:
Configure the Format.xml to accept 3 decimals in prices

As System admin role:
   Set EUR currency's price precision to 3

As group admin role:
   Create a new purchase order, add a line to it, set one unit of a product with a price of 3 decimals and book it
   Go to Pending Goods Receipt window and create the goods receipt from the order
   Go to Goods Receipt window and launch the 'Generate Invoice From Receipt' process

   Go to the Purchase Invoice and complete it
   Check through database that the linenetamt column has 2 decimals
(0109887)
markmm82 (viewer)
2019-02-18 05:05

 Test plan 2:
Configure the Format.xml to accept 3 decimals in prices

As System admin role:
   Set EUR currency's price precision to 3
   Set EUR currency's standard precision to 3

As group admin role:
   Create a new purchase order, add a line to it, set one unit of a product with a price of 3 decimals and book it
   Go to Pending Goods Receipt window and create the goods receipt from the order
   Go to Goods Receipt window and launch the 'Generate Invoice From Receipt' process

   Go to the Purchase Invoice and complete it
    Check through database that the linenetamt column has 3 decimals
(0109929)
hgbot (developer)
2019-02-19 11:57

 Repository: erp/devel/pi
Changeset: 5501b3c3b7bd87b3155ad7c87c15fc0cd4358551
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Mon Feb 18 01:02:59 2019 -0300
URL: http://code.openbravo.com/erp/devel/pi/rev/5501b3c3b7bd87b3155ad7c87c15fc0cd4358551 [^]

Fixes issue 40199: Line Net Amount of Invoice lines rounded to std precision

Line Net Amount of Invoice lines was not rounded to standard precision if it is
created from goods receipt and have a related order.

Now it is rounded to the standard precision of the currency.

---
M src-db/database/model/functions/M_INOUT_CREATEINVOICE.xml
---
(0109930)
Sandrahuguet (viewer)
2019-02-19 11:57

 Code review + testing OK
(0110823)
hudsonbot (viewer)
2019-03-28 14:56

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2019-02-14 14:24 ngarcia New Issue
2019-02-14 14:24 ngarcia Assigned To => Triage Finance
2019-02-14 14:24 ngarcia OBNetwork customer => OBPS
2019-02-14 14:24 ngarcia Modules => Core
2019-02-14 14:24 ngarcia Support ticket => 8061
2019-02-14 14:24 ngarcia Resolution time => 1551913200
2019-02-14 14:24 ngarcia Triggers an Emergency Pack => No
2019-02-14 14:27 ngarcia Proposed Solution updated
2019-02-14 14:27 ngarcia Issue Monitored: networkb
2019-02-14 15:21 Sandrahuguet Assigned To Triage Finance => markmm82
2019-02-15 04:19 markmm82 Status new => scheduled
2019-02-18 05:04 markmm82 Note Added: 0109886
2019-02-18 05:05 markmm82 Note Added: 0109887
2019-02-19 11:57 hgbot Checkin
2019-02-19 11:57 hgbot Note Added: 0109929
2019-02-19 11:57 hgbot Status scheduled => resolved
2019-02-19 11:57 hgbot Resolution open => fixed
2019-02-19 11:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5501b3c3b7bd87b3155ad7c87c15fc0cd4358551 [^]
2019-02-19 11:57 Sandrahuguet Review Assigned To => Sandrahuguet
2019-02-19 11:57 Sandrahuguet Note Added: 0109930
2019-02-19 11:57 Sandrahuguet Status resolved => closed
2019-02-19 11:57 Sandrahuguet Fixed in Version => 3.0PR19Q2
2019-03-28 14:56 hudsonbot Checkin
2019-03-28 14:56 hudsonbot Note Added: 0110823

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker