0040112: The callbacks of a calculateReceipt are executed with the calculateReceipt process set

Description

When the callbacks of a calculate receipt are executed, those executions are made with the process controller of the calculateReceipt set. The process should finish and them the callbacks should be called.

This also occurred for the calculatingReceipt property.

Those properties should be set before calling to the callbacks, copying the calculateReceiptCallbacks to a new array and unsetting it. In this way, if one of the callbacks executes the calculate receipt when all the callbacks haven't been executed, those new callbacks won't be set to the same array.

Steps To Reproduce

Add a line in the Web POS and debug the code.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0039950

closed

ranjith_qualiantech_com

The callbacks of a calculateReceipt are executed with the calculateReceipt process set

Notes
(0109704) hgbot (developer) 2019-02-12 12:23	Repository: retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal Changeset: 6c33f298453eeff85a9b546730332e4065240501 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Feb 12 16:52:31 2019 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/6c33f298453eeff85a9b546730332e4065240501 [^] Fixed issue 40112 : Changes in calculateReceipt callback functions * If calculateReceipt is presents inside callback of calculateReceipt, callback should be called when the calculateReceipt process is completed --- M web/org.openbravo.retail.posterminal/js/model/order.js ---

(0110239) jorge-garcia (viewer) 2019-03-05 17:35	Code reviewed and tested

Issue History
Date Modified	Username	Field	Change
2019-02-04 09:16	marvintm	Type	defect => backport
2019-02-04 09:16	marvintm	Target Version	=> RR19Q1
2019-02-12 12:23	hgbot	Checkin
2019-02-12 12:23	hgbot	Note Added: 0109704
2019-02-12 12:23	hgbot	Status	scheduled => resolved
2019-02-12 12:23	hgbot	Resolution	open => fixed
2019-02-12 12:23	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6a36d470afb3d679175071bb3ef645bd2771a7b0 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/6c33f298453eeff85a9b546730332e4065240501 [^]
2019-03-05 17:35	jorge-garcia	Review Assigned To	=> jorge-garcia
2019-03-05 17:35	jorge-garcia	Note Added: 0110239
2019-03-05 17:35	jorge-garcia	Status	resolved => closed