Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0040008

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2019-01-23 12:14

2019-02-13 09:31

Reporter

guillermogil

View Status

public

Assigned To

rqueralta

Priority

normal

Resolution

fixed

Fixed in Version

RR19Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

Regression level

QA functional test

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0040008: Triggers are disabled for Payment Creation in Cancel Layaway

Description

Triggers are disabled for Payment Creation in Cancel Layaway
It is needed to have them enabled

Steps To Reproduce

Create a layaway
Pay it
Load the layaway
Cancel it

You will see that triggers are disabled for the payment creation

Proposed Solution

See patch attached

Tags

No tags attached.

40008.diff [^] (902 bytes) 2019-01-23 12:14 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/CancelLayawayLoader.java b/src/org/openbravo/retail/posterminal/CancelLayawayLoader.java
--- a/src/org/openbravo/retail/posterminal/CancelLayawayLoader.java
+++ b/src/org/openbravo/retail/posterminal/CancelLayawayLoader.java
@@ -114,12 +114,16 @@
       OBDal.getInstance().save(inverseOrder);
       OBDal.getInstance().save(oldOrder);
 
-      handlePayments(json, inverseOrder);
+      OBDal.getInstance().flush();
 
+      try {
+        TriggerHandler.getInstance().enable();
+        handlePayments(json, inverseOrder);
+      } finally {
+        TriggerHandler.getInstance().disable();
+      }
       POSUtils.setDefaultPaymentType(json, inverseOrder);
 
-      OBDal.getInstance().flush();
-
       CancelAndReplaceUtils.cancelOrder(json.getString("orderid"), json,
           useOrderDocumentNoForRelatedDocs);
     } catch (Exception ex) {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0109681) hgbot (developer) 2019-02-11 20:58	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: df9125b4a0cfd563bddd0499c786fe1328021c8b Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Wed Feb 06 00:05:24 2019 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/df9125b4a0cfd563bddd0499c786fe1328021c8b [^] Fixed issue 40008: Triggers are disabled for Payment Creation in Cancel Layaway - Enable triggers before call handlePayments function --- M src/org/openbravo/retail/posterminal/CancelLayawayLoader.java ---

Issue History
Date Modified	Username	Field	Change
2019-01-23 12:14	guillermogil	New Issue
2019-01-23 12:14	guillermogil	Assigned To	=> Retail
2019-01-23 12:14	guillermogil	OBNetwork customer	=> Gold
2019-01-23 12:14	guillermogil	Resolution time	=> 1549753200
2019-01-23 12:14	guillermogil	Regression level	=> QA functional test
2019-01-23 12:14	guillermogil	Triggers an Emergency Pack	=> No
2019-01-23 12:14	guillermogil	File Added: 40008.diff
2019-01-23 15:11	rqueralta	Assigned To	Retail => rqueralta
2019-01-23 15:11	rqueralta	Status	new => scheduled
2019-02-11 20:58	hgbot	Checkin
2019-02-11 20:58	hgbot	Note Added: 0109681
2019-02-11 20:58	hgbot	Status	scheduled => resolved
2019-02-11 20:58	hgbot	Resolution	open => fixed
2019-02-11 20:58	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/df9125b4a0cfd563bddd0499c786fe1328021c8b [^]
2019-02-13 09:31	marvintm	Review Assigned To	=> marvintm
2019-02-13 09:31	marvintm	Status	resolved => closed
2019-02-13 09:31	marvintm	Fixed in Version	=> RR19Q2

Copyright © 2000 - 2009 MantisBT Group