0039781: It should not be possible to process shipments from a layaway line

diff -r f8cca12f16b4 src-db/database/model/functions/OBPOS_DELIVER_LAYAWAY.xml --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/src-db/database/model/functions/OBPOS_DELIVER_LAYAWAY.xml Mon Dec 10 17:52:37 2018 +0100 @@ -0,0 +1,61 @@ +<?xml version="1.0"?> + <database name="FUNCTION OBPOS_DELIVER_LAYAWAY"> + <function name="OBPOS_DELIVER_LAYAWAY" type="NULL"> + <parameter name="p_ep_instance_id" type="VARCHAR" mode="in"> + <default/> + </parameter> + <body><![CDATA[/************************************************************************* +* The contents of this file are subject to the Openbravo Public License +* Version 1.1 (the "License"), being the Mozilla Public License +* Version 1.1 with a permitted attribution clause; you may not use this +* file except in compliance with the License. You may obtain a copy of +* the License at http://www.openbravo.com/legal/license.html +* Software distributed under the License is distributed on an "AS IS" +* basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the +* License for the specific language governing rights and limitations +* under the License. +* The Original Code is Openbravo ERP. +* The Initial Developer of the Original Code is Openbravo SLU +* All portions are Copyright (C) 2018 Openbravo SLU +* All Rights Reserved. +* Contributor(s): ______________________________________. +************************************************************************/ + +p_record_id M_INOUT.M_INOUT_ID%TYPE; +p_docAction M_INOUT.DocAction%TYPE; + +TYPE RECORD IS REF CURSOR; +Cur_Params RECORD; +Cur_Orders RECORD; + +BEGIN + + FOR Cur_Params IN ( + SELECT * + FROM ad_ep_instance_para + WHERE ad_ep_instance_id = p_ep_instance_id + ) LOOP + IF (cur_params.parametername LIKE 'DocAction') THEN + p_docaction := Cur_Params.p_string; + ELSIF (cur_params.parametername LIKE 'Record_ID') THEN + p_record_id := cur_params.p_string; + END IF; + END LOOP; + IF(p_docaction = 'CO') THEN + FOR Cur_Orders IN ( + select c_order.c_order_id + from c_order + join c_orderline on c_order.c_order_id = c_orderline.c_order_id + join m_inoutline on m_inoutline.c_orderline_id = c_orderline.c_orderline_id + join m_inout on m_inoutline.m_inout_id = m_inout.m_inout_id + where c_order.em_obpos_islayaway = 'Y' + and m_inout.docstatus = 'CO' + and m_inoutline.m_inout_id = p_record_id + ) LOOP + RAISE_APPLICATION_ERROR(-20000, '@OBPOS_Layaway_No_Shipment@'); + END LOOP; + END IF; +END OBPOS_DELIVER_LAYAWAY +]]></body> + </function> + </database> diff -r f8cca12f16b4 src-db/database/sourcedata/AD_EP_PROCEDURES.xml --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/src-db/database/sourcedata/AD_EP_PROCEDURES.xml Mon Dec 10 17:52:37 2018 +0100 @@ -0,0 +1,14 @@ +<?xml version='1.0' encoding='UTF-8'?> +<data> +<AD_EP_PROCEDURES> + <AD_EP_PROCEDURES_ID><![CDATA[C5C0FE1D66DF46C38CF2BCFF7616B5C4]]></AD_EP_PROCEDURES_ID> + <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID> + <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID> + <ISACTIVE><![CDATA[Y]]></ISACTIVE> + <AD_EXTENSION_POINTS_ID><![CDATA[5A7C6972321E42C2A5A8E9D6D73E6A7C]]></AD_EXTENSION_POINTS_ID> + <PROCEDURENAME><![CDATA[obpos_deliver_layaway]]></PROCEDURENAME> + <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID> + <SEQNO><![CDATA[100]]></SEQNO> +</AD_EP_PROCEDURES> + +</data> diff -r f8cca12f16b4 src-db/database/sourcedata/AD_MESSAGE.xml --- a/src-db/database/sourcedata/AD_MESSAGE.xml Tue Nov 27 00:05:46 2018 +0100 +++ b/src-db/database/sourcedata/AD_MESSAGE.xml Mon Dec 10 17:52:37 2018 +0100 @@ -1213,6 +1213,18 @@  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N> </AD_MESSAGE> +<AD_MESSAGE> + <AD_MESSAGE_ID><![CDATA[1BEFCB7DB44149D3A89F4874ACE0A54C]]></AD_MESSAGE_ID> + <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID> + <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID> + <ISACTIVE><![CDATA[Y]]></ISACTIVE> + <VALUE><![CDATA[OBPOS_Layaway_No_Shipment]]></VALUE> + <MSGTEXT><![CDATA[You can not deliver a layaway]]></MSGTEXT> + <MSGTYPE><![CDATA[E]]></MSGTYPE> + <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID> + <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N> +</AD_MESSAGE> + <AD_MESSAGE>  <AD_MESSAGE_ID><![CDATA[1C5F42C87F1340E5938E340D8E312E1A]]></AD_MESSAGE_ID>  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>

Notes
(0108773) hgbot (developer) 2018-12-28 09:24	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6b138c1d3639793e442cc3f1ebb93ddc40a2905d Author: Mark <markmm82 <at> gmail.com> Date: Thu Dec 27 11:07:03 2018 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b138c1d3639793e442cc3f1ebb93ddc40a2905d [^] Fixes issue 39781: It isn't possible to process shipments from a layaway line When creating a Goods Shipment lines by the Create Lines From process, it was possible to include layaway orderline. It should not be possible to process shipments from a layaway line. To fix this, was added a new extension point to the obpos_deliver_layaway to raise an error when was created a shipment from a layaway line. --- M src-db/database/sourcedata/AD_MESSAGE.xml A src-db/database/model/functions/OBPOS_DELIVER_LAYAWAY.xml A src-db/database/sourcedata/AD_EP_PROCEDURES.xml ---

(0108774) Sandrahuguet (viewer) 2018-12-28 09:24	Code review + testing OK

(0108777) hgbot (developer) 2018-12-28 11:04	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ea5abf22f6878a06f67cb7f9cab129f09e24f18e Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Fri Dec 28 11:04:44 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea5abf22f6878a06f67cb7f9cab129f09e24f18e [^] related to issue 39781 Backed out changeset 6b138c1d3639 --- M src-db/database/sourcedata/AD_MESSAGE.xml R src-db/database/model/functions/OBPOS_DELIVER_LAYAWAY.xml R src-db/database/sourcedata/AD_EP_PROCEDURES.xml ---

(0108782) hgbot (developer) 2018-12-28 14:24	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 0ce0f642657faea48784888b3094165756bd2588 Author: Mark <markmm82 <at> gmail.com> Date: Thu Dec 27 11:07:03 2018 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0ce0f642657faea48784888b3094165756bd2588 [^] Fixes issue 39781: It isn't possible to process shipments from a layaway line When creating a Goods Shipment lines by the Create Lines From process, it was possible to include layaway orderline. It should not be possible to process shipments from a layaway line. To fix this, was added a new extension point to the obpos_deliver_layaway to raise an error when was created a shipment from a layaway line. --- M src-db/database/sourcedata/AD_MESSAGE.xml A src-db/database/model/functions/OBPOS_DELIVER_LAYAWAY.xml A src-db/database/sourcedata/AD_EP_PROCEDURES.xml ---

(0108783) hgbot (developer) 2018-12-28 14:24	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d89ccc877c0718e0fe57867d5a5b1cbfe4c44d77 Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Fri Dec 28 12:20:32 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d89ccc877c0718e0fe57867d5a5b1cbfe4c44d77 [^] related to issue 39781 code review changes --- M src-db/database/model/functions/OBPOS_DELIVER_LAYAWAY.xml M src-db/database/sourcedata/AD_MESSAGE.xml ---

(0108784) Sandrahuguet (viewer) 2018-12-28 14:24	code review + testing ok

Issue History
Date Modified	Username	Field	Change
2018-12-11 16:08	Sandrahuguet	New Issue
2018-12-11 16:08	Sandrahuguet	Assigned To	=> Sandrahuguet
2018-12-11 16:08	Sandrahuguet	OBNetwork customer	=> No
2018-12-11 16:08	Sandrahuguet	Triggers an Emergency Pack	=> No
2018-12-11 16:09	Sandrahuguet	File Added: ExtensionPoint_M_INOUT_POST.diff
2018-12-12 12:41	Sandrahuguet	Assigned To	Sandrahuguet => markmm82
2018-12-27 16:52	markmm82	Status	new => scheduled
2018-12-28 09:24	hgbot	Checkin
2018-12-28 09:24	hgbot	Note Added: 0108773
2018-12-28 09:24	hgbot	Status	scheduled => resolved
2018-12-28 09:24	hgbot	Resolution	open => fixed
2018-12-28 09:24	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b138c1d3639793e442cc3f1ebb93ddc40a2905d [^]
2018-12-28 09:24	Sandrahuguet	Review Assigned To	=> Sandrahuguet
2018-12-28 09:24	Sandrahuguet	Note Added: 0108774
2018-12-28 09:24	Sandrahuguet	Status	resolved => closed
2018-12-28 09:24	Sandrahuguet	Fixed in Version	=> RR19Q1
2018-12-28 11:04	hgbot	Checkin
2018-12-28 11:04	hgbot	Note Added: 0108777
2018-12-28 12:10	Sandrahuguet	Status	closed => new
2018-12-28 12:10	Sandrahuguet	Resolution	fixed => open
2018-12-28 12:10	Sandrahuguet	Fixed in Version	RR19Q1 =>
2018-12-28 14:24	hgbot	Checkin
2018-12-28 14:24	hgbot	Note Added: 0108782
2018-12-28 14:24	hgbot	Status	new => resolved
2018-12-28 14:24	hgbot	Resolution	open => fixed
2018-12-28 14:24	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b138c1d3639793e442cc3f1ebb93ddc40a2905d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0ce0f642657faea48784888b3094165756bd2588 [^]
2018-12-28 14:24	hgbot	Checkin
2018-12-28 14:24	hgbot	Note Added: 0108783
2018-12-28 14:24	Sandrahuguet	Note Added: 0108784
2018-12-28 14:24	Sandrahuguet	Status	resolved => closed
2018-12-28 14:24	Sandrahuguet	Fixed in Version	=> RR19Q1

Relationships [ Relation Graph ] [ Dependency Graph ]