Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0039710 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | major | always | 2018-11-28 15:01 | 2018-12-13 15:31 | |||
| Reporter | joniturralde93 | View Status | public | |||||
| Assigned To | AtulOpenbravo | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR19Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 29bb5d02e0fe | ||||
| Projection | none | ETA | none | Target Version | pi | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | Sandrahuguet | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0039710: Landed cost can be reactivated TWICE | |||||||
| Description | Landed cost can be reactivated twice if done at the exact same time in two different sessions. This cannot be fixed in any way by the user. | |||||||
| Steps To Reproduce | - Go to https://livebuilds.openbravo.com/erp_pi_pgsql/ [^] - Open Landed Cost Type window - Create a new record: Organization=*, Name=Capital Social, Account=Capital Social - Open Landed Cost window - Create a new record: Organization=F&B España - Región Norte, Document Type=Landed Cost - Create a new record in subtab Cost: Document Type=Landed Cost Cost, Landed Cost Type=Capital Social, Amount=200 - Create a new record in subtab Receipt: Goods Receipt=10000111 - 27-03-2013 - Refrescos Naturales, S.A - Click on Landed Cost header and press Process button. - Now navigate to the Goods Receipt assigned to the Receipt subtab: 10000111 - 27-03-2013 - Refrescos Naturales, S.A - Open a line (Bebida Energética 0.5L) and go to Linked Items - Open the record on Master Data Management || Product - Transactions - You can check that, in subtab Transaction Costs, it was added a line which increases the amount. - Now, go back to the created Landed Cost and reactivate it from two different sessions at the same exact time (you have a 1 second window or so, we reproduced it with two different laptops) - Go back to the Product-Transactions-Transaction Costs subtab. - Usually, this 'Reactivate' button creates another line with negative amount, but this way it created two (this cannot be fixed in any way). | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0108523) AtulOpenbravo (developer) 2018-12-12 05:56 edited on: 2018-12-12 06:02 |
- Login as F&B International Group Admin. - Open Landed Cost Type window - Create a new record: Organization=*, Name=Capital Social, Account=Capital Social - Open Landed Cost window - Create a new record: Organization=F&B España - Región Norte, Document Type=Landed Cost - Create a new record in subtab Cost: Document Type=Landed Cost Cost, Landed Cost Type=Capital Social, Amount=200 - Create a new record in subtab Receipt: Goods Receipt=10000111 - 27-03-2013- Refrescos Naturales, S.A, Receipt Line: 10000111 - 27-03-2013 - Refrescos Naturales, S.A. - 20 - Bebida Energética 0,5L - 10000.00 - Click on Landed Cost header, click process button and wait. - Open a other browser or new incognito window. - Login and open same landed cost record, click process button and wait. - Try to click Done button in both browser parrallely. - One browser shows "Process Completely successfully" and other shows error "Another Process for this record is active, please unlock it" message. - Now in the similar way try to reactivate Landed Cost from two different browser or incognito window. - In one browser document is reactivated successfully and in the other one error is shown as "Another Process for this record is active, please unlock it". |
|
(0108577) hgbot (developer) 2018-12-13 11:11 |
Repository: erp/devel/pi Changeset: 29bb5d02e0fee1713c731f8e7eb108f3608b4c19 Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Thu Dec 13 00:01:44 2018 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/29bb5d02e0fee1713c731f8e7eb108f3608b4c19 [^] Fixes Issue 0039710: Landed cost can be reactivated TWICE ** Inorder to avoid process or reactivate twice, processing flag is used for locking mechanism. At the beginning check is done whether the flag is checked, if yes error is shown else flag is set as Yes and process or reactivate action proceeds. At the end flag is reset as No. ** Checking of processed flag or document status (Draft) is also done while reactivation process whether the landed cost is reactivated by other process. --- M src/org/openbravo/costing/LandedCostProcessHandler.java M src/org/openbravo/costing/ReactivateLandedCost.java --- |
|
(0108578) Sandrahuguet (developer) 2018-12-13 11:15 |
Code review + testing OK |
|
(0108588) hudsonbot (developer) 2018-12-13 15:31 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cc7720ccbe48 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-11-28 15:01 | joniturralde93 | New Issue | |
| 2018-11-28 15:01 | joniturralde93 | Assigned To | => Triage Finance |
| 2018-11-28 15:01 | joniturralde93 | Modules | => Core |
| 2018-11-28 15:01 | joniturralde93 | Resolution time | => 1545174000 |
| 2018-11-28 15:01 | joniturralde93 | Triggers an Emergency Pack | => No |
| 2018-11-28 15:10 | martinsdan | Issue Monitored: martinsdan | |
| 2018-11-28 15:15 | Sandrahuguet | Assigned To | Triage Finance => AtulOpenbravo |
| 2018-11-28 17:20 | AtulOpenbravo | Status | new => scheduled |
| 2018-12-12 05:56 | AtulOpenbravo | Note Added: 0108523 | |
| 2018-12-12 06:02 | AtulOpenbravo | Note Edited: 0108523 | View Revisions |
| 2018-12-12 13:16 | ngarcia | Issue Monitored: ngarcia | |
| 2018-12-13 11:11 | hgbot | Checkin | |
| 2018-12-13 11:11 | hgbot | Note Added: 0108577 | |
| 2018-12-13 11:11 | hgbot | Status | scheduled => resolved |
| 2018-12-13 11:11 | hgbot | Resolution | open => fixed |
| 2018-12-13 11:11 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/29bb5d02e0fee1713c731f8e7eb108f3608b4c19 [^] |
| 2018-12-13 11:15 | Sandrahuguet | Review Assigned To | => Sandrahuguet |
| 2018-12-13 11:15 | Sandrahuguet | Note Added: 0108578 | |
| 2018-12-13 11:15 | Sandrahuguet | Status | resolved => closed |
| 2018-12-13 11:15 | Sandrahuguet | Fixed in Version | => 3.0PR19Q1 |
| 2018-12-13 15:31 | hudsonbot | Checkin | |
| 2018-12-13 15:31 | hudsonbot | Note Added: 0108588 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |