Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039675
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Sessionsmajorhave not tried2018-11-22 11:472018-12-13 10:42
ReportermalsasuaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR19Q1
StatusclosedFix in branchFixed in SCM revisionb584bce4a3a2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039675: Business date is changed when login offline is done

Descriptionwhen login offline is done, the business date is retrieved from terminal info stored in local database, and it could not be updated to the last business date.
Steps To Reproduce[BO]
. open store -> business date d1
[POS]
. login online user1 ->
    message-> "business date will be changed to d1 is displayed"
           -> the business date in local storage is set to d1
. cashup & logout
. login online user2
. cashup & logout
[BO]
. close store
. open store-> business date d2
[POS]
. login online user1 ->
    message-> "business date will be changed to d2 is displayed"
           -> the business date in local storage is set to d2
. cashup & logout
. login OFFLINE user2
    message-> "business date will be changed to d1 is displayed"
           -> the business date in local storage is set to d1
. cashup & logout

It happens because in login Offline, the business date is retrieved from Terminal info, stored in local database in the table user, and user2 Terminal info is not updated with business date d2.
Proposed SolutionIn this line:
if (!OB.UTIL.isNullOrUndefined(OB.UTIL.localStorage.getItem('businessdate')) && (new Date(OB.UTIL.localStorage.getItem('businessdate')).setHours(0, 0, 0, 0) < new Date(OB.POS.modelterminal.get('terminal').poss_businessdate).setHours(0, 0, 0, 0) || new Date(OB.UTIL.localStorage.getItem('businessdate')).setHours(0, 0, 0, 0) > new Date(OB.POS.modelterminal.get('terminal').poss_businessdate).setHours(0, 0, 0, 0))) {
        var onHidePopup = function() {
...

if you are offline, the business date should not be retrieved from Terminal.

Also, should be added log traces, when business date is set in the terminal, so, we can check what business date has been assigned by cashier
TagsNo tags attached.
Attached Filesdiff file icon fixReturn.diff [^] (379 bytes) 2018-11-28 18:12 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0108072)
hgbot (developer)
2018-11-23 09:55

 Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: f5dfdd235e7014b1e6f1b6a883f0b1dd4429c633
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Nov 23 14:24:58 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/f5dfdd235e7014b1e6f1b6a883f0b1dd4429c633 [^]

Related to issue 39675 : Removed unnecessary condition while checking Business date

* For offline mode, its not necessary to check the terminal is correctly loaded

---
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0108160)
samuel_nicuesa (developer)
2018-11-28 18:11

 Is necessary to add return line (see fixReturn.diff) file
(0108311)
hgbot (developer)
2018-12-06 11:05

 Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: b584bce4a3a27ad33d649feafb94bf699bdbba49
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 06 15:35:15 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/b584bce4a3a27ad33d649feafb94bf699bdbba49 [^]

Fixed issue 39675 : Added return statement while checking business date with localstorage in offline mode

---
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---

- Issue History
Date Modified Username Field Change
2018-11-22 11:47 malsasua New Issue
2018-11-22 11:47 malsasua Assigned To => Retail
2018-11-22 11:47 malsasua Resolution time => 1544396400
2018-11-22 11:47 malsasua Triggers an Emergency Pack => No
2018-11-22 12:03 malsasua Resolution time 1544396400 => 1543100400
2018-11-22 12:29 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2018-11-22 12:29 ranjith_qualiantech_com Status new => scheduled
2018-11-23 09:26 rafaroda Issue Monitored: rafaroda
2018-11-23 09:55 hgbot Checkin
2018-11-23 09:55 hgbot Note Added: 0108072
2018-11-25 11:51 ranjith_qualiantech_com Status scheduled => resolved
2018-11-25 11:51 ranjith_qualiantech_com Resolution open => fixed
2018-11-28 18:11 samuel_nicuesa Note Added: 0108160
2018-11-28 18:12 samuel_nicuesa File Added: fixReturn.diff
2018-12-04 13:26 marvintm Status resolved => new
2018-12-04 13:26 marvintm Resolution fixed => open
2018-12-04 13:26 marvintm Resolution time 1543100400 => 1545001200
2018-12-05 12:51 ranjith_qualiantech_com Status new => scheduled
2018-12-06 11:05 hgbot Checkin
2018-12-06 11:05 hgbot Note Added: 0108311
2018-12-06 11:05 hgbot Status scheduled => resolved
2018-12-06 11:05 hgbot Resolution open => fixed
2018-12-06 11:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/b584bce4a3a27ad33d649feafb94bf699bdbba49 [^]
2018-12-13 10:42 marvintm Review Assigned To => marvintm
2018-12-13 10:42 marvintm Status resolved => closed
2018-12-13 10:42 marvintm Fixed in Version => RR19Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker