0039656: Print last receipt is not working, it is showing message "It has not processed any orders yet"

diff --git a/web/org.openbravo.retail.printlast/js/printLastButton.js b/web/org.openbravo.retail.printlast/js/printLastButton.js
--- a/web/org.openbravo.retail.printlast/js/printLastButton.js
+++ b/web/org.openbravo.retail.printlast/js/printLastButton.js
@@ -41,8 +41,10 @@
     },
     init: function (model) {
       this.model = model;
-      this.model.get('order').on('integrityOk', function () {
-        OB.UTIL.clone(this.model.get('order'), this.lastOrder);
+      this.model.get('order').on('integrityOk', function (order) {
+        if (!_.isEqual(this.lastOrder, order)) {
+          OB.UTIL.clone(order, this.lastOrder);
+        }
       }, this);
       this.model.get('multiOrders').on('integrityOk', function (order) {
         if (!_.isEqual(this.lastOrder, order)) {

diff --git a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js
--- a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js
@@ -272,7 +272,7 @@
 
                 syncSuccessCallback = function () {
                   // the trigger is fired on the receipt object, as there is only 1 that is being updated
-                  receipt.trigger('integrityOk'); // Is important for module print last receipt. This module listen trigger.
+                  receipt.trigger('integrityOk', frozenReceipt); // Is important for module print last receipt. This module listen trigger.
                   if (OB.UTIL.HookManager.get('OBPOS_PostSyncReceipt')) {
                     OB.UTIL.HookManager.executeHooks('OBPOS_PostSyncReceipt', {
                       receipt: receiptForPostSyncReceipt,
@@ -303,7 +303,7 @@
 
                 if (!OB.MobileApp.model.hasPermission('OBMOBC_SynchronizedMode', true)) {
                   // the trigger is fired on the receipt object, as there is only 1 that is being updated
-                  receipt.trigger('integrityOk'); // Is important for module print last receipt. This module listen trigger.  
+                  receipt.trigger('integrityOk', frozenReceipt); // Is important for module print last receipt. This module listen trigger.  
                   closeParamCallback();
                 }
 

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1548669159 -19800
#      Mon Jan 28 15:22:39 2019 +0530
# Node ID e795e1f4ea2d929bb4f452cc0ff88c956d9193ca
# Parent  f538aea3dad0b25b32f1b98ae3c8d937d7015151
Related to issue 39656 RR18Q3 : Receipt integrityOk must be trigger with param final receipt to avoid receipt model changes

* While Closing the receipt, PostSyncReceipt hook must be called in both Synchronized and other

diff -r f538aea3dad0 -r e795e1f4ea2d web/org.openbravo.retail.posterminal/js/data/dataordersave.js
--- a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js	Tue Aug 07 09:23:07 2018 +0000
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js	Mon Jan 28 15:22:39 2019 +0530
@@ -1,6 +1,6 @@
 /*
  ************************************************************************************
- * Copyright (C) 2013-2018 Openbravo S.L.U.
+ * Copyright (C) 2013-2019 Openbravo S.L.U.
  * Licensed under the Openbravo Commercial License version 1.0
  * You may obtain a copy of the License at http://www.openbravo.com/legal/obcl.html
  * or in the legal folder of this module distribution.
@@ -219,10 +219,21 @@
 
           var successCallback = function () {
 
+              var syncSuccessCallback, syncErrorCallback, closeParamCallback, restoreReceiptCallback, serverMessageForQuotation, receiptForPostSyncReceipt;
+
               // success transaction...
               OB.info("[receipt.closed] Transaction success. ReceiptId: " + receipt.get('id'));
 
-              function serverMessageForQuotation(receipt) {
+              // Important: at this point, the receipt is considered final. Nothing must alter it
+              // when all the properties of the receipt have been set, keep a copy
+              OB.UTIL.clone(receipt, frozenReceipt);
+
+              if (OB.UTIL.HookManager.get('OBPOS_PostSyncReceipt')) {
+                receiptForPostSyncReceipt = new OB.Model.Order();
+                OB.UTIL.clone(frozenReceipt, receiptForPostSyncReceipt);
+              }
+
+              serverMessageForQuotation = function (receipt) {
                 var isLayaway = (receipt.get('orderType') === 2 || receipt.get('isLayaway'));
                 var currentDocNo = receipt.get('documentNo');
                 if (receipt && receipt.get('isQuotation')) {
@@ -236,95 +247,74 @@
                 }
 
                 OB.trace('Order successfully removed.');
-              }
-
-              var synErrorCallback = function () {
-                  restoreReceiptOnError(eventParams, receipt);
-                  };
-
-
-              // create a clone of the receipt to be used when executing the final callback
-              if (OB.UTIL.HookManager.get('OBPOS_PostSyncReceipt')) {
-                // create a clone of the receipt to be used within the hook
-                var receiptForPostSyncReceipt = new OB.Model.Order();
-                OB.UTIL.clone(receipt, receiptForPostSyncReceipt);
-                //If there are elements in the hook, we are forced to execute the callback only after the synchronization process
-                //has been executed, to prevent race conditions with the callback processes (printing and deleting the receipt)
-                OB.trace('Execution Sync process.');
+              };
 
-                OB.MobileApp.model.runSyncProcess(function () {
-                  var successStep = function () {
-                      OB.UTIL.HookManager.executeHooks('OBPOS_PostSyncReceipt', {
-                        receipt: receiptForPostSyncReceipt,
-                        syncSuccess: true
-                      }, function () {
-                        serverMessageForQuotation(receipt);
-                        if (eventParams && eventParams.callback) {
-                          eventParams.callback({
-                            frozenReceipt: frozenReceipt,
-                            isCancelled: false
-                          });
-                        }
-                      });
-                      };
-
-                  // in synchronized mode do the doc sequence update in the success
-                  if (OB.MobileApp.model.hasPermission('OBMOBC_SynchronizedMode', true)) {
-                    OB.UTIL.calculateCurrentCash();
-                    OB.Dal.transaction(function (tx) {
-                      OB.MobileApp.model.updateDocumentSequenceWhenOrderSaved(receipt.get('documentnoSuffix'), receipt.get('quotationnoSuffix'), receipt.get('returnnoSuffix'), function () {
-                        OB.trace('Saving receipt.');
-                        OB.Dal.saveInTransaction(tx, receipt, function () {
-                          // the trigger is fired on the receipt object, as there is only 1 that is being updated
-                          receipt.trigger('integrityOk'); // Is important for module print last receipt. This module listen trigger.   
-                          successStep();
-                        });
-                      }, tx);
-                    });
-                  } else {
-                    successStep();
-                  }
-                }, function () {
-                  OB.UTIL.HookManager.executeHooks('OBPOS_PostSyncReceipt', {
-                    receipt: receiptForPostSyncReceipt,
-                    syncSuccess: false
-                  }, synErrorCallback);
-                });
-              } else {
-                OB.trace('Execution Sync process.');
-                //If there are no elements in the hook, we can execute the callback asynchronusly with the synchronization process
-                // for non-sync do it here, for sync do it in the success callback of runsyncprocess
-                if (!OB.MobileApp.model.hasPermission('OBMOBC_SynchronizedMode', true) && eventParams && eventParams.callback) {
+              closeParamCallback = function () {
+                if (eventParams && eventParams.callback) {
                   eventParams.callback({
                     frozenReceipt: frozenReceipt,
                     isCancelled: false
                   });
                 }
-                OB.MobileApp.model.runSyncProcess(function () {
-                  // in synchronized mode do the doc sequence update in the success and navigate back
-                  if (OB.MobileApp.model.hasPermission('OBMOBC_SynchronizedMode', true)) {
-                    OB.UTIL.calculateCurrentCash();
-                    OB.Dal.transaction(function (tx) {
-                      OB.MobileApp.model.updateDocumentSequenceWhenOrderSaved(receipt.get('documentnoSuffix'), receipt.get('quotationnoSuffix'), receipt.get('returnnoSuffix'), function () {
-                        OB.trace('Saving receipt.');
-                        OB.Dal.saveInTransaction(tx, receipt, function () {
-                          // the trigger is fired on the receipt object, as there is only 1 that is being updated
-                          receipt.trigger('integrityOk'); // Is important for module print last receipt. This module listen trigger.   
-                          if (eventParams && eventParams.callback) {
-                            eventParams.callback({
-                              frozenReceipt: frozenReceipt,
-                              isCancelled: false
-                            });
-                          }
-                        });
-                      }, tx);
-                    });
-                  }
+              };
+
+              syncSuccessCallback = function (callback) {
+                if (OB.UTIL.HookManager.get('OBPOS_PostSyncReceipt')) {
+                  OB.UTIL.HookManager.executeHooks('OBPOS_PostSyncReceipt', {
+                    receipt: receiptForPostSyncReceipt,
+                    syncSuccess: true
+                  }, function () {
+                    callback();
+                  });
+                } else {
+                  callback();
+                }
+              };
+
+              restoreReceiptCallback = function () {
+                restoreReceiptOnError(eventParams, receipt);
+              };
+
+              syncErrorCallback = function () {
+                if (OB.UTIL.HookManager.get('OBPOS_PostSyncReceipt')) {
+                  OB.UTIL.HookManager.executeHooks('OBPOS_PostSyncReceipt', {
+                    receipt: receiptForPostSyncReceipt,
+                    syncSuccess: false
+                  }, restoreReceiptCallback);
+                } else {
+                  restoreReceiptCallback();
+                }
+              };
 
-                  serverMessageForQuotation(frozenReceipt);
-                  OB.debug("Ticket closed: runSyncProcess executed");
-                }, synErrorCallback);
+              if (!OB.MobileApp.model.hasPermission('OBMOBC_SynchronizedMode', true)) {
+                // the trigger is fired on the receipt object, as there is only 1 that is being updated
+                receipt.trigger('integrityOk', frozenReceipt); // Is important for module print last receipt. This module listen trigger.  
+                closeParamCallback();
               }
+              OB.trace('Execution Sync process.');
+              OB.MobileApp.model.runSyncProcess(function () {
+                // in synchronized mode do the doc sequence update in the success
+                if (OB.MobileApp.model.hasPermission('OBMOBC_SynchronizedMode', true)) {
+                  OB.Dal.transaction(function (tx) {
+                    OB.UTIL.calculateCurrentCash(null, tx);
+                    OB.MobileApp.model.updateDocumentSequenceWhenOrderSaved(frozenReceipt.get('documentnoSuffix'), frozenReceipt.get('quotationnoSuffix'), frozenReceipt.get('returnnoSuffix'), function () {
+                      // the trigger is fired on the receipt object, as there is only 1 that is being updated
+                      receipt.trigger('integrityOk', frozenReceipt); // Is important for module print last receipt. This module listen trigger.
+                      syncSuccessCallback(function () {
+                        serverMessageForQuotation(frozenReceipt);
+                        closeParamCallback();
+                      });
+                    }, tx);
+                  });
+                } else {
+                  syncSuccessCallback(function () {
+                    serverMessageForQuotation(frozenReceipt);
+                  });
+                }
+                OB.debug("Ticket closed: runSyncProcess executed");
+              }, function () {
+                syncErrorCallback();
+              });
               };
 
           var executePreSyncReceipt = function () {
@@ -334,15 +324,8 @@
               }, function (args) {
                 receipt.set('json', JSON.stringify(receipt.serializeToJSON()));
                 receipt.set('hasbeenpaid', 'Y');
-                // Important: at this point, the receipt is considered final. Nothing must alter it
-                // when all the properties of the receipt have been set, keep a copy
-                OB.UTIL.clone(receipt, frozenReceipt);
                 OB.Dal.save(receipt, function () {
                   successCallback();
-                  if (!OB.MobileApp.model.hasPermission('OBMOBC_SynchronizedMode', true)) {
-                    // the trigger is fired on the receipt object, as there is only 1 that is being updated
-                    receipt.trigger('integrityOk'); // Is important for module print last receipt. This module listen trigger.  
-                  }
                 });
               });
               };