Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039607
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsmajoralways2018-11-08 17:572018-11-09 14:39
ReporterngarciaView Statuspublic 
Assigned Tononofrancisco 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision670fef403929
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Regression introduced in release
Summary

0039607: Cannot close a Distribution Order Receipt

DescriptionCannot close a Distribution Order Receipt
Steps To ReproduceIn https://livebuilds.openbravo.com/retail_modules_pgsql_pi [^]

Log in with AWO-QA Admin
Create a Distribution Order Receipt for US
Add a line to it and book it
Navigate to the related Distribution Order Issue
Confirm it
Return to Distribution Order Receipt and try to close it
You will get the following error:
   "Can not close an Order with Tasks in status 'Available' or 'Reserved'"

The log shows:

   ERROR org.openbravo.base.exception.OBException - Can not close an Order with Tasks in status 'Available' or 'Reserved'
org.openbravo.base.exception.OBException: Can not close an Order with Tasks in status 'Available' or 'Reserved'
    at org.openbravo.warehouse.advancedwarehouseoperations.distributionorders.hook.AfterDOAWOProcessedHook.run(AfterDOAWOProcessedHook.java:53)
    at org.openbravo.distributionorder.hooks.AfterDistributionOrderProcessedHookRunner.run(AfterDistributionOrderProcessedHookRunner.java:73)
    at org.openbravo.distributionorder.erpCommon.utility.ProcessDistributionOrderUtil.runAfterDistributionOrderProcessedHooks(ProcessDistributionOrderUtil.java:531)
    at org.openbravo.distributionorder.erpCommon.utility.ProcessDistributionOrderUtil.processDistributionOrder(ProcessDistributionOrderUtil.java:106)
    at org.openbravo.distributionorder.actionHandler.ProcessDistributionOrder.doExecute(ProcessDistributionOrder.java:50)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by design defect 0038911 closednonofrancisco When a picked but not issued DOi is CLOSED, the reservations are not deleted. 

-  Notes
(0107808)
vmromanos (manager)
2018-11-08 18:47

 Workaround meanwhile we fix it: declare "Delete tasks and reservations when closing DO" preference to Y
(0107815)
hgbot (developer)
2018-11-09 09:41

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 2c63586d1ddf00fb460652e49860777f0798de89
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Nov 08 14:45:01 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/2c63586d1ddf00fb460652e49860777f0798de89 [^]

Fixes issue 39607: Cannot close a Distribution Order Receipt

- When closing a Distribution Order and preference
  "OBDOA_DeleteNonConfTaskAndResWhenCloseDO"is not set, an exception is
  thrown only if there are non confirmed task for any of distribution order
  lines.
- An automated test was added.

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterDOAWOProcessedHook.java
---
(0107816)
hgbot (developer)
2018-11-09 09:41

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: d45377f73bc5e489e3ff1de0fbac609ab672ae26
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Nov 09 09:35:32 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/d45377f73bc5e489e3ff1de0fbac609ab672ae26 [^]

Related to issue 39607: Code review improvements
Simplified code
Renamed updateQuery -> query

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterDOAWOProcessedHook.java
---
(0107818)
hgbot (developer)
2018-11-09 09:52

 Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 670fef40392910d5b25293cde8591cfd27d9f2f1
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Nov 08 14:45:01 2018 -0500
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/670fef40392910d5b25293cde8591cfd27d9f2f1 [^]

Fixes issue 39607: Cannot close a Distribution Order Receipt

- When closing a Distribution Order and preference
  "OBDOA_DeleteNonConfTaskAndResWhenCloseDO"is not set, an exception is
  thrown only if there are non confirmed task for any of distribution order
  lines.
- An automated test was added.

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterDOAWOProcessedHook.java
---
(0107822)
vmromanos (manager)
2018-11-09 09:52

 Code review + testing OK
(0107826)
nonofrancisco (developer)
2018-11-09 14:39

 Test Plan

Log in with AWO-QA Admin
Create a Distribution Order Receipt for US
Add a line to it and book it
Navigate to the related Distribution Order Issue
Confirm it
Return to Distribution Order Receipt and try to close it
Verify the Distribution Order Receipt can be closed successfully.

- Issue History
Date Modified Username Field Change
2018-11-08 17:57 ngarcia New Issue
2018-11-08 17:57 ngarcia Assigned To => Triage Finance
2018-11-08 17:58 ngarcia Relationship added caused by 0038911
2018-11-08 17:58 ngarcia Issue Monitored: networkb
2018-11-08 17:59 vmromanos Status new => scheduled
2018-11-08 17:59 vmromanos Assigned To Triage Finance => nonofrancisco
2018-11-08 18:47 vmromanos Note Added: 0107808
2018-11-09 08:46 ngarcia Resolution time => 1543446000
2018-11-09 09:41 hgbot Checkin
2018-11-09 09:41 hgbot Note Added: 0107815
2018-11-09 09:41 hgbot Status scheduled => resolved
2018-11-09 09:41 hgbot Resolution open => fixed
2018-11-09 09:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/2c63586d1ddf00fb460652e49860777f0798de89 [^]
2018-11-09 09:41 hgbot Checkin
2018-11-09 09:41 hgbot Note Added: 0107816
2018-11-09 09:52 hgbot Checkin
2018-11-09 09:52 hgbot Note Added: 0107818
2018-11-09 09:52 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/2c63586d1ddf00fb460652e49860777f0798de89 [^] => http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/670fef40392910d5b25293cde8591cfd27d9f2f1 [^]
2018-11-09 09:52 vmromanos Review Assigned To => vmromanos
2018-11-09 09:52 vmromanos Note Added: 0107822
2018-11-09 09:52 vmromanos Status resolved => closed
2018-11-09 14:39 nonofrancisco Note Added: 0107826
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker