Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0039597 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Retail Modules] Web POS | major | have not tried | 2018-11-06 17:29 | 2019-03-28 18:44 | |||
| Reporter | jorge-garcia | View Status | public | |||||
| Assigned To | jorge-garcia | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR19Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | f598c8122391 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0039597: Generate new scrims for webPOS to avoid the use of enyo' scrim | |||||||
| Description | Generate new scrims for webPOS to avoid the use of enyo' scrim. The idea is link this functionality with Mobile Processes to be able to use different scrim for each process controller. | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0110050) hgbot (developer) 2019-02-25 12:35 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 39329fbe0944481f6e17e4abd53b19775feda946 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Thu Jan 03 17:51:01 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/39329fbe0944481f6e17e4abd53b19775feda946 [^] Fixed issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim This commit includes: * New columns and foreign keys defined at database level. * New reference list defined to add the possibility to define which kind of scrim should be used for each process. * New fields defined in Mobile Processes level to show new columns. * Include new JavaScript file to Mobile core component provider. * Add new fields in client-side information for process controller. * Move Loading and Processing scrim to a new file. * Generated two new kind of scrim (transparent and opaque). * All scrims are now defined in ob-terminal-scrim.js. * Modify showLoading, showLoadingTitle and showProcessing functions to safeguard the API. * Deprecate some utility functions to warn developers and clients. * Create new default message for processing scrim. --- M src-db/database/model/tables/OBMOBC_PROCESS_DEFINITION.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_MESSAGE.xml M src-db/database/sourcedata/AD_REFERENCE.xml M src-db/database/sourcedata/AD_REF_LIST.xml M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js M web/org.openbravo.mobile.core/source/main.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js M web/org.openbravo.mobile.core/source/utils/ob-processcontroller.js M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js A web/org.openbravo.mobile.core/source/component/ob-terminal-scrim.js --- |
|
(0110051) hgbot (developer) 2019-02-25 12:35 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 8ede9e6facd00087354cdd1cf286953465ea51a6 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 08 13:50:44 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8ede9e6facd00087354cdd1cf286953465ea51a6 [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Remove all references of “enyo.$.scrim” from mobile core’s module code. Create new process controllers to implement opaque scrim in some flows. Include xml reposition from merge conflict. --- M src-db/database/sourcedata/AD_REF_LIST.xml M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml M web/org.openbravo.mobile.core/source/component/dialog/ob-profile.js M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js M web/org.openbravo.mobile.core/source/component/obpos-approval.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js --- |
|
(0110052) hgbot (developer) 2019-02-25 12:35 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: f598c8122391ab55b58cda57493d77ea77bc8cfd Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 15 16:29:59 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f598c8122391ab55b58cda57493d77ea77bc8cfd [^] Fixed issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Include validation to avoid use a scrim message defined in ERP module. --- M src-db/database/sourcedata/AD_COLUMN.xml A src-db/database/sourcedata/AD_VAL_RULE.xml --- |
|
(0110053) hgbot (developer) 2019-02-25 12:35 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 4d930061778bb162490a1ea2e2bd3e5133b2d582 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Fri Jan 18 13:11:47 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4d930061778bb162490a1ea2e2bd3e5133b2d582 [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Fix some dependency errors in code. --- M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js --- |
|
(0110054) hgbot (developer) 2019-02-25 12:36 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 57966fd9181f6422404c08effd1b5d98d8612d3b Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Thu Jan 03 16:47:23 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/57966fd9181f6422404c08effd1b5d98d8612d3b [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Change showProcessing to use search key message in API. --- M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js --- |
|
(0110055) hgbot (developer) 2019-02-25 12:36 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 79187f77a80e9bd5e68df26c30cf22213755ecac Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 15 13:46:22 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79187f77a80e9bd5e68df26c30cf22213755ecac [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Remove all references of “enyo.$.scrim” from posterminal’s module code. Create new process controllers to implement opaque scrim in some flows. --- M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js M web/org.openbravo.retail.posterminal/js/components/modalreceipts.js M web/org.openbravo.retail.posterminal/js/data/dataordersave.js M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalcreditsales.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js --- |
|
(0110056) hgbot (developer) 2019-02-25 12:36 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: fafeb24f143c8df5fb75daa02952c46b63e74865 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Thu Jan 17 10:31:25 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fafeb24f143c8df5fb75daa02952c46b63e74865 [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Generate a new message in posterminal to avoid dependency check failure. --- M src-db/database/sourcedata/AD_MESSAGE.xml M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml --- |
|
(0110057) hgbot (developer) 2019-02-25 12:36 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6ce9d3ed7b61982fbbfa8f9c20e9b5f8a18b8083 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Fri Jan 18 13:12:21 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6ce9d3ed7b61982fbbfa8f9c20e9b5f8a18b8083 [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Include process controller definition in backend. --- M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml --- |
|
(0110058) hgbot (developer) 2019-02-25 12:36 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e98aebd4d2950e292fa50258afd53fbf2f08299a Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Mon Jan 21 11:02:40 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e98aebd4d2950e292fa50258afd53fbf2f08299a [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Include function check in ticketCloseUtils. Remove unnecessary line in creditSaleAction component. --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js --- |
|
(0110059) hgbot (developer) 2019-02-25 12:36 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ab46bf32a3fce30103e837bd69b1a3047cf431ac Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 22 10:55:38 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ab46bf32a3fce30103e837bd69b1a3047cf431ac [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Reactivate Layaway button once there is no pending process controller active. --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0110060) hgbot (developer) 2019-02-25 12:36 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: a7af7f37602714a07bc97d1e29e319e7f073db98 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Mon Feb 25 12:19:59 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a7af7f37602714a07bc97d1e29e319e7f073db98 [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Revert change in Layway setDisabled function. Removed incorrect code from layaway tap function. --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0110061) hgbot (developer) 2019-02-25 12:37 |
Repository: erp/pmods/org.openbravo.retail.discounts.bypaymentmethod Changeset: 1644af4eec66723867cf4bc1878ef8a99bde1b8f Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 08 13:48:31 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bypaymentmethod/rev/1644af4eec66723867cf4bc1878ef8a99bde1b8f [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Remove all references of “enyo.$.scrim” from discount bypaymentmethod’s module code. Create new process controllers to implement opaque scrim in some flows. --- M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml M web/org.openbravo.retail.discounts.bypaymentmethod/js/paymentmethod-discount.js --- |
|
(0110062) hgbot (developer) 2019-02-25 12:37 |
Repository: erp/pmods/org.openbravo.retail.sessions Changeset: 25c8985598e357f565b253bc1bc3909e594251d5 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 08 13:57:04 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/25c8985598e357f565b253bc1bc3909e594251d5 [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Remove all references of “enyo.$.scrim” from session’s module code. Create new process controllers to implement opaque scrim in some flows. --- M web/org.openbravo.retail.sessions/js/components/BusinessDateModel.js M web/org.openbravo.retail.sessions/js/components/BusinessDateWindowView.js A src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml --- |
|
(0110063) hgbot (developer) 2019-02-25 12:38 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 8e49e6b1e91f410fbcc55a1f640dfd3c59375c80 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 08 13:56:30 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/8e49e6b1e91f410fbcc55a1f640dfd3c59375c80 [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Remove all references of “enyo.$.scrim” from AWO’s module code. Create new process controllers to implement opaque scrim in some flows. --- M web/org.openbravo.warehouse.advancedwarehouseoperations/source/utils/obawo-utils.js A src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml --- |
|
(0110064) hgbot (developer) 2019-02-25 12:39 |
Repository: erp/pmods/org.openbravo.retail.complementary Changeset: 71dae4f942acfd39c5dae38be24d5ae96478f403 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 15 13:37:06 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.complementary/rev/71dae4f942acfd39c5dae38be24d5ae96478f403 [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Remove all references of “enyo.$.scrim” from complemetary product’s module code. --- M web/org.openbravo.retail.complementary/js/hooks/hookPreDeleteLine.js --- |
|
(0110065) hgbot (developer) 2019-02-25 12:39 |
Repository: tools/automation/pi-mobile Changeset: 6fd3851e57dd2c0f57014bf3083a064216b81b08 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Mon Feb 25 12:28:55 2019 +0100 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6fd3851e57dd2c0f57014bf3083a064216b81b08 [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Extend automated test scrim logic to cover all cases. Deactivate enyo.$.scrim2 check, it is used in WebPOS menu to block the UI and there is a lot of test keeping the menu opened at the end of the test. --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/terminals/WebPOSTerminalHelper.java --- |
|
(0110281) hgbot (developer) 2019-03-07 14:10 |
Repository: erp/pmods/org.openbravo.retail.complementary Changeset: d81405ef73182eeaf5cc1ac69716cd4dec54c1aa Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Thu Mar 07 14:10:02 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.complementary/rev/d81405ef73182eeaf5cc1ac69716cd4dec54c1aa [^] Related to issue 39597: Generate new scrims for webPOS to avoid the use of enyo' scrim Fix problem with test MultipleComplementary. The problem was caused due to confirmation popup override and the remove of several enyo.$.scrim from code. The solution is to hide those popups already openend before showing the complementary popup. --- M web/org.openbravo.retail.complementary/js/dialogConfirm.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-11-06 17:29 | jorge-garcia | New Issue | |
| 2018-11-06 17:29 | jorge-garcia | Assigned To | => jorge-garcia |
| 2018-11-06 17:29 | jorge-garcia | OBNetwork customer | => No |
| 2018-11-06 17:29 | jorge-garcia | Triggers an Emergency Pack | => No |
| 2019-02-25 12:35 | hgbot | Checkin | |
| 2019-02-25 12:35 | hgbot | Note Added: 0110050 | |
| 2019-02-25 12:35 | hgbot | Status | new => resolved |
| 2019-02-25 12:35 | hgbot | Resolution | open => fixed |
| 2019-02-25 12:35 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/39329fbe0944481f6e17e4abd53b19775feda946 [^] |
| 2019-02-25 12:35 | hgbot | Checkin | |
| 2019-02-25 12:35 | hgbot | Note Added: 0110051 | |
| 2019-02-25 12:35 | hgbot | Checkin | |
| 2019-02-25 12:35 | hgbot | Note Added: 0110052 | |
| 2019-02-25 12:35 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/39329fbe0944481f6e17e4abd53b19775feda946 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f598c8122391ab55b58cda57493d77ea77bc8cfd [^] |
| 2019-02-25 12:35 | hgbot | Checkin | |
| 2019-02-25 12:35 | hgbot | Note Added: 0110053 | |
| 2019-02-25 12:36 | hgbot | Checkin | |
| 2019-02-25 12:36 | hgbot | Note Added: 0110054 | |
| 2019-02-25 12:36 | hgbot | Checkin | |
| 2019-02-25 12:36 | hgbot | Note Added: 0110055 | |
| 2019-02-25 12:36 | hgbot | Checkin | |
| 2019-02-25 12:36 | hgbot | Note Added: 0110056 | |
| 2019-02-25 12:36 | hgbot | Checkin | |
| 2019-02-25 12:36 | hgbot | Note Added: 0110057 | |
| 2019-02-25 12:36 | hgbot | Checkin | |
| 2019-02-25 12:36 | hgbot | Note Added: 0110058 | |
| 2019-02-25 12:36 | hgbot | Checkin | |
| 2019-02-25 12:36 | hgbot | Note Added: 0110059 | |
| 2019-02-25 12:36 | hgbot | Checkin | |
| 2019-02-25 12:36 | hgbot | Note Added: 0110060 | |
| 2019-02-25 12:37 | hgbot | Checkin | |
| 2019-02-25 12:37 | hgbot | Note Added: 0110061 | |
| 2019-02-25 12:37 | hgbot | Checkin | |
| 2019-02-25 12:37 | hgbot | Note Added: 0110062 | |
| 2019-02-25 12:38 | hgbot | Checkin | |
| 2019-02-25 12:38 | hgbot | Note Added: 0110063 | |
| 2019-02-25 12:39 | hgbot | Checkin | |
| 2019-02-25 12:39 | hgbot | Note Added: 0110064 | |
| 2019-02-25 12:39 | hgbot | Checkin | |
| 2019-02-25 12:39 | hgbot | Note Added: 0110065 | |
| 2019-03-07 14:10 | hgbot | Checkin | |
| 2019-03-07 14:10 | hgbot | Note Added: 0110281 | |
| 2019-03-28 18:44 | marvintm | Review Assigned To | => marvintm |
| 2019-03-28 18:44 | marvintm | Status | resolved => closed |
| 2019-03-28 18:44 | marvintm | Fixed in Version | => RR19Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |