0039403: Cannot Generate Picking List from multiple orders if there is not stock for one of them

Notes
(0107233) markmm82 (developer) 2018-10-11 03:02	Test Plan: As group admin role: Set Enable Stock Reservations to Y Log out and log in Apply module's dataset Create a sales order for Alimentos y Supermercados, S.A and España Región Norte warehouse, add a product without stock in the order's warehouse, for example Agua sin Gas 1L and book it. Select the order and launch Generate Picking List process: Picking List Type: Direct Picking List to Customer Grouping criteria: Not group Check the following error is shown: "Error There is not enough available stock" Create a sales order for Alimentos y Supermercados, S.A and España Región Norte warehouse. Add a line with a product without stock in the order's warehouse, for example Agua sin Gas 1L. Add a line with a product with stock in the order's warehouse, for example Cerveza Ale 0,5L. Book the order. Select the order and launch Generate Picking List process: Picking List Type: Direct Picking List to Customer Grouping criteria: Not group Check the Picking List was partially generated with the line with stock and the following message is shown: "Picking List created successfully PL336 There is not enough stock in warehouses to create the whole Picking List. : [PL336]" Go to Warehouse Picking List window and cancel the previously created picking list. Create a sales order for Alimentos y Supermercados, S.A and España Región Norte warehouse, add a product with stock in the order's warehouse, for example Cerveza Lager 0,5L and book it. Select all previously created orders (first with no stock, second with partial stock and third with stock) and launch Generate Picking List process: Picking List Type: Direct Picking List to Customer Grouping criteria: Not group Check two picking list have been created, one related to the order with partial stock and the other to the order with stock. Also is explained to the user the order from wich was not possible to generate the Picking List because no available stock. The following message is shown: "Picking List created successfully PL341, PL342 There is not enough stock in warehouses to create the whole Picking List. : [PL341] There is not enough available stock for the following orders: 1000264"

(0107253) hgbot (developer) 2018-10-11 17:35	Repository: erp/pmods/org.openbravo.warehouse.pickinglist Changeset: e0abc9b99fe16e664fd669bd13f3111dace0a46e Author: Mark <markmm82 <at> gmail.com> Date: Wed Oct 10 21:11:00 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/e0abc9b99fe16e664fd669bd13f3111dace0a46e [^] Fixes issue 39403: Cannot Generate Picking List from multiple orders if there is not stock for one of them When generating Picking List from multiple orders and one of them hasn't stock then the process was stopped because an exception was thrown and a rollback and close executed. It avoid the creation of the picking lists from the other orders that can be completely or partially picked. To avoid that, the process don't stop if one of the orders haven't stock, it continues but show at the end the list of orders wich was not possible to create the Picking Lists. If any picking list could be created because there is no available stock for the selected orders then an error message is shown explaining that there is no available stock. With this change, the process could end successfully, showing the identifiers of the generated Picking Lists, and also notifying to the user the ist of orders that couldn't be processed because there is no stock. --- M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/warehouse/pickinglist/CreateActionHandler.java M src/org/openbravo/warehouse/pickinglist/Utilities.java ---

(0107254) Sandrahuguet (developer) 2018-10-11 17:36	Code review + testing OK

Issue History
Date Modified	Username	Field	Change
2018-10-04 13:23	ngarcia	New Issue
2018-10-04 13:23	ngarcia	Assigned To	=> Triage Finance
2018-10-04 13:23	ngarcia	Resolution time	=> 1540418400
2018-10-04 13:25	ngarcia	Issue Monitored: networkb
2018-10-04 17:46	Sandrahuguet	Assigned To	Triage Finance => markmm82
2018-10-04 23:34	markmm82	Status	new => acknowledged
2018-10-11 03:02	markmm82	Note Added: 0107233
2018-10-11 03:03	markmm82	Status	acknowledged => scheduled
2018-10-11 17:35	hgbot	Checkin
2018-10-11 17:35	hgbot	Note Added: 0107253
2018-10-11 17:35	hgbot	Status	scheduled => resolved
2018-10-11 17:35	hgbot	Resolution	open => fixed
2018-10-11 17:35	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/e0abc9b99fe16e664fd669bd13f3111dace0a46e [^]
2018-10-11 17:36	Sandrahuguet	Review Assigned To	=> Sandrahuguet
2018-10-11 17:36	Sandrahuguet	Note Added: 0107254
2018-10-11 17:37	Sandrahuguet	Status	resolved => closed
2018-10-15 09:59	eugeni	Issue Monitored: eugeni
2018-10-18 17:03	ngarcia	Issue cloned	0039485
2018-10-18 17:03	ngarcia	Relationship added	related to 0039485