Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0039388
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-10-02 12:532019-02-06 14:42
ReporterairaceburuView Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039388: Digital Coupons does not work in Pay Open Tickets

DescriptionDigital coupons popup is not shown during payment selection in payOpenTickets
Steps To ReproduceGo to pay open tickets and try to pay with digital coupons
Proposed Solutionpatch attached
TagsNo tags attached.
Attached Filesdiff file icon payOpenTicketsSelectPaymentHook.diff [^] (878 bytes) 2018-10-02 12:53 [Show Content]
diff file icon digitalCouponsPayOpenTickets.diff [^] (4,242 bytes) 2018-10-02 13:01 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
has duplicate feature request 0035242 closedRetail PayOpenTicketsSelectPayment Hook 

-  Notes
(0107116)
airaceburu (developer)
2018-10-02 13:05

Related with issue: https://issues.openbravo.com/view.php?id=35242 [^]
(0108027)
jorge-garcia (developer)
2018-11-21 09:45

Pending to fix
(0108863)
hgbot (developer)
2019-01-09 04:18

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 04d88f1ea8c37ccad4839866a1ad39feb1c0926f
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Jan 08 10:30:25 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/04d88f1ea8c37ccad4839866a1ad39feb1c0926f [^]

Fix issue 39388: Digital Coupons does not work in Pay Open Tickets

- Added call to OBPOS_PayOpenTicketsPaymentSelected hook

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---
(0109534)
jorge-garcia (developer)
2019-02-04 16:03
edited on: 2019-02-04 16:06

The solution is not correct.

If you try to pay one or more orders at the same time using "Pay Open Tickets" option and then the user selects Digital Coupons as payment method, a huge javascript error is shown:

Uncaught TypeError: args.order.set is not a function
    at ee918b43b2bf992d26a58db00c16bd2d.js:formatted:85345
    at G.d.callbackExecutor (ee918b43b2bf992d26a58db00c16bd2d.js:formatted:11745)
    at G.d.executeHooks (ee918b43b2bf992d26a58db00c16bd2d.js:formatted:11739)
    at G.d.OB.UTIL.HookManager.executeHooks (ee918b43b2bf992d26a58db00c16bd2d.js:formatted:113482)
    at Object.<anonymous> (ee918b43b2bf992d26a58db00c16bd2d.js:formatted:42898)
    at G.d.trigger (VM62 backbone-0.9.2.min.js:9)
    at G.d.change (VM62 backbone-0.9.2.min.js:15)
    at G.d.set (VM62 backbone-0.9.2.min.js:12)
    at Object.buttonStatusChanged (ee918b43b2bf992d26a58db00c16bd2d.js:formatted:59138)
    at Object.dispatch (VM55 enyo.js:628)

(0109637)
hgbot (developer)
2019-02-06 14:42

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 026df370c1be221f253f5fed4b16cac587d63cfe
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Feb 05 23:18:23 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/026df370c1be221f253f5fed4b16cac587d63cfe [^]

Fix issue 39388: Digital Coupons does not work in Pay Open Tickets

- Changed 'order' argument value passed to the hook call

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---

- Issue History
Date Modified Username Field Change
2018-10-02 12:53 airaceburu New Issue
2018-10-02 12:53 airaceburu Assigned To => Retail
2018-10-02 12:53 airaceburu File Added: payOpenTicketsSelectPaymentHook.diff
2018-10-02 12:53 airaceburu Triggers an Emergency Pack => No
2018-10-02 13:01 airaceburu File Added: digitalCouponsPayOpenTickets.diff
2018-10-02 13:05 airaceburu Note Added: 0107116
2018-10-03 14:57 rqueralta Assigned To Retail => rqueralta
2018-10-03 14:57 rqueralta Status new => scheduled
2018-10-22 13:49 jorge-garcia Relationship added has duplicate 0035242
2018-11-14 11:07 jorge-garcia Review Assigned To => jorge-garcia
2018-11-14 11:07 jorge-garcia Status scheduled => closed
2018-11-14 11:07 jorge-garcia Resolution open => duplicate
2018-11-21 09:45 jorge-garcia Note Added: 0108027
2018-11-21 09:45 jorge-garcia Status closed => new
2018-11-21 09:45 jorge-garcia Resolution duplicate => open
2019-01-09 04:18 hgbot Checkin
2019-01-09 04:18 hgbot Note Added: 0108863
2019-01-09 04:40 rqueralta Status new => scheduled
2019-01-09 04:40 rqueralta Status scheduled => resolved
2019-01-09 04:40 rqueralta Resolution open => fixed
2019-02-04 16:03 jorge-garcia Note Added: 0109534
2019-02-04 16:03 jorge-garcia Status resolved => new
2019-02-04 16:03 jorge-garcia Resolution fixed => open
2019-02-04 16:06 jorge-garcia Note Edited: 0109534 View Revisions
2019-02-06 14:42 hgbot Checkin
2019-02-06 14:42 hgbot Note Added: 0109637


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker