Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039388Retail ModulesWeb POSpublic2018-10-02 12:532019-02-06 14:42
Reporterairaceburu 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusnewResolutionopen 
PlatformOS5OS Version
Product Versionpi 
Target VersionpiFixed in Version 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039388: Digital Coupons does not work in Pay Open Tickets
DescriptionDigital coupons popup is not shown during payment selection in payOpenTickets
Steps To ReproduceGo to pay open tickets and try to pay with digital coupons
Proposed Solutionpatch attached
Additional Information
TagsNo tags attached.
Relationships
has duplicate feature request 0035242 closed Retail PayOpenTicketsSelectPayment Hook 
Attached Filesdiff payOpenTicketsSelectPaymentHook.diff (878) 2018-10-02 12:53
https://issues.openbravo.com/file_download.php?file_id=12219&type=bug
diff digitalCouponsPayOpenTickets.diff (4,242) 2018-10-02 13:01
https://issues.openbravo.com/file_download.php?file_id=12220&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-10-02 12:53airaceburuNew Issue
2018-10-02 12:53airaceburuAssigned To => Retail
2018-10-02 12:53airaceburuFile Added: payOpenTicketsSelectPaymentHook.diff
2018-10-02 12:53airaceburuTriggers an Emergency Pack => No
2018-10-02 13:01airaceburuFile Added: digitalCouponsPayOpenTickets.diff
2018-10-02 13:05airaceburuNote Added: 0107116
2018-10-03 14:57rqueraltaAssigned ToRetail => rqueralta
2018-10-03 14:57rqueraltaStatusnew => scheduled
2018-10-22 13:49jorge-garciaRelationship addedhas duplicate 0035242
2018-11-14 11:07jorge-garciaReview Assigned To => jorge-garcia
2018-11-14 11:07jorge-garciaStatusscheduled => closed
2018-11-14 11:07jorge-garciaResolutionopen => duplicate
2018-11-21 09:45jorge-garciaNote Added: 0108027
2018-11-21 09:45jorge-garciaStatusclosed => new
2018-11-21 09:45jorge-garciaResolutionduplicate => open
2019-01-09 04:18hgbotCheckin
2019-01-09 04:18hgbotNote Added: 0108863
2019-01-09 04:40rqueraltaStatusnew => scheduled
2019-01-09 04:40rqueraltaStatusscheduled => resolved
2019-01-09 04:40rqueraltaResolutionopen => fixed
2019-02-04 16:03jorge-garciaNote Added: 0109534
2019-02-04 16:03jorge-garciaStatusresolved => new
2019-02-04 16:03jorge-garciaResolutionfixed => open
2019-02-04 16:06jorge-garciaNote Edited: 0109534bug_revision_view_page.php?bugnote_id=0109534#r18267
2019-02-06 14:42hgbotCheckin
2019-02-06 14:42hgbotNote Added: 0109637

Notes
(0107116)
airaceburu   
2018-10-02 13:05   
Related with issue: https://issues.openbravo.com/view.php?id=35242 [^]
(0108027)
jorge-garcia   
2018-11-21 09:45   
Pending to fix
(0108863)
hgbot   
2019-01-09 04:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 04d88f1ea8c37ccad4839866a1ad39feb1c0926f
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Jan 08 10:30:25 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/04d88f1ea8c37ccad4839866a1ad39feb1c0926f [^]

Fix issue 39388: Digital Coupons does not work in Pay Open Tickets

- Added call to OBPOS_PayOpenTicketsPaymentSelected hook

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---
(0109534)
jorge-garcia   
2019-02-04 16:03   
(edited on: 2019-02-04 16:06)
The solution is not correct.

If you try to pay one or more orders at the same time using "Pay Open Tickets" option and then the user selects Digital Coupons as payment method, a huge javascript error is shown:

Uncaught TypeError: args.order.set is not a function
    at ee918b43b2bf992d26a58db00c16bd2d.js:formatted:85345
    at G.d.callbackExecutor (ee918b43b2bf992d26a58db00c16bd2d.js:formatted:11745)
    at G.d.executeHooks (ee918b43b2bf992d26a58db00c16bd2d.js:formatted:11739)
    at G.d.OB.UTIL.HookManager.executeHooks (ee918b43b2bf992d26a58db00c16bd2d.js:formatted:113482)
    at Object.<anonymous> (ee918b43b2bf992d26a58db00c16bd2d.js:formatted:42898)
    at G.d.trigger (VM62 backbone-0.9.2.min.js:9)
    at G.d.change (VM62 backbone-0.9.2.min.js:15)
    at G.d.set (VM62 backbone-0.9.2.min.js:12)
    at Object.buttonStatusChanged (ee918b43b2bf992d26a58db00c16bd2d.js:formatted:59138)
    at Object.dispatch (VM55 enyo.js:628)
(0109637)
hgbot   
2019-02-06 14:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 026df370c1be221f253f5fed4b16cac587d63cfe
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Feb 05 23:18:23 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/026df370c1be221f253f5fed4b16cac587d63cfe [^]

Fix issue 39388: Digital Coupons does not work in Pay Open Tickets

- Changed 'order' argument value passed to the hook call

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---