Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039222
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-09-04 11:582018-10-23 11:47
ReporteraaroncaleroView Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionfixedFixed in VersionRR18Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039222: Check Number field in Digital Coupons popup doesn't have a max-length defined

DescriptionCheck Number field in Digital Coupons popup doesn't have a max-length defined, however the field in the database has a maximum length of 40 characters.
If a user creates a digital coupon with a check number of more than 40 characters, an error is raised in the OrderLoader and the ticket is not saved.
Steps To ReproduceLogin in an environment with Digital Coupons installed (i.e. https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=YS-11#retail.pointofsale [^])
Create a new ticket.
Add any product.
Click on the Total Amount button to go to the payment tab.
Select the Digital Coupons payment method and create the following coupon:
*Issuing Company: 275281 - Restaurant Check
*Check number: 0123456789012345678901234567890123456789a (41 characters)
*Amount: enough to pay the ticket
*Expiration Date: Leave the default
Click on Add to add the digital coupon.
Complete the order by clicking on Done.
Verify that the order has ended in the Errors while importing POS Data window, with the following error:
org.openbravo.base.validation.ValidationException: checkno: Value (0123456789012345678901234567890123456789a) is too long, it has length 41, the maximum allowed length is 40
Proposed SolutionAdd a maxLength attribute to the Check Number component
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0106750)
marvintm (manager)
2018-09-13 16:19

 Fixed issue 39222: Check Number field in Digital Coupons popup doesn't have a
max-length defined

- Max-length was added to the field Check Number

- A new message was added


https://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/6d8f1cdfdc5d [^]
(0107506)
hgbot (developer)
2018-10-22 19:23

 Repository: tools/automation/pi-mobile
Changeset: 65e2b48157cdfdde23fc4682276d894db32c0140
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Fri Sep 07 15:26:18 2018 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/65e2b48157cdfdde23fc4682276d894db32c0140 [^]

Related to issue 39222: added automated test

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/digital_coupons/I39222_VerifyDigitalCouponsMaxLength.java
---
(0107526)
hgbot (developer)
2018-10-23 11:47

 Repository: tools/automation/pi-mobile
Changeset: 3e1911d17f3713606cdbac81034cbb04f159dd18
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Oct 23 08:28:24 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3e1911d17f3713606cdbac81034cbb04f159dd18 [^]

Related to issue 39222: added automated test

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/PayOpenTicketInSeller.java
---

- Issue History
Date Modified Username Field Change
2018-09-04 11:58 aaroncalero New Issue
2018-09-04 11:58 aaroncalero Assigned To => Retail
2018-09-04 11:58 aaroncalero Resolution time => 1537221600
2018-09-04 11:58 aaroncalero Triggers an Emergency Pack => No
2018-09-04 12:03 aaroncalero Steps to Reproduce Updated View Revisions
2018-09-04 14:23 rqueralta Assigned To Retail => rqueralta
2018-09-04 14:23 rqueralta Status new => scheduled
2018-09-13 16:19 marvintm Note Added: 0106750
2018-09-13 16:19 marvintm Status scheduled => resolved
2018-09-13 16:19 marvintm Fixed in Version => RR18Q4
2018-09-13 16:19 marvintm Resolution open => fixed
2018-09-14 11:32 marvintm Review Assigned To => marvintm
2018-09-14 11:32 marvintm Status resolved => closed
2018-10-22 19:23 hgbot Checkin
2018-10-22 19:23 hgbot Note Added: 0107506
2018-10-23 11:47 hgbot Checkin
2018-10-23 11:47 hgbot Note Added: 0107526

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker