Openbravo Issue Tracking System - Retail Modules
View Issue Details
0039222Retail ModulesWeb POSpublic2018-09-04 11:582018-10-23 11:47
aaroncalero 
rqueralta 
normalmajoralways
closedfixed 
5
 
RR18Q4 
marvintm
No
0039222: Check Number field in Digital Coupons popup doesn't have a max-length defined
Check Number field in Digital Coupons popup doesn't have a max-length defined, however the field in the database has a maximum length of 40 characters.
If a user creates a digital coupon with a check number of more than 40 characters, an error is raised in the OrderLoader and the ticket is not saved.
Login in an environment with Digital Coupons installed (i.e. https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=YS-11#retail.pointofsale [^])
Create a new ticket.
Add any product.
Click on the Total Amount button to go to the payment tab.
Select the Digital Coupons payment method and create the following coupon:
*Issuing Company: 275281 - Restaurant Check
*Check number: 0123456789012345678901234567890123456789a (41 characters)
*Amount: enough to pay the ticket
*Expiration Date: Leave the default
Click on Add to add the digital coupon.
Complete the order by clicking on Done.
Verify that the order has ended in the Errors while importing POS Data window, with the following error:
org.openbravo.base.validation.ValidationException: checkno: Value (0123456789012345678901234567890123456789a) is too long, it has length 41, the maximum allowed length is 40
Add a maxLength attribute to the Check Number component
No tags attached.
Issue History
2018-09-04 11:58aaroncaleroNew Issue
2018-09-04 11:58aaroncaleroAssigned To => Retail
2018-09-04 11:58aaroncaleroResolution time => 1537221600
2018-09-04 11:58aaroncaleroTriggers an Emergency Pack => No
2018-09-04 12:03aaroncaleroSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17594#r17594
2018-09-04 14:23rqueraltaAssigned ToRetail => rqueralta
2018-09-04 14:23rqueraltaStatusnew => scheduled
2018-09-13 16:19marvintmNote Added: 0106750
2018-09-13 16:19marvintmStatusscheduled => resolved
2018-09-13 16:19marvintmFixed in Version => RR18Q4
2018-09-13 16:19marvintmResolutionopen => fixed
2018-09-14 11:32marvintmReview Assigned To => marvintm
2018-09-14 11:32marvintmStatusresolved => closed
2018-10-22 19:23hgbotCheckin
2018-10-22 19:23hgbotNote Added: 0107506
2018-10-23 11:47hgbotCheckin
2018-10-23 11:47hgbotNote Added: 0107526

Notes
(0106750)
marvintm   
2018-09-13 16:19   
Fixed issue 39222: Check Number field in Digital Coupons popup doesn't have a
max-length defined

- Max-length was added to the field Check Number

- A new message was added


https://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/6d8f1cdfdc5d [^]
(0107506)
hgbot   
2018-10-22 19:23   
Repository: tools/automation/pi-mobile
Changeset: 65e2b48157cdfdde23fc4682276d894db32c0140
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Fri Sep 07 15:26:18 2018 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/65e2b48157cdfdde23fc4682276d894db32c0140 [^]

Related to issue 39222: added automated test

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/digital_coupons/I39222_VerifyDigitalCouponsMaxLength.java
---
(0107526)
hgbot   
2018-10-23 11:47   
Repository: tools/automation/pi-mobile
Changeset: 3e1911d17f3713606cdbac81034cbb04f159dd18
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Oct 23 08:28:24 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3e1911d17f3713606cdbac81034cbb04f159dd18 [^]

Related to issue 39222: added automated test

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/PayOpenTicketInSeller.java
---