Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0039191
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Cash upmajoralways2018-08-27 13:562018-10-02 13:30
ReporterLeyreView Statuspublic 
Assigned Togorka_gil 
PriorityimmediateResolutionfixedFixed in VersionRR18Q4
StatusclosedFix in branchFixed in SCM revision6887f3de7107
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket4181
Regression levelProduction - Confirmed Stable
Regression date2017-07-24
Regression introduced in releaseRR17Q4
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4effbcf40012566124172b75b2fc0a9c5ed6a893 [^]
Triggers an Emergency PackNo
Summary

0039191: Incorrect grouping by ad_user_id in SQL of insert invoice headers in cash-up process

DescriptionThere is a difference in the grouping of insert invoice headers and insert invoice lines during the cash-up process.
Steps To ReproduceOrderGroupingProcessor_data.xsql:

The SQL of insert invoice header( grouping orders and no grouping orders), it is grouped by ad_user_id, unlike the SQL of insert invoice lines.

It may be caused by https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4effbcf40012566124172b75b2fc0a9c5ed6a893 [^]
TagsNo tags attached.
Attached Filesdiff file icon issue39191.diff [^] (3,365 bytes) 2018-08-31 12:24 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0039389RR18Q3.2 closedgorka_gil Incorrect grouping by ad_user_id in SQL of insert invoice headers in cash-up process 
depends on backport 0039390RR18Q2.4 closedgorka_gil Incorrect grouping by ad_user_id in SQL of insert invoice headers in cash-up process 
caused by defect 0036468 closedranjith_qualiantech_com [SERQA 3100] User is not set for Invoices created in Cashup process 

-  Notes
(0106512)
marvintm (viewer)
2018-08-29 09:25

Attached a possible solution for the problem. We need to validate that it is fully correct with the customer customizations
(0106528)
Leyre (viewer)
2018-08-30 08:40

This patch has been tried but it does not work correctly.

The steps to reproduce the problem:

1. Generate a sales order in a POS Terminal, with a customer without contact (ad_user_id=null)

2. Add a contact to the same customer and generate more sales order.

3. Do the cash up and verify that it generates incorrect invoices.

** Possible solution:
In the query that inserts the lines, add to the clause where :

coalesce(i.ad_user_id,'') = coalesce(o.ad_user_id,'')
(0106584)
hgbot (developer)
2018-09-03 13:29

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6887f3de710760293d267067bc0039daa2669299
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Sep 03 13:29:05 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6887f3de710760293d267067bc0039daa2669299 [^]

Fixes issue 39191 : fix the grouping for invoices generated in cashup process

Add ad_user_id to the grouping in missing sqls.

Add condition that ad_user of the invoice and the order is the same.

If ad_user null, used coalesce to set to '1', for compare since nulls can not be compared.
Note: Used '1' instead '', because oracle consired '' like a null and con not be compared neither.

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---

- Issue History
Date Modified Username Field Change
2018-08-27 13:56 Leyre New Issue
2018-08-27 13:56 Leyre Assigned To => Retail
2018-08-27 13:56 Leyre OBNetwork customer => Yes
2018-08-27 13:56 Leyre Resolution time => 1537135200
2018-08-27 13:56 Leyre Triggers an Emergency Pack => No
2018-08-27 14:44 Leyre Priority urgent => immediate
2018-08-27 14:57 Leyre Resolution time 1537135200 => 1535580000
2018-08-27 14:58 Leyre Steps to Reproduce Updated View Revisions
2018-08-28 07:53 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2018-08-28 07:53 ranjith_qualiantech_com Status new => scheduled
2018-08-28 08:09 ranjith_qualiantech_com Relationship added caused by 0036468
2018-08-28 10:03 Leyre Support ticket => 4181
2018-08-28 14:50 jfrances Issue Monitored: jfrances
2018-08-28 16:15 achaves Issue Monitored: achaves
2018-08-29 09:25 ranjith_qualiantech_com File Added: issue 39191 source posterminal.patch
2018-08-29 09:25 marvintm Note Added: 0106512
2018-08-29 09:25 marvintm Assigned To ranjith_qualiantech_com => Leyre
2018-08-29 09:25 marvintm Status scheduled => feedback
2018-08-30 08:40 Leyre Note Added: 0106528
2018-08-30 08:42 Leyre Assigned To Leyre => Retail
2018-08-30 08:42 Leyre Status feedback => new
2018-08-30 15:25 marvintm File Deleted: issue 39191 source posterminal.patch
2018-08-31 12:24 marvintm File Added: issue39191.diff
2018-09-03 13:10 gorka_gil Assigned To Retail => gorka_gil
2018-09-03 13:29 hgbot Checkin
2018-09-03 13:29 hgbot Note Added: 0106584
2018-09-03 13:29 hgbot Status new => resolved
2018-09-03 13:29 hgbot Resolution open => fixed
2018-09-03 13:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6887f3de710760293d267067bc0039daa2669299 [^]
2018-09-07 14:53 marvintm Review Assigned To => marvintm
2018-09-07 14:53 marvintm Status resolved => closed
2018-09-07 14:53 marvintm Fixed in Version => RR18Q4
2018-10-02 13:28 marvintm Status closed => new
2018-10-02 13:28 marvintm Resolution fixed => open
2018-10-02 13:28 marvintm Fixed in Version RR18Q4 =>
2018-10-02 13:28 marvintm Status new => scheduled
2018-10-02 13:28 marvintm Status scheduled => resolved
2018-10-02 13:28 marvintm Fixed in Version => RR18Q4
2018-10-02 13:28 marvintm Resolution open => fixed
2018-10-02 13:28 marvintm Status resolved => closed
2018-10-02 13:30 marvintm Regression level => Production - Confirmed Stable
2018-10-02 13:30 marvintm Regression date => 2017-07-24
2018-10-02 13:30 marvintm Regression introduced in release => RR17Q4
2018-10-02 13:30 marvintm Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4effbcf40012566124172b75b2fc0a9c5ed6a893 [^]


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker