Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0039144
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServerminoralways2018-08-16 12:122018-10-03 13:28
ReporterioritzCiaView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionno change requiredFixed in Version
StatusclosedFix in branchFixed in SCM revision3492b2625a65
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version8
OS VersionUbuntu 18.04Database version9.5Ant version1.9
Product VersionRR17Q2SCM revision 
Review Assigned ToAugustoMauch
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039144: DAL queries should be replaced by SQL queries to avoid the change of Hibernate API

DescriptionDAL queries should be replaced by SQL queries to avoid the change of Hibernate API
Steps To ReproduceN/A
TagsNo tags attached.
Attached Filesdiff file icon retail-sync.diff [^] (37,398 bytes) 2018-09-25 23:22 [Show Content]
diff file icon repl.diff [^] (22,105 bytes) 2018-09-25 23:23 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
has duplicate feature request 0039090 closedmtaal Use dal connection object and other solutions to make hibernate usage backward and forward compat 
related to feature request 0039319 newRetail Use Hibernate Query object typed in all cases 

-  Notes
(0106372)
mtaal (manager)
2018-08-17 00:25

See here the links for the relevant hb-upgrade changesets. Note is both in sym-ds as well as in retail store server sync module:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d19a823ff93c [^]

https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/1724a2e70551 [^]
(0107080)
hgbot (developer)
2018-10-01 05:48

Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 39ad04d9cf38da78f77a7f2436bf57f389fff781
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Oct 01 05:48:15 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/39ad04d9cf38da78f77a7f2436bf57f389fff781 [^]

Related to issue 39144: DAL queries should be replaced by SQL queries to avoid the change of Hibernate API
Several changes related to using direct sql queries instead of the hibernate api

---
M src/org/openbravo/replication/symmetricds/SetupSymmetricListener.java
M src/org/openbravo/replication/symmetricds/datasource/RegisteredServersDS.java
M src/org/openbravo/replication/symmetricds/task/SetMandatoryReloadFlagTask.java
M src/org/openbravo/replication/symmetricds/util/OutgoingBatchReloader.java
M src/org/openbravo/replication/symmetricds/validation/DataValidationError.java
M src/org/openbravo/replication/symmetricds/validation/ExportedTableValidator.java
M src/org/openbravo/replication/symmetricds/validation/SynchronizationStoreDataValidator.java
---
(0107082)
hgbot (developer)
2018-10-01 05:52

Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 3492b2625a65154784ae6e02f1fe8a02fcb7ca2b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Oct 01 05:52:03 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/3492b2625a65154784ae6e02f1fe8a02fcb7ca2b [^]

Fixes issue 39144: DAL queries should be replaced by SQL queries to avoid the change of Hibernate API
Use non-hibernate api in several places, also do not check transaction, is slightly less efficient but not a big issue

---
M src/org/openbravo/retail/storeserver/synchronization/IgnoreVersionCheckPreferenceEventHandler.java
M src/org/openbravo/retail/storeserver/synchronization/StoreServerVersionHandler.java
M src/org/openbravo/retail/storeserver/synchronization/eventhandler/AutoRouteAndPushGenericEventHandler.java
M src/org/openbravo/retail/storeserver/synchronization/process/BusinessPartnerAndRelatedTablesSynchronizer.java
M src/org/openbravo/retail/storeserver/synchronization/router/AssortmentRouter.java
M src/org/openbravo/retail/storeserver/synchronization/router/LocationRouter.java
M src/org/openbravo/retail/storeserver/synchronization/router/ProductPriceRouter.java
M src/org/openbravo/retail/storeserver/synchronization/router/UserTerminalAccessRouter.java
---
(0107120)
AugustoMauch (administrator)
2018-10-02 17:11

Reopened, because it is better (less verbose, less error prone) to use xsql than to execute plain sql directly in Java
(0107137)
hgbot (developer)
2018-10-03 13:27

Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 9dad357af1ecd8de5938d27e3953d90d7df08e03
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Oct 03 13:26:59 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/9dad357af1ecd8de5938d27e3953d90d7df08e03 [^]

Related with issue 39144: Backed out changeset 3492b2625a65, changes not needed

Instead of modifying the codebase to make it compatible with the previous version of hibernate,
it is going to remain as it is, and if backports to previous versions are needed, the backports
will be adapted.

---
M src/org/openbravo/retail/storeserver/synchronization/IgnoreVersionCheckPreferenceEventHandler.java
M src/org/openbravo/retail/storeserver/synchronization/StoreServerVersionHandler.java
M src/org/openbravo/retail/storeserver/synchronization/eventhandler/AutoRouteAndPushGenericEventHandler.java
M src/org/openbravo/retail/storeserver/synchronization/process/BusinessPartnerAndRelatedTablesSynchronizer.java
M src/org/openbravo/retail/storeserver/synchronization/router/AssortmentRouter.java
M src/org/openbravo/retail/storeserver/synchronization/router/LocationRouter.java
M src/org/openbravo/retail/storeserver/synchronization/router/ProductPriceRouter.java
M src/org/openbravo/retail/storeserver/synchronization/router/UserTerminalAccessRouter.java
---
(0107138)
hgbot (developer)
2018-10-03 13:28

Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: d66ca9ce9503ac8d41dcabdfa7b0b0765d63b526
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Oct 03 13:27:44 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/d66ca9ce9503ac8d41dcabdfa7b0b0765d63b526 [^]

Related with issue 39144: Backed out changeset 39ad04d9cf38, changes not needed

Instead of modifying the codebase to make it compatible with the previous version of hibernate,
it is going to remain as it is, and if backports to previous versions are needed, the backports
will be adapted.

---
M src/org/openbravo/replication/symmetricds/SetupSymmetricListener.java
M src/org/openbravo/replication/symmetricds/datasource/RegisteredServersDS.java
M src/org/openbravo/replication/symmetricds/task/SetMandatoryReloadFlagTask.java
M src/org/openbravo/replication/symmetricds/util/OutgoingBatchReloader.java
M src/org/openbravo/replication/symmetricds/validation/DataValidationError.java
M src/org/openbravo/replication/symmetricds/validation/ExportedTableValidator.java
M src/org/openbravo/replication/symmetricds/validation/SynchronizationStoreDataValidator.java
---
(0107139)
AugustoMauch (administrator)
2018-10-03 13:28

Instead of modifying the codebase to make it compatible with the previous version of hibernate,
it is going to remain as it is, and if backports to previous versions are needed, the backports
will be adapted.

- Issue History
Date Modified Username Field Change
2018-08-16 12:12 ioritzCia New Issue
2018-08-16 12:12 ioritzCia Assigned To => StoreServer
2018-08-16 12:12 ioritzCia Resolution time => 1538344800
2018-08-16 12:12 ioritzCia Triggers an Emergency Pack => No
2018-08-17 00:25 mtaal Note Added: 0106372
2018-09-05 09:28 ioritzCia Relationship added related to 0039090
2018-09-11 12:10 mtaal Assigned To StoreServer => mtaal
2018-09-19 14:59 adrianromero Relationship added related to 0039319
2018-09-24 08:41 AugustoMauch Relationship replaced has duplicate 0039090
2018-09-24 23:13 mtaal File Added: hb-upgrade-replication.diff
2018-09-25 23:22 mtaal File Deleted: hb-upgrade-replication.diff
2018-09-25 23:22 mtaal File Added: retail-sync.diff
2018-09-25 23:23 mtaal File Added: repl.diff
2018-10-01 05:48 hgbot Checkin
2018-10-01 05:48 hgbot Note Added: 0107080
2018-10-01 05:48 mtaal Review Assigned To => AugustoMauch
2018-10-01 05:52 hgbot Checkin
2018-10-01 05:52 hgbot Note Added: 0107082
2018-10-01 05:52 hgbot Status new => resolved
2018-10-01 05:52 hgbot Resolution open => fixed
2018-10-01 05:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/3492b2625a65154784ae6e02f1fe8a02fcb7ca2b [^]
2018-10-02 17:11 AugustoMauch Note Added: 0107120
2018-10-02 17:11 AugustoMauch Status resolved => new
2018-10-02 17:11 AugustoMauch Resolution fixed => open
2018-10-03 13:27 hgbot Checkin
2018-10-03 13:27 hgbot Note Added: 0107137
2018-10-03 13:28 hgbot Checkin
2018-10-03 13:28 hgbot Note Added: 0107138
2018-10-03 13:28 AugustoMauch Note Added: 0107139
2018-10-03 13:28 AugustoMauch Status new => closed
2018-10-03 13:28 AugustoMauch Resolution open => no change required


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker